ICEfaces
  1. ICEfaces
  2. ICE-1738

history-frame iframe causes IE 7 to add padding to top of page

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.5
    • Fix Version/s: 1.6DR#6, 1.6
    • Component/s: Bridge
    • Labels:
      None
    • Environment:
      any icefaces application, IE

      Description

      This issue was first seen in the .org site during early development. I'm currently working on some style sheets fixes for he component showcase and introduced this issue in IE 7.

      When a users navigates from link to link in the navigation tree a white header appears at the top of the page. This can be fixed with a page refresh. I had a fix for this a while back but it broke Safari. The fix is a follows:

      #history-frame{
          display: none;
      }

      I've tested this fix on Safari Beta 3 on Windows and it seems to work well. I need to have a mac person try this fix out by adding the above line to any ICEfaces application css. If I remember correctly, the css managed to mess up dom updates.

      If the fix work then we need to either update the default history-frame iframe style attribute with this additional one. If it doesn't work on Safari then the fix would be best applied to only ie 7 using our outputStyle component.

        Activity

        Patrick Corless created issue -
        Hide
        Patrick Corless added a comment -

        Ted could you add the above css to an ICEfaces application of your choice and see if it causes and strange behavior in Safari on OSX?

        Show
        Patrick Corless added a comment - Ted could you add the above css to an ICEfaces application of your choice and see if it causes and strange behavior in Safari on OSX?
        Patrick Corless made changes -
        Field Original Value New Value
        Assignee Ted Goddard [ ted.goddard ]
        Hide
        Patrick Corless added a comment -

        After a little testing there is still an issue with the old version of Safari. The display: none; does indeed cause an assortment JavaScript errors.

        As a result the only work around is to apply the outputStyle component:

        <ice:outputStyle href="css/showcase_style.css" rel="stylesheet" type="text/css" />

        and create a new showcase_style_ie7.css sheet with the css fix. This fix should also be applied to the .org site.

        Actually until this is done I'll leave the bug open.

        Show
        Patrick Corless added a comment - After a little testing there is still an issue with the old version of Safari. The display: none; does indeed cause an assortment JavaScript errors. As a result the only work around is to apply the outputStyle component: <ice:outputStyle href="css/showcase_style.css" rel="stylesheet" type="text/css" /> and create a new showcase_style_ie7.css sheet with the css fix. This fix should also be applied to the .org site. Actually until this is done I'll leave the bug open.
        Patrick Corless made changes -
        Assignee Ted Goddard [ ted.goddard ] Patrick Corless [ patrick.corless ]
        Patrick Corless made changes -
        Component/s Sample Apps [ 10010 ]
        Component/s Components [ 10012 ]
        Hide
        Ken Fyten added a comment -

        Instead of forcing people to adjust the visibility of this iframe in their application CSS, we should modify the bridge that inserts this iframe to add the necessary css as well:

        For non-Safari browsers:

        display: none;

        For Safari browsers:

        visible: false;

        Show
        Ken Fyten added a comment - Instead of forcing people to adjust the visibility of this iframe in their application CSS, we should modify the bridge that inserts this iframe to add the necessary css as well: For non-Safari browsers: display: none; For Safari browsers: visible: false;
        Ken Fyten made changes -
        Environment any icefaces application any icefaces application, IE
        Component/s Bridge [ 10011 ]
        Component/s Sample Apps [ 10010 ]
        Fix Version/s 1.6 [ 10031 ]
        Assignee Priority P2
        Affects Version/s 1.5 [ 10027 ]
        Assignee Patrick Corless [ patrick.corless ] Mircea Toma [ mircea.toma ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #14168 Fri Jun 15 15:49:38 MDT 2007 mircea.toma Take the iframe out of the CSS flow -- ICE-1738.
        Files Changed
        Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/context/DOMResponseWriter.java
        Hide
        Mircea Toma added a comment -

        The magic incantation is ... 'postion: absolute;'. This CSS rule takes the iframe out of the CSS flow thus the page header is not affected anymore.

        Show
        Mircea Toma added a comment - The magic incantation is ... 'postion: absolute;'. This CSS rule takes the iframe out of the CSS flow thus the page header is not affected anymore.
        Mircea Toma made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Ken Fyten made changes -
        Fix Version/s 1.6DR#6 [ 10090 ]
        Fix Version/s 1.6 [ 10031 ]
        Ken Fyten made changes -
        Fix Version/s 1.6 [ 10031 ]
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Assignee Priority P2
        Assignee Mircea Toma [ mircea.toma ]

          People

          • Assignee:
            Unassigned
            Reporter:
            Patrick Corless
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: