ICEfaces
  1. ICEfaces
  2. ICE-1699

Runtime compatibility for JSF 1.2 implementations with JSPs

    Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.6DR#5
    • Fix Version/s: 1.6DR#6, 1.6
    • Component/s: Framework
    • Labels:
      None
    • Environment:
      ICEfaces, JSF 1.2
    • Affects:
      Documentation (User Guide, Ref. Guide, etc.), Compatibility/Configuration

      Description

      Although ICEfaces Facelets applications are now working against JSF 1.2, ICEfaces JSP applications typically fail in the page parsing stage.

        Activity

        Repository Revision Date User Message
        ICEsoft Public SVN Repository #14087 Thu Jun 07 17:02:30 MDT 2007 ted.goddard special case for setName(ValueExpression) (ICE-1699)
        Files Changed
        Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/webapp/parser/ELSetPropertiesRule.java
        Commit graph MODIFY /icefaces/trunk/icefaces/core/build.xml
        Ted Goddard created issue -
        Ted Goddard made changes -
        Field Original Value New Value
        Assignee Ted Goddard [ ted.goddard ]
        Hide
        Ted Goddard added a comment -

        The recent checkin allows the standard component-showcase to work on glassfish-v2-b41 with the server-provided jsf implementation (the fix involves special-cases for how parameters are passed to JSP tags, so it may have indirect dependencies on Sun code).

        However, it currently exhibits the following problems:

        • selectInputDate component displays but is not interactive
        • page is blank on first render
        Show
        Ted Goddard added a comment - The recent checkin allows the standard component-showcase to work on glassfish-v2-b41 with the server-provided jsf implementation (the fix involves special-cases for how parameters are passed to JSP tags, so it may have indirect dependencies on Sun code). However, it currently exhibits the following problems: selectInputDate component displays but is not interactive page is blank on first render
        Hide
        Ted Goddard added a comment -

        auctionMonitor returns a blank page even on repeated reloads.

        Show
        Ted Goddard added a comment - auctionMonitor returns a blank page even on repeated reloads.
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #14092 Fri Jun 08 15:03:50 MDT 2007 ted.goddard render document immediately after parsing as JSF 1.2 ViewTag does not (ICE-1699)
        Files Changed
        Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/webapp/parser/ImplementationUtil.java
        Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/webapp/parser/ComponentRuleSet.java
        Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/application/D2DViewHandler.java
        Hide
        Ted Goddard added a comment -

        component-showcase and auctionMonitor are now working in JSP mode with JSF 1.2.

        D2DViewHandler is now checking specifically for JSF 1.2 and, if detected, renders the page at the end of parsing. In JSF 1.1, the ViewTag invokes this rendering, but this does not appear to occur with JSF 1.2.

        Show
        Ted Goddard added a comment - component-showcase and auctionMonitor are now working in JSP mode with JSF 1.2. D2DViewHandler is now checking specifically for JSF 1.2 and, if detected, renders the page at the end of parsing. In JSF 1.1, the ViewTag invokes this rendering, but this does not appear to occur with JSF 1.2.
        Ted Goddard made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Ted Goddard added a comment -

        The integration should be improved so that a single icefaces.jar can handle both the JSF 1.2 case and the JSF 1.1 case.

        This likely requires building the stock icefaces.jar with JDK 1.5 (because the JSF 1.2 classes will be JDK 1.5 versioned).

        Show
        Ted Goddard added a comment - The integration should be improved so that a single icefaces.jar can handle both the JSF 1.2 case and the JSF 1.1 case. This likely requires building the stock icefaces.jar with JDK 1.5 (because the JSF 1.2 classes will be JDK 1.5 versioned).
        Ted Goddard made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #14100 Mon Jun 11 10:18:23 MDT 2007 ted.goddard detect JSF 1.2 under Java 1.4 and 1.5, include jsf-api-1.2.jar from jsf-1.2_04-b10-p01, and fix core/build.xml so common JSF 1.1/.12 icefaces.jar can be created for Java 1.4 and 1.5 on 1.5 (ICE-1699)
        Files Changed
        Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/webapp/parser/ComponentRuleSet.java
        Commit graph MODIFY /icefaces/trunk/icefaces/component/build.xml
        Commit graph ADD /icefaces/trunk/icefaces/lib/jsf-api-1.2.jar
        Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/webapp/parser/ELSetPropertiesRule.java
        Commit graph MODIFY /icefaces/trunk/icefaces/core/build.xml
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #14101 Mon Jun 11 10:46:25 MDT 2007 ted.goddard updated license document for jsf-api-1.2.jar (ICE-1699)
        Files Changed
        Commit graph MODIFY /icefaces/trunk/icefaces/lib/versions-licenses.html
        Hide
        Ted Goddard added a comment -

        A new .jar file, lib/jsf-api-1.2.jar (JSF 1.2 interfaces) has been added, so
        if you are building against everything in icefaces/lib
        you are bound to have problems (JSP classes not found).

        A full icefaces.jar is now intended to be built on JDK 1.5
        with 1.4 targets for the bulk of the classes and 1.5 targets
        for only the tomcat 6 and JSF 1.2 portions. (A .jar built in
        this way would be portable to JSF 1.2 and 1.2 on both
        JDK 1.4 and 1.5.)

        auctionMonitor and component-showcase in JSP mode should now
        work with JSF 1.2 on glassfish, although the builds
        for these samples are not targeted for this configuration
        (they need .jar files removed: el-api.jar, jstl.jar,
        xercesImpl.jar, xml-apis.jar, jsf-api.jar, and jsf-impl.jar).

        Note that this does not address the JSF 1.2/1.2 "compatibility mode"
        scenario raised in ICE-1474; ICEfaces applications still require
        JSF 1.1 faces-config.xml.

        Show
        Ted Goddard added a comment - A new .jar file, lib/jsf-api-1.2.jar (JSF 1.2 interfaces) has been added, so if you are building against everything in icefaces/lib you are bound to have problems (JSP classes not found). A full icefaces.jar is now intended to be built on JDK 1.5 with 1.4 targets for the bulk of the classes and 1.5 targets for only the tomcat 6 and JSF 1.2 portions. (A .jar built in this way would be portable to JSF 1.2 and 1.2 on both JDK 1.4 and 1.5.) auctionMonitor and component-showcase in JSP mode should now work with JSF 1.2 on glassfish, although the builds for these samples are not targeted for this configuration (they need .jar files removed: el-api.jar, jstl.jar, xercesImpl.jar, xml-apis.jar, jsf-api.jar, and jsf-impl.jar). Note that this does not address the JSF 1.2/1.2 "compatibility mode" scenario raised in ICE-1474 ; ICEfaces applications still require JSF 1.1 faces-config.xml.
        Hide
        Ted Goddard added a comment -

        ICEfaces is now compatible with JSF 1.2 for both Facelets and JSP, subject to the JSF 1.1 faces-config.xml in ICE-1474.

        Show
        Ted Goddard added a comment - ICEfaces is now compatible with JSF 1.2 for both Facelets and JSP, subject to the JSF 1.1 faces-config.xml in ICE-1474 .
        Ted Goddard made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Fix Version/s 1.6 [ 10031 ]
        Resolution Fixed [ 1 ]
        Ken Fyten made changes -
        Issue Type Bug [ 1 ] Improvement [ 4 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #14173 Mon Jun 18 10:03:11 MDT 2007 ted.goddard special case for actionListener (ICE-1699)
        Files Changed
        Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/webapp/parser/ELSetPropertiesRule.java
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #14174 Mon Jun 18 11:11:58 MDT 2007 ted.goddard coerce integer JSP parameters (ICE-1699)
        Files Changed
        Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/webapp/parser/ELSetPropertiesRule.java
        Hide
        Ted Goddard added a comment -

        Probably should have re-opened this before, but the recent checkins address the need for more specific types expected by the standard JSF components. (ICEfaces components are using pre JSP 2.1 tags, hence are content with Object or String.)
        This likely does not cover all the required cases, so additional testing is necessary.

        Show
        Ted Goddard added a comment - Probably should have re-opened this before, but the recent checkins address the need for more specific types expected by the standard JSF components. (ICEfaces components are using pre JSP 2.1 tags, hence are content with Object or String.) This likely does not cover all the required cases, so additional testing is necessary.
        Hide
        Ted Goddard added a comment -

        Please test the samples and tutorials on Tomcat 6 and GlassFish.

        Show
        Ted Goddard added a comment - Please test the samples and tutorials on Tomcat 6 and GlassFish.
        Ted Goddard made changes -
        Assignee Ted Goddard [ ted.goddard ] Arran McCullough [ amccullough ]
        Hide
        Ted Goddard added a comment -

        Re-opening to account for testing results.

        Show
        Ted Goddard added a comment - Re-opening to account for testing results.
        Ted Goddard made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #14177 Mon Jun 18 13:42:17 MDT 2007 ted.goddard coerce Boolean JSP parameters (ICE-1699)
        Files Changed
        Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/webapp/parser/ELSetPropertiesRule.java
        Hide
        Arran McCullough added a comment -

        Tested under Glassfish V2-b41 and Tomcat 6.0
        Auction Monitor - Works for both
        Address Demo - Works for both
        Component Showcase - Works for both but exhibits some styling issues, changing theme to royale puts a blue overlay on top of everything, big space between navigation tree and component content area, top header image is broken up.
        basicInputText - Works for both
        dragdrop1 - Works for both
        dragdrop2 - Page loads ok but cannot drag the grey area, throws no errors, same for both
        effects1 - Works for both
        effects2 - Same as dragdrop2, page shows, components aren't functional
        tiles - Shows everything except the body of the timezone part, throws error
        timezone1 to 7 - Works for both

        Show
        Arran McCullough added a comment - Tested under Glassfish V2-b41 and Tomcat 6.0 Auction Monitor - Works for both Address Demo - Works for both Component Showcase - Works for both but exhibits some styling issues, changing theme to royale puts a blue overlay on top of everything, big space between navigation tree and component content area, top header image is broken up. basicInputText - Works for both dragdrop1 - Works for both dragdrop2 - Page loads ok but cannot drag the grey area, throws no errors, same for both effects1 - Works for both effects2 - Same as dragdrop2, page shows, components aren't functional tiles - Shows everything except the body of the timezone part, throws error timezone1 to 7 - Works for both
        Hide
        Ted Goddard added a comment -

        Theoretically we should implement type safety for JSP 2.1 using javax.servlet.jsp.tagext.TagInfo, but these info classes are not available because they are not created by the ICEfaces TLD parser.

        Show
        Ted Goddard added a comment - Theoretically we should implement type safety for JSP 2.1 using javax.servlet.jsp.tagext.TagInfo, but these info classes are not available because they are not created by the ICEfaces TLD parser.
        Hide
        Ted Goddard added a comment -

        dragdrop2 and effectsd problems appear to be caused by <jsp:forward page="./dragdrop.iface" /> in index.jsp (replace with dragdrop.iface). Will create a separate JIRA for this.

        Show
        Ted Goddard added a comment - dragdrop2 and effectsd problems appear to be caused by <jsp:forward page="./dragdrop.iface" /> in index.jsp (replace with dragdrop.iface). Will create a separate JIRA for this.
        Hide
        Ted Goddard added a comment -

        Testing indicates that bug is resolved. Created ICE-1751 for the non-interactive tutorials (bug unrelated to JSF 1.2 support).

        Show
        Ted Goddard added a comment - Testing indicates that bug is resolved. Created ICE-1751 for the non-interactive tutorials (bug unrelated to JSF 1.2 support).
        Ted Goddard made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Ken Fyten made changes -
        Issue Type Improvement [ 4 ] New Feature [ 2 ]
        Ken Fyten made changes -
        Summary ICEfaces JSP applications do not work with JSF 1.2 Support ICEfaces JSP applications with JSF 1.2 runtimes
        Ken Fyten made changes -
        Affects [Documentation (User Guide, Ref. Guide, etc.), Compatibility/Configuration]
        Ken Fyten made changes -
        Summary Support ICEfaces JSP applications with JSF 1.2 runtimes Runtime compatibility for JSF 1.2 implementations with JSPs
        Ken Fyten made changes -
        Fix Version/s 1.6DR#6 [ 10090 ]
        Fix Version/s 1.6 [ 10031 ]
        Ken Fyten made changes -
        Fix Version/s 1.6 [ 10031 ]
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Assignee Arran McCullough [ amccullough ]

          People

          • Assignee:
            Unassigned
            Reporter:
            Ted Goddard
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: