ICEfaces
  1. ICEfaces
  2. ICE-1651

Facelets component-showcase combining charts breaks on revisit

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 1.6DR#5
          • Fix Version/s: 1.6DR#6, 1.6
          • Component/s: Sample Apps
          • Labels:
            None
          • Environment:
            WinXP SP2, Firefox 1.5.0.11, JBoss 4.0.4 GA
          • Affects:
            Sample App./Tutorial
          • Workaround Exists:
            Yes
          • Workaround Description:
            Use the JSP component-showcase.

            Description

            Build the Facelets version of component showcase. Go to the Components/Charts/Combining Charts section. Notice how the chart shows up fine. Click on the navigation tree to see some other display, and then click on Combining Charts again. This second view will not work properly, the chart image won't display.

              Activity

              Ascending order - Click to sort in descending order
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #14007 Tue May 29 14:52:49 MDT 2007 mark.collette ICE-1651 : Facelets component-showcase combining charts breaks on revisit
              Files Changed
              Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/outputchart/OutputChartRenderer.java
              Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/outputchart/OutputChart.java
              Commit graph MODIFY /icefaces/trunk/icefaces/samples/component-showcase/src/com/icesoft/icefaces/samples/showcase/components/charts/CombinedChartBean.java
              Mark Collette created issue -
              Mark Collette made changes -
              Field Original Value New Value
              Assignee Mark Collette [ mark.collette ]
              Hide
              Permalink
              Mark Collette added a comment -

              The JSP version of component-showcase uses static includes, and the Facelets version uses dynamic includes, which means that the JSP version has on monolithic long-lived component tree, whereas the Facelets version's chart component gets remade each time you visit it, which the associated bean did not account for.

              While I was investigating the issue, I found that OutputChart did not implement the saveState and restoreState functionality, so I added that, plus some random tweaks.

              Subversion 14007
              icefaces\samples\component-showcase\src\com\icesoft\icefaces\samples\showcase\components\charts\CombinedChartBean.java
              icefaces\component\src\com\icesoft\faces\component\outputchart\OutputChart.java
              icefaces\component\src\com\icesoft\faces\component\outputchart\OutputChartRenderer.java

              Show
              Mark Collette added a comment - The JSP version of component-showcase uses static includes, and the Facelets version uses dynamic includes, which means that the JSP version has on monolithic long-lived component tree, whereas the Facelets version's chart component gets remade each time you visit it, which the associated bean did not account for. While I was investigating the issue, I found that OutputChart did not implement the saveState and restoreState functionality, so I added that, plus some random tweaks. Subversion 14007 icefaces\samples\component-showcase\src\com\icesoft\icefaces\samples\showcase\components\charts\CombinedChartBean.java icefaces\component\src\com\icesoft\faces\component\outputchart\OutputChart.java icefaces\component\src\com\icesoft\faces\component\outputchart\OutputChartRenderer.java
              Mark Collette made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Fix Version/s 1.6 [ 10031 ]
              Affects [Sample App./Tutorial]
              Resolution Fixed [ 1 ]
              Ken Fyten made changes -
              Fix Version/s 1.6DR#6 [ 10090 ]
              Fix Version/s 1.6 [ 10031 ]
              Ken Fyten made changes -
              Fix Version/s 1.6 [ 10031 ]
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]
              Assignee Mark Collette [ mark.collette ]

                People

                • Assignee:
                  Unassigned
                  Reporter:
                  Mark Collette
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: