ICEfaces
  1. ICEfaces
  2. ICE-1649

Component Attribute issues from 1.5.3 to 1.6

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 1.6DR#4
    • Fix Version/s: 1.6DR#6, 1.6
    • Component/s: ICE-Components
    • Labels:
      None
    • Environment:
      All
    • Affects:
      Compatibility/Configuration

      Description

      It seems that the conversion to the meta-data based TLD and component generator for 1.6 has resulted in numerous comp. attributes being missed that were present in 1.5.3.

      For example, a few attributes where lost for the panelTabset component. Mainly the attribute "iconAlignRight" which by its name would indicate that there are other similarly named attributes that are missing.


      1. components-attributes-1.html
        74 kB
        Ken Fyten
      2. components-attributes-1.xls
        81 kB
        Ken Fyten
      3. components-attributes-2.doc
        78 kB
        Ken Fyten
      4. components-attributes-2.html
        32 kB
        Ken Fyten

        Activity

        Patrick Corless created issue -
        Patrick Corless made changes -
        Field Original Value New Value
        Estimated Complexity Low
        Assignee Priority P2
        Affects Version/s 1.6DR#4 [ 10060 ]
        Assignee Adnan Durrani [ adnan.durrani ]
        Priority Major [ 3 ] Minor [ 4 ]
        Ken Fyten made changes -
        Summary PanelTab Component Attribute issues Component Attribute issues from 1.5.3 to 1.6
        Environment panelTab component showcase example All
        Fix Version/s 1.6 [ 10031 ]
        Affects [Compatibility/Configuration]
        Assignee Priority P2 P1
        Description At some point during the TLD refactoring for ICEfaces Components a few attributes where lost for the panelTabset component.

        Mainly the attribute "iconAlignRight" which by its name would indicate that there are other similarly named attributes that are missing. If these where intensionally removed could update this bug with how the icon alignment for tabs can be set.

        It seems that the conversion to the meta-data based TLD and component generator for 1.6 has resulted in numerous comp. attributes being missed that were present in 1.5.3.

        For example, a few attributes where lost for the panelTabset component. Mainly the attribute "iconAlignRight" which by its name would indicate that there are other similarly named attributes that are missing.


        Security Private [ 10001 ]
        Priority Minor [ 4 ] Critical [ 2 ]
        Hide
        Ken Fyten added a comment -

        Part one of 2 listing of all comp. attribute differences between 1.5.3 and 1.6 DR#5.

        Show
        Ken Fyten added a comment - Part one of 2 listing of all comp. attribute differences between 1.5.3 and 1.6 DR#5.
        Ken Fyten made changes -
        Attachment components-attributes1.html [ 10445 ]
        Ken Fyten made changes -
        Attachment components-attributes1.html [ 10445 ]
        Hide
        Ken Fyten added a comment -

        1st half of components listing 1.5 vs 1.6 comp. attributes (1 of 2)

        Show
        Ken Fyten added a comment - 1st half of components listing 1.5 vs 1.6 comp. attributes (1 of 2)
        Ken Fyten made changes -
        Attachment components-attributes-1.html [ 10446 ]
        Hide
        Ken Fyten added a comment -

        1 of 2 in .xls format.

        Show
        Ken Fyten added a comment - 1 of 2 in .xls format.
        Ken Fyten made changes -
        Attachment components-attributes-1.xls [ 10447 ]
        Hide
        Ken Fyten added a comment -

        Second half of comp. attribute analysis.

        Show
        Ken Fyten added a comment - Second half of comp. attribute analysis.
        Ken Fyten made changes -
        Attachment components-attributes-2.html [ 10448 ]
        Hide
        Ken Fyten added a comment -

        2 of 2 in doc format.

        Show
        Ken Fyten added a comment - 2 of 2 in doc format.
        Ken Fyten made changes -
        Attachment components-attributes-2.doc [ 10449 ]
        Adnan Durrani made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Hide
        Adnan Durrani added a comment -

        The meta-data has been updated to reflect the adequate attributes on the components. -revision 14027

        Show
        Adnan Durrani added a comment - The meta-data has been updated to reflect the adequate attributes on the components. -revision 14027
        Adnan Durrani made changes -
        Status In Progress [ 3 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Adnan Durrani added a comment -

        The TldGenerator was adding all visible properties form its parent class to the component's tag class, even if the attribute was not defined in the meta-data. In order to prohibit it we had disabled this behavior in above check-in.

        In future all classes of the components will be generating using the meta-data as well. So as a preliminary step we have decided to not to disable this behavior instead use UIComponent classes as parent class of the component only for meta data (tag class generation). -revision 14031

        Show
        Adnan Durrani added a comment - The TldGenerator was adding all visible properties form its parent class to the component's tag class, even if the attribute was not defined in the meta-data. In order to prohibit it we had disabled this behavior in above check-in. In future all classes of the components will be generating using the meta-data as well. So as a preliminary step we have decided to not to disable this behavior instead use UIComponent classes as parent class of the component only for meta data (tag class generation). -revision 14031
        Hide
        Adnan Durrani added a comment -

        In order to complete the tld, missing properties added to the component classes. -revision14032

        Show
        Adnan Durrani added a comment - In order to complete the tld, missing properties added to the component classes. -revision14032
        Ken Fyten made changes -
        Fix Version/s 1.6DR#6 [ 10090 ]
        Fix Version/s 1.6 [ 10031 ]
        Ken Fyten made changes -
        Fix Version/s 1.6 [ 10031 ]
        Ken Fyten made changes -
        Security Private [ 10001 ]
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Assignee Priority P1
        Assignee Adnan Durrani [ adnan.durrani ]

          People

          • Assignee:
            Unassigned
            Reporter:
            Patrick Corless
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: