ICEfaces
  1. ICEfaces
  2. ICE-1603

<ice:inputFile/> rendered <iframe> is not transparent and only looks good on a white background

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.6DR#4
    • Fix Version/s: 1.6DR#5, 1.6
    • Component/s: None
    • Labels:
      None
    • Environment:
      Tomcat 5.5.17 / Liferay 4.3.0 (pre-release)

      Description

      The <ice:inputFile/> component renders itself as an HTML <iframe>. However, the <iframe> is not transparent, and therefore only looks good on a white background.

      Fixes are attached.
      1. InputFile.java
        27 kB
        Neil Griffin
      2. InputFileRenderer.java
        5 kB
        Neil Griffin

        Activity

        Hide
        Neil Griffin added a comment -

        Search for ICE-1603 in the attached files, and you will see the fixes.

        Show
        Neil Griffin added a comment - Search for ICE-1603 in the attached files, and you will see the fixes.
        Hide
        Adnan Durrani added a comment -

        Neil's suggested fix applied. -revision 13946

        Show
        Adnan Durrani added a comment - Neil's suggested fix applied. -revision 13946
        Hide
        Neil Griffin added a comment -

        Adnan,

        I did an "svn update" on the trunk just now. Thank you for updating InputFile.java, by putting the "background-color:transparent" to the <body> tag.

        However, the InputFileRenderer.java patch does not seem to be applied:

        // ngriffin@liferay.com: http://jira.icefaces.org/browse/ICE-1603
        // Need to set allowtransparency="true" on the IFRAME element tag so that,
        // along with InputFile.renderIFrame()'s <body style="background-color: transparent;">, the IFRAME
        // will be transparent, allowing the portal theme background colors to show through.
        writer.writeAttribute("allowtransparency", "true", null);

        Thanks for all your help!!

        Neil

        Show
        Neil Griffin added a comment - Adnan, I did an "svn update" on the trunk just now. Thank you for updating InputFile.java, by putting the "background-color:transparent" to the <body> tag. However, the InputFileRenderer.java patch does not seem to be applied: // ngriffin@liferay.com: http://jira.icefaces.org/browse/ICE-1603 // Need to set allowtransparency="true" on the IFRAME element tag so that, // along with InputFile.renderIFrame()'s <body style="background-color: transparent;">, the IFRAME // will be transparent, allowing the portal theme background colors to show through. writer.writeAttribute("allowtransparency", "true", null); Thanks for all your help!! Neil
        Hide
        Neil Griffin added a comment -

        Ooops!

        I spoke to soon. You did indeed add the InputFileRenderer patch, but further down in the code, so I missed it at first in the diff!!

        Sorry to waste your time – all is well one this one.

        Thanks,

        Neil

        Show
        Neil Griffin added a comment - Ooops! I spoke to soon. You did indeed add the InputFileRenderer patch, but further down in the code, so I missed it at first in the diff!! Sorry to waste your time – all is well one this one. Thanks, Neil

          People

          • Assignee:
            Unassigned
            Reporter:
            Neil Griffin
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: