ICEfaces
  1. ICEfaces
  2. ICE-1599

Typo in main servlet name within BlockingServlet.java

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Won't Fix
    • Affects Version/s: 1.6DR#4
    • Fix Version/s: 1.6DR#5
    • Component/s: None
    • Labels:
      None
    • Environment:
      Windows XP / Tomcat 5.5.17 / Liferay 4.3.0 (pre-release)

      Description

      Line 51 of BlockingServlet.java has this line:

              dispatcher = servletConfig.getServletContext().getNamedDispatcher("Persistent Faces Servlet");

      But it has a type in the servlet name. Should beL

              dispatcher = servletConfig.getServletContext().getNamedDispatcher("Main Servlet");

      This was revealed by a failing <ice:inputFile/> file upload.


      Neil

        Activity

        Neil Griffin created issue -
        Adnan Durrani made changes -
        Field Original Value New Value
        Assignee Mircea Toma [ mircea.toma ]
        Hide
        Mircea Toma added a comment -

        This doesn't look right. "Main Servlet" is not registered in web.xml file thus you cannot look it up. Is there a related bug for <ice:inputFile> problem?

        Show
        Mircea Toma added a comment - This doesn't look right. "Main Servlet" is not registered in web.xml file thus you cannot look it up. Is there a related bug for <ice:inputFile> problem?
        Neil Griffin made changes -
        Attachment web.xml [ 10419 ]
        Hide
        Neil Griffin added a comment -

        I was told by Jack and Deryk to put this in my web.xml file:

        <servlet>
        <servlet-name>Main Servlet</servlet-name>
        <servlet-class>com.icesoft.faces.webapp.http.servlet.MainServlet</servlet-class>
        <load-on-startup>1</load-on-startup>
        </servlet>

        So indeed it can be looked up.

        I've attached an entire web.xml file to this issue so you can see the entire thing.

        Thanks,

        Neil

        Show
        Neil Griffin added a comment - I was told by Jack and Deryk to put this in my web.xml file: <servlet> <servlet-name>Main Servlet</servlet-name> <servlet-class>com.icesoft.faces.webapp.http.servlet.MainServlet</servlet-class> <load-on-startup>1</load-on-startup> </servlet> So indeed it can be looked up. I've attached an entire web.xml file to this issue so you can see the entire thing. Thanks, Neil
        Ken Fyten made changes -
        Fix Version/s 1.6DR#5 [ 10071 ]
        Assignee Priority P1
        Hide
        Deryk Sinotte added a comment -

        Trying going back to the "old-school" servlet and mappings as I summarized in http://jira.icefaces.org/browse/ICE-1607. Looks like registering and mapping Main Servlet is not currently officially supported.

        Show
        Deryk Sinotte added a comment - Trying going back to the "old-school" servlet and mappings as I summarized in http://jira.icefaces.org/browse/ICE-1607 . Looks like registering and mapping Main Servlet is not currently officially supported.
        Hide
        Ken Fyten added a comment -

        The new "main' servlet should not be used with 1.6.0. It is likely to undergo further changes in the future, including repackaging, etc.

        To ensure backwards compatibility, please use the original ICEfaces servlet configurations from 1.5.

        Show
        Ken Fyten added a comment - The new "main' servlet should not be used with 1.6.0. It is likely to undergo further changes in the future, including repackaging, etc. To ensure backwards compatibility, please use the original ICEfaces servlet configurations from 1.5.
        Ken Fyten made changes -
        Status Open [ 1 ] Closed [ 6 ]
        Assignee Priority P1
        Resolution Won't Fix [ 2 ]
        Assignee Mircea Toma [ mircea.toma ]

          People

          • Assignee:
            Unassigned
            Reporter:
            Neil Griffin
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: