Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 1.6DR#1
-
Component/s: ICE-Components
-
Labels:None
-
Environment:WinXP SP2, Firefox 1.5.0.11, JBoss 4.0.4 GA, JSP component-showcase
-
Workaround Exists:Yes
-
Workaround Description:Use Facelets instead of JSP
Description
In icefaces\component-metadata\src\main\resources\conf there are a bunch of xml files for the components, with <property-class>java.lang.Boolean</property-class> sections.
As well, in some of the components, the property getters and setters do not follow the JSF norm of:
public Boolean getProperty() {
if (property!= null)
return property;
ValueBinding vb = getValueBinding("property");
if (vb != null)
return (Boolean) vb.getValue(getFacesContext());
return Boolean.FALSE;
}
public void setProperty(Boolean property) {
this.property = property;
}
Together, these create a problem for JSP applications that have components tags using these attributes with non-ValueBinding values.
Specifically, the expanded attribute on the panelAccordion component is one, but my searches found more instances of this issue. What's less known is if all of the other primitive attributes share this issue, like java.lang.Integer.
As well, in some of the components, the property getters and setters do not follow the JSF norm of:
public Boolean getProperty() {
if (property!= null)
return property;
ValueBinding vb = getValueBinding("property");
if (vb != null)
return (Boolean) vb.getValue(getFacesContext());
return Boolean.FALSE;
}
public void setProperty(Boolean property) {
this.property = property;
}
Together, these create a problem for JSP applications that have components tags using these attributes with non-ValueBinding values.
Specifically, the expanded attribute on the panelAccordion component is one, but my searches found more instances of this issue. What's less known is if all of the other primitive attributes share this issue, like java.lang.Integer.
Activity
| Repository | Revision | Date | User | Message |
| ICEsoft Public SVN Repository | #13772 | Thu May 03 15:30:45 MDT 2007 | mark.collette | |
| Files Changed | ||||
MODIFY
/icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/accordion/PanelAccordion.java
MODIFY
/icefaces/trunk/icefaces/component-metadata/src/main/resources/conf/ice_cust_properties/cust-accordion-props.xml
|
| Field | Original Value | New Value |
|---|---|---|
| Fix Version/s | 1.6 [ 10031 ] | |
| Affects Version/s | 1.6DR#4 [ 10060 ] | |
| Assignee | Mark Collette [ mark.collette ] |
| Assignee Priority | P2 |
| Assignee Priority | P2 | P1 |
| Assignee Priority | P1 | P3 |
| Assignee Priority | P3 | P1 |
| Summary | JSP Tags have wrong primitive attribute metadata | panelAccordion.expanded had wrong attribute metadata |
| Status | Open [ 1 ] | Resolved [ 5 ] |
| Resolution | Fixed [ 1 ] |
| Fix Version/s | 1.6DR#5 [ 10071 ] | |
| Fix Version/s | 1.6 [ 10031 ] |
| Assignee Priority | P1 | |
| Affects Version/s | 1.6DR#1 [ 10035 ] | |
| Affects Version/s | 1.6DR#4 [ 10060 ] | |
| Security | Private [ 10001 ] | |
| Assignee | Mark Collette [ mark.collette ] |
| Fix Version/s | 1.6 [ 10031 ] |
| Status | Resolved [ 5 ] | Closed [ 6 ] |
Fixed panelAccordion.expanded
Subversion 13772
icefaces\component-metadata\src\main\resources\conf\ice_cust_properties\cust-accordion-props.xml
icefaces\component\src\com\icesoft\faces\component\accordion\PanelAccordion.java