ICEfaces
  1. ICEfaces
  2. ICE-1530

RenderManager throws a NullPointerException if state is null.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.6DR#3
    • Fix Version/s: 1.6DR#4, 1.6
    • Component/s: None
    • Labels:
      None
    • Environment:
      All

      Description

      When the RenderManager attempts to render a Renderable instance, it is possible for that state to be null. Currently, this throws a NullPointerException. It should be handled a bit more elegantly.

        Activity

        Repository Revision Date User Message
        ICEsoft Public SVN Repository #13766 Thu May 03 12:00:37 MDT 2007 deryk.sinotte ICE-1530 Pass a TransientRenderingException back to the Renderable instance when the state is null.
        Files Changed
        Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/async/render/RunnableRender.java
        Deryk Sinotte created issue -
        Hide
        Deryk Sinotte added a comment -

        The validity of the PersistentFacesState is the responsiblity of the application. In certain situations, the state can be null which requires modification in the application (best practices should be documented). Rather than let it toss an NPE, we should check for the state being null and then pass a TransientRenderingException back to the Renderable instance that provides the state. This is the current exception handling design for the RenderManager. I've made the changes to support this decision.

        Show
        Deryk Sinotte added a comment - The validity of the PersistentFacesState is the responsiblity of the application. In certain situations, the state can be null which requires modification in the application (best practices should be documented). Rather than let it toss an NPE, we should check for the state being null and then pass a TransientRenderingException back to the Renderable instance that provides the state. This is the current exception handling design for the RenderManager. I've made the changes to support this decision.
        Hide
        Deryk Sinotte added a comment -

        Assigning to Deryk and marking as FIXED.

        Show
        Deryk Sinotte added a comment - Assigning to Deryk and marking as FIXED.
        Deryk Sinotte made changes -
        Field Original Value New Value
        Status Open [ 1 ] Resolved [ 5 ]
        Fix Version/s 1.6DR#4 [ 10060 ]
        Assignee Priority P2
        Resolution Fixed [ 1 ]
        Assignee Deryk Sinotte [ deryk.sinotte ]
        Ken Fyten made changes -
        Fix Version/s 1.6 [ 10031 ]
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Assignee Priority P2
        Assignee Deryk Sinotte [ deryk.sinotte ]

          People

          • Assignee:
            Unassigned
            Reporter:
            Deryk Sinotte
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: