ICEfaces
  1. ICEfaces
  2. ICE-1522

Component showcase chart and dynamic chart scope issues

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.6DR#1, 1.6DR#2, 1.6DR#3, 1.6DR#4, 1.6
    • Fix Version/s: 1.6DR#4, 1.6
    • Component/s: Sample Apps
    • Labels:
      None
    • Environment:
      Browser and OS independent issue on any build of component showcase beyond 1.5.3.
    • Affects:
      Sample App./Tutorial

      Description

      This bug covers 3 sub issues related to the chart component.

      1. Adding new data to the dynamic chart globally affects the backend list of data. So if User A adds a new slice to the dynamic chart named "Test" with a value of 30.0, and User B later visits component showcase, he will see this added data, instead of a default "clean slate".

      2. The currently selected chart is stored statically and between sessions. So if User A selects the Line Chart, then the default chart initially shown to User B (who later visits component showcase) will be Line Chart, instead of the true default of Bar Chart. This creates another issue if the last selected chart is pie2D or pie3D, as they will not be initialized properly for the next user, but will still be displayed.

      3. For every additional user that views the pie2D or pie3D charts, the backend data will be reread into a static and global list. What this means is that over time the pie charts will continue to have more and more data added to them, until they are unreadable.

        Activity

        Repository Revision Date User Message
        ICEsoft Public SVN Repository #13715 Wed May 02 14:08:21 MDT 2007 carlo.guglielmin ICE-1522 - fixed the three subissues related to the chart component. Basically removed a lot of unecessary static variables and global lists, and pushed much of the data into session scope
        Files Changed
        Commit graph MODIFY /icefaces/trunk/icefaces/samples/component-showcase/src/com/icesoft/icefaces/samples/showcase/components/charts/PieChartBean.java
        Commit graph MODIFY /icefaces/trunk/icefaces/samples/component-showcase/src/com/icesoft/icefaces/samples/showcase/components/charts/ChartMediator.java
        Commit graph MODIFY /icefaces/trunk/icefaces/samples/component-showcase/web/WEB-INF/faces-config.xml
        Commit graph MODIFY /icefaces/trunk/icefaces/samples/component-showcase/src/com/icesoft/icefaces/samples/showcase/components/charts/DynamicPieChart.java
        Commit graph MODIFY /icefaces/trunk/icefaces/samples/component-showcase/src/com/icesoft/icefaces/samples/showcase/components/charts/ChartFactory.java
        Commit graph MODIFY /icefaces/trunk/icefaces/samples/component-showcase/src/com/icesoft/icefaces/samples/showcase/components/charts/Chart.java
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #13717 Wed May 02 14:23:17 MDT 2007 carlo.guglielmin ICE-1522 - ported updates to the seam version of component showcase
        Files Changed
        Commit graph MODIFY /projects/seam-component-showcase/trunk/seam-component-showcase/src/com/icesoft/icefaces/samples/showcase/components/charts/Chart.java
        Commit graph MODIFY /projects/seam-component-showcase/trunk/seam-component-showcase/src/com/icesoft/icefaces/samples/showcase/components/charts/ChartFactory.java
        Commit graph MODIFY /projects/seam-component-showcase/trunk/seam-component-showcase/src/com/icesoft/icefaces/samples/showcase/components/charts/DynamicPieChart.java
        Commit graph MODIFY /projects/seam-component-showcase/trunk/seam-component-showcase/src/com/icesoft/icefaces/samples/showcase/components/charts/ChartMediator.java
        Carlo Guglielmin created issue -
        Carlo Guglielmin made changes -
        Field Original Value New Value
        Assignee Carlo Guglielmin [ carlo.guglielmin ]
        Hide
        Carlo Guglielmin added a comment -

        Fixed in revision 13715 of component showcase. I pushed a lot of the static variables in the DynamicChartBean into session scope. Also removed more static variables from the other chart beans so they would stop rereading the same backend data, and stop determining the selected chart type at an application level of scope.

        Show
        Carlo Guglielmin added a comment - Fixed in revision 13715 of component showcase. I pushed a lot of the static variables in the DynamicChartBean into session scope. Also removed more static variables from the other chart beans so they would stop rereading the same backend data, and stop determining the selected chart type at an application level of scope.
        Carlo Guglielmin made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Fix Version/s 1.6 [ 10031 ]
        Affects [Sample App./Tutorial]
        Resolution Fixed [ 1 ]
        Ken Fyten made changes -
        Fix Version/s 1.6DR#4 [ 10060 ]
        Fix Version/s 1.6 [ 10031 ]
        Ken Fyten made changes -
        Fix Version/s 1.6 [ 10031 ]
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Assignee Carlo Guglielmin [ carlo.guglielmin ]

          People

          • Assignee:
            Unassigned
            Reporter:
            Carlo Guglielmin
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: