ICEfaces
  1. ICEfaces
  2. ICE-1468

inputFile silently fails in some cases

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.6DR#3
    • Fix Version/s: 1.6DR#4, 1.6
    • Component/s: ICE-Components
    • Labels:
      None
    • Environment:
      WinXP, Firefox 1.5.0.11, JBoss 4.0.4 GA, ICEfaces 1.6.0 DR3

      Description

      File uploads were mysteriously failing, with no exceptions or messages or actionListener invocation. Turns out that if you specify com.icesoft.faces.uploadDirectory in the web.xml for a directory that doesn't exist, then there would be an IOException on the server that would be trapped and ignored.

      Further investigation found that any error, even the ones properly trapped and messaged, would result in actionListener not being invoked.

        Activity

        Repository Revision Date User Message
        ICEsoft Public SVN Repository #13629 Fri Apr 20 20:14:00 MDT 2007 mark.collette ICE-1468 : inputFile silently fails in some cases
        Files Changed
        Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/inputfile/InputFile.java
        Mark Collette created issue -
        Mark Collette made changes -
        Field Original Value New Value
        Summary inputFile silently failed if missing upload dir inputFile silently fails in some cases
        Description File uploads were mysteriously failing, with no exceptions or messages. Turns out that if you specify com.icesoft.faces.uploadDirectory in the web.xml for a directory that doesn't exist, then there would be an IOException on the server that would be trapped and ignored.
        File uploads were mysteriously failing, with no exceptions or messages or actionListener invocation. Turns out that if you specify com.icesoft.faces.uploadDirectory in the web.xml for a directory that doesn't exist, then there would be an IOException on the server that would be trapped and ignored.

        Further investigation found that any error, even the ones properly trapped and messaged, would result in actionListener not being invoked.
        Mark Collette made changes -
        Fix Version/s 1.6DR#4 [ 10060 ]
        Assignee Mark Collette [ mark.collette ]
        Hide
        Mark Collette added a comment -
        • Make download directory (recursively) if it doesn't exist
        • Call actionListener if success and if failure
        • Give status of INVALID if unknown FileUploadBase.FileUploadIOException
        • Give status of INVALID if IOException

        Subversion 13629
        icefaces\component\src\com\icesoft\faces\component\inputfile\InputFile.java

        Show
        Mark Collette added a comment - Make download directory (recursively) if it doesn't exist Call actionListener if success and if failure Give status of INVALID if unknown FileUploadBase.FileUploadIOException Give status of INVALID if IOException Subversion 13629 icefaces\component\src\com\icesoft\faces\component\inputfile\InputFile.java
        Mark Collette made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #13740 Wed May 02 19:48:23 MDT 2007 mark.collette ICE-1468 : inputFile silently fails in some cases
        Files Changed
        Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/webapp/http/servlet/UploadServlet.java
        Hide
        Mark Collette added a comment -

        If no com.icesoft.faces.uploadDirectory context-param is given in the web.xml file, the UploadServlet was defaulting to "upload", whereas we don't want to make a subdirectory in that case.

        Subversion 13740
        icefaces\core\src\com\icesoft\faces\webapp\http\servlet\UploadServlet.java

        Show
        Mark Collette added a comment - If no com.icesoft.faces.uploadDirectory context-param is given in the web.xml file, the UploadServlet was defaulting to "upload", whereas we don't want to make a subdirectory in that case. Subversion 13740 icefaces\core\src\com\icesoft\faces\webapp\http\servlet\UploadServlet.java
        Ken Fyten made changes -
        Fix Version/s 1.6 [ 10031 ]
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Assignee Mark Collette [ mark.collette ]

          People

          • Assignee:
            Unassigned
            Reporter:
            Mark Collette
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: