ICEfaces
  1. ICEfaces
  2. ICE-1445

RowSelector Events in wrong Phase

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.5.3, 1.6DR#1, 1.6DR#2
    • Fix Version/s: 1.7.1
    • Component/s: ICE-Components
    • Labels:
      None
    • Environment:
      Any

      Description

      The select event of the RowSelector component is explicitly fired in the RowSelectorRenderer during the APPLY_REQUEST_VALUES phase (see code below). This means that during the UPDATE_MODEL_VALUES phase all backing bean changes made by the select listener will be overwritten.

      Code:
       if (rowSelector.getSelectionListener() != null) {
                           RowSelectorEvent evt = new RowSelectorEvent(rowSelector, rowIndex, b);
                           evt.setPhaseId(PhaseId.APPLY_REQUEST_VALUES);
       
                           rowSelector.queueEvent(evt);
       }
       

      The event should better by fired in the INVOKE_APPLICATION phase e.g.

      Code:
       if (rowSelector.getSelectionListener() != null) {
                           RowSelectorEvent evt = new RowSelectorEvent(rowSelector, rowIndex, b);
                           evt.setPhaseId(PhaseId.APPLY_REQUEST_VALUES);
       
                           rowSelector.queueEvent(evt);
       }

      A similar issue applies to the ValueChangeEvent fired by the SelectInputText component. For some reasons the event is fired in the PROCESS_VALIDATIONS phase witch leads to the same problem as described above. Changes made at the backing bean will be overwritten in the UPDATE_MODEL_VALUES phase.

        Issue Links

          Activity

          Repository Revision Date User Message
          ICEsoft Public SVN Repository #16883 Thu Jun 12 20:34:06 MDT 2008 mark.collette ICE-1445 : RowSelector Events in wrong Phase
          Files Changed
          Commit graph MODIFY /icefaces/branches/icefaces-1.7/icefaces/component/src/com/icesoft/faces/component/ext/RowSelector.java
          Commit graph MODIFY /icefaces/branches/icefaces-1.7/icefaces/component-metadata/src/main/resources/conf/ice_cust_properties/cust-rowselector-props.xml
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #16882 Thu Jun 12 20:33:07 MDT 2008 mark.collette ICE-1445 : RowSelector Events in wrong Phase
          Files Changed
          Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/ext/RowSelector.java
          Commit graph MODIFY /icefaces/trunk/icefaces/component-metadata/src/main/resources/conf/ice_cust_properties/cust-rowselector-props.xml

            People

            • Assignee:
              Unassigned
              Reporter:
              Grün Ling
            • Votes:
              2 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: