ICEfaces
  1. ICEfaces
  2. ICE-1442

Make rowSelector auto-row selection configurable

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.5.3
    • Fix Version/s: 1.6DR#4, 1.6
    • Component/s: ICE-Components
    • Labels:
      None
    • Environment:
      All

      Description

      The current rowSelector implementation automatically selects a dataTable row when you click anywhere within the row. While this works well most of the time, there are use-cases where the automatic selection behavior is not desirable. For example, in the case where you have a checkbox or a selectOneRadio component in the row and you click the component to change its' selection state, instead you get the row being selected/deselected instead, which is not the intended result.

      In these cases it is not good UI design to have the dataTable row be automatically selected by clicking over it in locations other than over specific components that need to interpret the clicking action themselves as this approach provides no obvious affordance for toggling the row selection state. You must be able to either click anywhere within the row to toggle the selection-state, or instead click a specific control within the row (usually at the right or left edge) to do so. For example, having a checkbox that is used to toggle the selected state.

      To resolve this issue the rowSelector should be enhanced to support the optional disabling of the automatic row selection feature and instead support programmatic selecting of dataTable rows based on another event. In the case of the example above, when the user toggles the value of the checkbox in the each row the row selection status would be programatically toggled in response by the application.

        Issue Links

          Activity

          Ken Fyten created issue -
          Ken Fyten made changes -
          Field Original Value New Value
          Summary Make rowSelector row selection event trigger configurable Make rowSelector auto-row selection configurable
          Fix Version/s 1.6DR#4 [ 10060 ]
          Assignee Priority P3
          Assignee Adnan Durrani [ adnan.durrani ]
          Ken Fyten made changes -
          Link This issue blocks ICE-1014 [ ICE-1014 ]
          Adnan Durrani made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          Hide
          Adnan Durrani added a comment -

          The following attribute added to the rowSelector component to turn the selection on and off. The default value of this attribute is being set to true. To turn the selection off, value of this attribute needs to be set to false.

          • toggleOnClick

          Tld and component doc has been updated. -revision 13658

          Show
          Adnan Durrani added a comment - The following attribute added to the rowSelector component to turn the selection on and off. The default value of this attribute is being set to true. To turn the selection off, value of this attribute needs to be set to false. toggleOnClick Tld and component doc has been updated. -revision 13658
          Adnan Durrani made changes -
          Status In Progress [ 3 ] Resolved [ 5 ]
          Affects [Documentation (User Guide, Ref. Guide, etc.)]
          Resolution Fixed [ 1 ]
          Ken Fyten made changes -
          Fix Version/s 1.6 [ 10031 ]
          Ken Fyten made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Assignee Priority P3
          Assignee Adnan Durrani [ adnan.durrani ]
          Michael Thiem made changes -
          Resolution Fixed [ 1 ]
          Status Closed [ 6 ] Reopened [ 4 ]
          Hide
          Michael Thiem added a comment -

          the behaviour of the rowSelector component is not yet as expected when setting the new attribute

          • toggleOnClick

          what happens is that the selected row is still highlighted. you don't have any chance to programmatically retrieve the
          selected column of the row you chose. there should be a way to retrieve the selected column out of the underlying
          data model which is not yet possible. also it still doesn't make any difference when selecting i.e. a checkbox or selectOneRadio
          component for changing the selection state. the selected row gets highlighted, no matter which column is selected.

          Show
          Michael Thiem added a comment - the behaviour of the rowSelector component is not yet as expected when setting the new attribute toggleOnClick what happens is that the selected row is still highlighted. you don't have any chance to programmatically retrieve the selected column of the row you chose. there should be a way to retrieve the selected column out of the underlying data model which is not yet possible. also it still doesn't make any difference when selecting i.e. a checkbox or selectOneRadio component for changing the selection state. the selected row gets highlighted, no matter which column is selected.
          Michael Thiem made changes -
          Michael Thiem made changes -
          Link This issue is duplicated by ICE-1939 [ ICE-1939 ]
          Michael Thiem made changes -
          Status Reopened [ 4 ] Closed [ 6 ]
          Resolution Fixed [ 1 ]
          Michael Thiem made changes -
          Resolution Fixed [ 1 ]
          Status Closed [ 6 ] Reopened [ 4 ]
          Michael Thiem made changes -
          Link This issue is duplicated by ICE-1939 [ ICE-1939 ]
          Hide
          Michael Thiem added a comment -

          follow-up issue case #: 1939

          Show
          Michael Thiem added a comment - follow-up issue case #: 1939
          Michael Thiem made changes -
          Status Reopened [ 4 ] Closed [ 6 ]
          Resolution Fixed [ 1 ]

            People

            • Assignee:
              Unassigned
              Reporter:
              Ken Fyten
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: