ICEfaces
  1. ICEfaces
  2. ICE-1414

The transparency of some theme images is incorrect.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.6
    • Fix Version/s: 1.6.2, 1.7DR#3, 1.7
    • Component/s: Framework
    • Labels:
      None
    • Environment:
      All

      Description

      A user sent in a couple of corrected images from our xp.css theme where the transparency was incorrectly set. This means that if the styled component is used on a non-white background, the component doesn't look right. The two images that were submitted with correct transparency were located under core/src/com/icesoft/faces/resources/css/xp/css-images/

      on-left-top.gif
      on-right-top.gif

      1. images.zip
        0.8 kB
        Deryk Sinotte

        Issue Links

          Activity

          Hide
          Deryk Sinotte added a comment -

          Attaching images from 1.5.3 source release showing the original images and the fixed versions.

          Show
          Deryk Sinotte added a comment - Attaching images from 1.5.3 source release showing the original images and the fixed versions.
          Hide
          Deryk Sinotte added a comment -

          I committed the fixed images to the 1.5 branch and the 1.6 trunk (revision 13478).

          Show
          Deryk Sinotte added a comment - I committed the fixed images to the 1.5 branch and the 1.6 trunk (revision 13478).
          Hide
          Deryk Sinotte added a comment -

          It might be prudent to check the rest of the xp images as well as the royale theme images for any that might have similar transparency issues.

          Show
          Deryk Sinotte added a comment - It might be prudent to check the rest of the xp images as well as the royale theme images for any that might have similar transparency issues.
          Hide
          Michael Thiem added a comment -

          this is the same issue as with:

          tree_nav_top_close_no_siblings.gif

          this image also needs a transparent layer.

          Show
          Michael Thiem added a comment - this is the same issue as with: tree_nav_top_close_no_siblings.gif this image also needs a transparent layer.
          Hide
          Ken Fyten added a comment -

          Fixed missing transparency on the following for 1.6.2:

          branches/icefaces-1.6/icefaces/core/src/com/icesoft/faces/resources/css/royale/css-images/tree_nav_bottom_close.gif
          /branches/icefaces-1.6/icefaces/core/src/com/icesoft/faces/resources/css/royale/css-images/tree_nav_bottom_open.gif
          /branches/icefaces-1.6/icefaces/core/src/com/icesoft/faces/resources/css/royale/css-images/tree_nav_middle_close.gif
          /branches/icefaces-1.6/icefaces/core/src/com/icesoft/faces/resources/css/royale/css-images/tree_nav_middle_open.gif
          /branches/icefaces-1.6/icefaces/core/src/com/icesoft/faces/resources/css/royale/css-images/tree_nav_top_close.gif
          /branches/icefaces-1.6/icefaces/core/src/com/icesoft/faces/resources/css/royale/css-images/tree_nav_top_close_no_siblings.gif
          /branches/icefaces-1.6/icefaces/core/src/com/icesoft/faces/resources/css/royale/css-images/tree_nav_top_closess.gif
          /branches/icefaces-1.6/icefaces/core/src/com/icesoft/faces/resources/css/royale/css-images/tree_nav_top_open.gif
          /branches/icefaces-1.6/icefaces/core/src/com/icesoft/faces/resources/css/royale/css-images/tree_nav_top_open_no_siblings.gif
          /branches/icefaces-1.6/icefaces/core/src/com/icesoft/faces/resources/css/xp/css-images/tree_nav_top_close_no_siblings.gif
          Committed revision 15117.

          ... and the icefaces trunk:

          /trunk/core/src/com/icesoft/faces/resources/css/royale/css-images/tree_nav_bottom_close.gif
          /trunk/core/src/com/icesoft/faces/resources/css/royale/css-images/tree_nav_bottom_open.gif
          /trunk/core/src/com/icesoft/faces/resources/css/royale/css-images/tree_nav_middle_close.gif
          /trunk/core/src/com/icesoft/faces/resources/css/royale/css-images/tree_nav_middle_open.gif
          /trunk/core/src/com/icesoft/faces/resources/css/royale/css-images/tree_nav_top_close.gif
          /trunk/core/src/com/icesoft/faces/resources/css/royale/css-images/tree_nav_top_close_no_siblings.gif
          /trunk/core/src/com/icesoft/faces/resources/css/royale/css-images/tree_nav_top_closess.gif
          /trunk/core/src/com/icesoft/faces/resources/css/royale/css-images/tree_nav_top_open.gif
          /core/src/com/icesoft/faces/resources/css/royale/css-images/tree_nav_top_open_no_siblings.gif
          /core/src/com/icesoft/faces/resources/css/xp/css-images/tree_nav_top_close_no_siblings.gif
          Committed revision 15118.

          Show
          Ken Fyten added a comment - Fixed missing transparency on the following for 1.6.2: branches/icefaces-1.6/icefaces/core/src/com/icesoft/faces/resources/css/royale/css-images/tree_nav_bottom_close.gif /branches/icefaces-1.6/icefaces/core/src/com/icesoft/faces/resources/css/royale/css-images/tree_nav_bottom_open.gif /branches/icefaces-1.6/icefaces/core/src/com/icesoft/faces/resources/css/royale/css-images/tree_nav_middle_close.gif /branches/icefaces-1.6/icefaces/core/src/com/icesoft/faces/resources/css/royale/css-images/tree_nav_middle_open.gif /branches/icefaces-1.6/icefaces/core/src/com/icesoft/faces/resources/css/royale/css-images/tree_nav_top_close.gif /branches/icefaces-1.6/icefaces/core/src/com/icesoft/faces/resources/css/royale/css-images/tree_nav_top_close_no_siblings.gif /branches/icefaces-1.6/icefaces/core/src/com/icesoft/faces/resources/css/royale/css-images/tree_nav_top_closess.gif /branches/icefaces-1.6/icefaces/core/src/com/icesoft/faces/resources/css/royale/css-images/tree_nav_top_open.gif /branches/icefaces-1.6/icefaces/core/src/com/icesoft/faces/resources/css/royale/css-images/tree_nav_top_open_no_siblings.gif /branches/icefaces-1.6/icefaces/core/src/com/icesoft/faces/resources/css/xp/css-images/tree_nav_top_close_no_siblings.gif Committed revision 15117. ... and the icefaces trunk: /trunk/core/src/com/icesoft/faces/resources/css/royale/css-images/tree_nav_bottom_close.gif /trunk/core/src/com/icesoft/faces/resources/css/royale/css-images/tree_nav_bottom_open.gif /trunk/core/src/com/icesoft/faces/resources/css/royale/css-images/tree_nav_middle_close.gif /trunk/core/src/com/icesoft/faces/resources/css/royale/css-images/tree_nav_middle_open.gif /trunk/core/src/com/icesoft/faces/resources/css/royale/css-images/tree_nav_top_close.gif /trunk/core/src/com/icesoft/faces/resources/css/royale/css-images/tree_nav_top_close_no_siblings.gif /trunk/core/src/com/icesoft/faces/resources/css/royale/css-images/tree_nav_top_closess.gif /trunk/core/src/com/icesoft/faces/resources/css/royale/css-images/tree_nav_top_open.gif /core/src/com/icesoft/faces/resources/css/royale/css-images/tree_nav_top_open_no_siblings.gif /core/src/com/icesoft/faces/resources/css/xp/css-images/tree_nav_top_close_no_siblings.gif Committed revision 15118.
          Hide
          Ken Fyten added a comment -

          Fixed missing transparency on XP theme outputConnectionStatus images.

          ICEfaces trunk:

          /trunk/core/src/com/icesoft/faces/resources/css/xp/css-images/connect_caution.gif
          /trunk/core/src/com/icesoft/faces/resources/css/xp/css-images/connect_disconnected.gif
          /trunk/core/src/com/icesoft/faces/resources/css/xp/css-images/connect_idle.gif
          Committed revision 15119.

          ICEfaces 1.6 branch:

          /branches/icefaces-1.6/icefaces/core/src/com/icesoft/faces/resources/css/xp/css-images/connect_caution.gif
          /branches/icefaces-1.6/icefaces/core/src/com/icesoft/faces/resources/css/xp/css-images/connect_disconnected.gif
          /branches/icefaces-1.6/icefaces/core/src/com/icesoft/faces/resources/css/xp/css-images/connect_idle.gif
          Committed revision 15120.

          Show
          Ken Fyten added a comment - Fixed missing transparency on XP theme outputConnectionStatus images. ICEfaces trunk: /trunk/core/src/com/icesoft/faces/resources/css/xp/css-images/connect_caution.gif /trunk/core/src/com/icesoft/faces/resources/css/xp/css-images/connect_disconnected.gif /trunk/core/src/com/icesoft/faces/resources/css/xp/css-images/connect_idle.gif Committed revision 15119. ICEfaces 1.6 branch: /branches/icefaces-1.6/icefaces/core/src/com/icesoft/faces/resources/css/xp/css-images/connect_caution.gif /branches/icefaces-1.6/icefaces/core/src/com/icesoft/faces/resources/css/xp/css-images/connect_disconnected.gif /branches/icefaces-1.6/icefaces/core/src/com/icesoft/faces/resources/css/xp/css-images/connect_idle.gif Committed revision 15120.
          Hide
          Ken Fyten added a comment -

          Follow-up JIRA for a remaining issue: http://jira.icefaces.org/browse/ICE-2344

          Show
          Ken Fyten added a comment - Follow-up JIRA for a remaining issue: http://jira.icefaces.org/browse/ICE-2344
          Hide
          Christophe Taverne added a comment -

          Hi,

          I don't know if it has been solved, but please, don't forget to fix the following files:

          arrow-first.gif
          arrow-fr.gif
          arrow-previous.gif
          arrow-next.gif
          arrow-ff.gif
          arrow-last.gif

          trom dataTable paginator component.

          Many thanks

          regards,

          Show
          Christophe Taverne added a comment - Hi, I don't know if it has been solved, but please, don't forget to fix the following files: arrow-first.gif arrow-fr.gif arrow-previous.gif arrow-next.gif arrow-ff.gif arrow-last.gif trom dataTable paginator component. Many thanks regards,
          Hide
          Ken Fyten added a comment -

          The arrow-first.gif, etc. for the Royale theme still require transparent backgrounds. XP is okay.

          Show
          Ken Fyten added a comment - The arrow-first.gif, etc. for the Royale theme still require transparent backgrounds. XP is okay.
          Hide
          Ken Fyten added a comment -

          Improved the contrast of disabled-state button images for Royale theme.

          Show
          Ken Fyten added a comment - Improved the contrast of disabled-state button images for Royale theme.
          Hide
          Ken Fyten added a comment -

          A few more issues need to be addressed with the last image set:

          1. Fix the coloring for arrow-last-dis.gif
          2. Swap the names for arrow-ff-dis.gif and arrow-rw-dis.gif, they are reversed.
          3. Fix the centering of the arrows relative to the border for arrow-ff-dis.gif. Should basically be a mirror of arrow-rw.dis.gif.

          Show
          Ken Fyten added a comment - A few more issues need to be addressed with the last image set: 1. Fix the coloring for arrow-last-dis.gif 2. Swap the names for arrow-ff-dis.gif and arrow-rw-dis.gif, they are reversed. 3. Fix the centering of the arrows relative to the border for arrow-ff-dis.gif. Should basically be a mirror of arrow-rw.dis.gif.
          Hide
          Ken Fyten added a comment -

          Fixed.

          Show
          Ken Fyten added a comment - Fixed.

            People

            • Assignee:
              Unassigned
              Reporter:
              Deryk Sinotte
            • Votes:
              1 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: