Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Major
-
Resolution: Duplicate
-
Affects Version/s: 1.5.3
-
Fix Version/s: 1.8.1
-
Component/s: ICE-Components
-
Labels:None
-
Environment:any
-
Support Case References:
Description
Issue Links
- duplicates
-
ICE-2018
tree: partialSubmit in nested inputText components causes strange behaviour
-
- Closed
-
Activity
- All
- Comments
- History
- Activity
- Remote Attachments
- Subversion
Looks legitimate.
This bug can be fixed if add setCurrentVarToRequestMap(getFacesContext(), eventNode); code in broadcast method as follows:
public void broadcast(FacesEvent event) throws AbortProcessingException {
if (!(event instanceof NodeEvent))
{ super.broadcast(event); return; } // Set up the correct context and fire our wrapped event
NodeEvent wrapperEvent = (NodeEvent) event;
DefaultMutableTreeNode eventNode = wrapperEvent.getNode();
this.setCurrentNode(eventNode);
this.setNodePath(TreeRenderer.getPathAsString(eventNode,
(DefaultMutableTreeNode) getModel()
.getRoot()));
//fix ICE-1409 bug
setCurrentVarToRequestMap(getFacesContext(), eventNode);
FacesEvent facesEvent = wrapperEvent.getFacesEvent();
facesEvent.getComponent().broadcast(facesEvent);
}
According to Adnan, who said that he looked into how the stock JSF component handle this, they queue the events as well, and so would not have access to the source UIComponent while it's still setup as with the proper clientId and submittedValue.
Ignore the last comment - it was for ICE-1745.
In the tree page of the component-showcase, I added some debug to an the ice:tree's ice:treeNode's icon facet's ice:commandLink's actionListener. From there I found that:
- The tree's navigatedNode is correctly set to the last node that was expanded or collapsed.
- The tree's navigatedNode is accessible when expanding/collapsing or when clicking on other nodes.
- The tree's currentNode is correctly set to the current node being clicked on.
- The tree's currentNode is null when expanding/collapsing.
- The tree's nodePath is correctly set to the current node being clicked on.
- The tree's nodePath is null when expanding/collapsing.
But there is one thing not correct:
- If you get the UIComponent source of the ActionEvent, and check its clientId, then that's set to the last node's clientId. So we're probably queuing the ActionEvents to come in without setting that up properly. This for for both expanding/collapsing and node clicking actionEvents.
When I tried to reproduce this issue, I could not. The code looked like it was already covering this scenario. When I investigated the svn history of the code, I found that it had been fixed by
ICE-2018.