Details
Bug
Major
Description
Icefaces renderer appears to append a newline character after </input> element resulting in gaps between commandButtons rendered next to each other. Not entirely sure where this happens but suspecting DOMUtils.printNode method.
Check out screens (before and after generated source was manually-edited to remove the newline). also attaching sample xhtml file and button image
Check out screens (before and after generated source was manually-edited to remove the newline). also attaching sample xhtml file and button image
-
-
Hide
-
-
META-INF/MANIFEST.MF
-
buttons.xhtml
-
IceEval/nav_Home.gif
-
welcome.jspx
-
WEB-INF/faces-config.xml
-
WEB-INF/web.xml
-
WEB-INF/lib/backport-util-concurrent.jar
-
WEB-INF/lib/commons-beanutils.jar
-
WEB-INF/lib/commons-collections.jar
-
WEB-INF/lib/commons-digester.jar
-
WEB-INF/lib/commons-discovery.jar
-
WEB-INF/lib/commons-el.jar
-
WEB-INF/lib/commons-fileupload.jar
-
WEB-INF/lib/commons-logging.jar
-
WEB-INF/lib/el-api.jar
-
WEB-INF/lib/el-ri.jar
-
WEB-INF/lib/icefaces-comps.jar
-
WEB-INF/lib/icefaces-facelets.jar
-
WEB-INF/lib/icefaces.jar
-
WEB-INF/lib/jsf-api.jar
-
WEB-INF/lib/jsf-impl.jar
-
WEB-INF/lib/jstl.jar
-
WEB-INF/lib/portlet.jar
-
WEB-INF/lib/xercesImpl.jar
-
WEB-INF/lib/xml-apis.jar
-
-
Activity
| Field | Original Value | New Value |
|---|---|---|
| Attachment | page as generated - note gap between buttons, newline in source.jpg [ 10331 ] |
| Attachment | newline removed from generated source (by hand) - gap gone.jpg [ 10332 ] |
 - gap gone.jpg){kind=link}
| Attachment | nav_Home.gif [ 10333 ] |
| Attachment | buttons.xhtml [ 10334 ] |
Seems like the root maybe here (DOMUtils):
if (children != null) {
int childrenLength = children.getLength();
for (int i = 0; i < childrenLength; i++) {
boolean childAddTrailingNewline = false;
if (allowAddingWhitespace) {
if ((i + 1) < childrenLength) {
Node nextChild = children.item(i + 1);
// We don't add the newline if the next tag is a TD,
// because when rendering our tabbedPane, if there's
// any whitespace between the adjacent TDs, then
// Internet Explorer will add vertical spacing
childAddTrailingNewline =
!isWhitespaceText(nextChild) &&
!isTD(nextChild);
}
}
printNode(children.item(i), stringbuffer, depth + 1,
allowAddingWhitespace,
childAddTrailingNewline);
}
}
When ice:form is being rendered, after rendering the first child (button1), childAddTrailingNewline is evaluated to true before button2 is rendered.
Is this needed for pretty-printing?
Show
dukehoops
added a comment - Seems like the root maybe here (DOMUtils):
if (children != null) {
int childrenLength = children.getLength();
for (int i = 0; i < childrenLength; i++) {
boolean childAddTrailingNewline = false;
if (allowAddingWhitespace) {
if ((i + 1) < childrenLength) {
Node nextChild = children.item(i + 1);
// We don't add the newline if the next tag is a TD,
// because when rendering our tabbedPane, if there's
// any whitespace between the adjacent TDs, then
// Internet Explorer will add vertical spacing
childAddTrailingNewline =
!isWhitespaceText(nextChild) &&
!isTD(nextChild);
}
}
printNode(children.item(i), stringbuffer, depth + 1,
allowAddingWhitespace,
childAddTrailingNewline);
}
}
When ice:form is being rendered, after rendering the first child (button1), childAddTrailingNewline is evaluated to true before button2 is rendered.
Is this needed for pretty-printing?
this is worked around by wrapping buttons in a table with 0 cellpadding, cellspacing:
<ice:panelGrid columns="2" cellspacing="0" cellpadding="0"/>
| Support Case References | https://www.icesoft.ca:4443/supportilla/show_bug.cgi?id=3982 | |
| Support Customer Ref. #s | 703 |
| Assignee | Philip Breau [ philip.breau ] |
| Assignee | Philip Breau [ philip.breau ] | Adnan Durrani [ adnan.durrani ] |
| Fix Version/s | 1.6.1 [ 10070 ] |
| Assignee | Adnan Durrani [ adnan.durrani ] | Yip Ng [ yip.ng ] |
| Assignee Priority | P1 |
| Repository | Revision | Date | User | Message |
| ICEsoft Public SVN Repository | #14652 | Tue Aug 14 13:03:46 MDT 2007 | yip.ng | Added code to not emit newline after <input> field, to avoid an extra space. |
| Files Changed | ||||
MODIFY
/icefaces/trunk/icefaces/core/src/com/icesoft/faces/util/DOMUtils.java
|
Test webapp.
Note: before running the webapp, add the relevant jars to the WEB-INF/lib dir, including icefaces.jar, where the code change will be compiled into.
Fixed by adding code to not emit the newline. Test webapp attached.
| Status | Open [ 1 ] | Resolved [ 5 ] |
| Resolution | Fixed [ 1 ] |
The following posting says that if there is a new line character between two img elements, the browsers renders a space between them.
Show
Adnan Durrani
added a comment - The following posting says that if there is a new line character between two img elements, the browsers renders a space between them.
http://www.icefaces.org/JForum/posts/list/5397.page
| Resolution | Fixed [ 1 ] | |
| Status | Resolved [ 5 ] | Reopened [ 4 ] |
| Repository | Revision | Date | User | Message |
| ICEsoft Public SVN Repository | #14691 | Mon Aug 20 17:32:31 MDT 2007 | yip.ng | Added <img> to list of tags not allowed to output newline. Merged and re-factored methods checking tag types and names. |
| Files Changed | ||||
|
MODIFY
/icefaces/trunk/icefaces/core/src/com/icesoft/faces/util/DOMUtils.java
|
| Attachment | ICE-1351.war [ 10622 ] |
Included <img> tag in the list of tags not to output newline.
Also merged and re-factored methods checking node types and node names.
| Status | Reopened [ 4 ] | Resolved [ 5 ] |
| Resolution | Fixed [ 1 ] |
| Status | Resolved [ 5 ] | Closed [ 6 ] |
| Assignee Priority | P1 | |
| Assignee | Yip Ng [ yip.ng ] |
before and after screens added
-nikita