ICEfaces
  1. ICEfaces
  2. ICE-1351

newline emitted after </input>

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 1.5.3
          • Fix Version/s: 1.6.1
          • Component/s: Framework
          • Labels:
            None
          • Environment:
            firefox 2.0/winxp, facelets

            Description

            Icefaces renderer appears to append a newline character after </input> element resulting in gaps between commandButtons rendered next to each other. Not entirely sure where this happens but suspecting DOMUtils.printNode method.

            Check out screens (before and after generated source was manually-edited to remove the newline). also attaching sample xhtml file and button image
            1. File
              buttons.xhtml
              1 kB
              dukehoops
            1. nav_Home.gif
              0.7 kB
            2. newline removed from generated source (by hand) - gap gone.jpg
              112 kB
            3. page as generated - note gap between buttons, newline in source.jpg
              128 kB

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              dukehoops added a comment -

              before and after screens added

              -nikita

              Show
              dukehoops added a comment - before and after screens added -nikita
              Hide
              Permalink
              dukehoops added a comment -

              image used in commandButton

              -nikita

              Show
              dukehoops added a comment - image used in commandButton -nikita
              Hide
              Permalink
              dukehoops added a comment -

              test case

              -nikita

              Show
              dukehoops added a comment - test case -nikita
              Hide
              Permalink
              dukehoops added a comment -

              Seems like the root maybe here (DOMUtils):

                            if (children != null) {
                    int childrenLength = children.getLength();
                    for (int i = 0; i < childrenLength; i++) {
                        boolean childAddTrailingNewline = false;
                        if (allowAddingWhitespace) {
                            if ((i + 1) < childrenLength) {
                                Node nextChild = children.item(i + 1);
                                // We don't add the newline if the next tag is a TD,
                                // because when rendering our tabbedPane, if there's
                                // any whitespace between the adjacent TDs, then
                                // Internet Explorer will add vertical spacing
                                childAddTrailingNewline =
                                        !isWhitespaceText(nextChild) &&
                                        !isTD(nextChild);
                            }
                        }
                        printNode(children.item(i), stringbuffer, depth + 1,
                                  allowAddingWhitespace,
                                  childAddTrailingNewline);
                    }
                }

              When ice:form is being rendered, after rendering the first child (button1), childAddTrailingNewline is evaluated to true before button2 is rendered.

              Is this needed for pretty-printing?

              Show
              dukehoops added a comment - Seems like the root maybe here (DOMUtils): if (children != null) { int childrenLength = children.getLength(); for (int i = 0; i < childrenLength; i++) { boolean childAddTrailingNewline = false; if (allowAddingWhitespace) { if ((i + 1) < childrenLength) { Node nextChild = children.item(i + 1); // We don't add the newline if the next tag is a TD, // because when rendering our tabbedPane, if there's // any whitespace between the adjacent TDs, then // Internet Explorer will add vertical spacing childAddTrailingNewline = !isWhitespaceText(nextChild) && !isTD(nextChild); } } printNode(children.item(i), stringbuffer, depth + 1, allowAddingWhitespace, childAddTrailingNewline); } } When ice:form is being rendered, after rendering the first child (button1), childAddTrailingNewline is evaluated to true before button2 is rendered. Is this needed for pretty-printing?
              Hide
              Permalink
              dukehoops added a comment -

              this is worked around by wrapping buttons in a table with 0 cellpadding, cellspacing:

              <ice:panelGrid columns="2" cellspacing="0" cellpadding="0"/>

              Show
              dukehoops added a comment - this is worked around by wrapping buttons in a table with 0 cellpadding, cellspacing: <ice:panelGrid columns="2" cellspacing="0" cellpadding="0"/>
              Hide
              Permalink
              yip.ng added a comment -

              Code added to not emit the newline.

              Show
              yip.ng added a comment - Code added to not emit the newline.
              Hide
              Permalink
              yip.ng added a comment -

              Test webapp.

              Note: before running the webapp, add the relevant jars to the WEB-INF/lib dir, including icefaces.jar, where the code change will be compiled into.

              Show
              yip.ng added a comment - Test webapp. Note: before running the webapp, add the relevant jars to the WEB-INF/lib dir, including icefaces.jar, where the code change will be compiled into.
              Hide
              Permalink
              yip.ng added a comment -

              Fixed by adding code to not emit the newline. Test webapp attached.

              Show
              yip.ng added a comment - Fixed by adding code to not emit the newline. Test webapp attached.
              Hide
              Permalink
              Adnan Durrani added a comment -

              The following posting says that if there is a new line character between two img elements, the browsers renders a space between them.

              http://www.icefaces.org/JForum/posts/list/5397.page

              Show
              Adnan Durrani added a comment - The following posting says that if there is a new line character between two img elements, the browsers renders a space between them. http://www.icefaces.org/JForum/posts/list/5397.page
              Hide
              Permalink
              yip.ng added a comment -

              Updated test web app. with testing of <img> tag included.

              Show
              yip.ng added a comment - Updated test web app. with testing of <img> tag included.
              Hide
              Permalink
              yip.ng added a comment -

              Included <img> tag in the list of tags not to output newline.
              Also merged and re-factored methods checking node types and node names.

              Show
              yip.ng added a comment - Included <img> tag in the list of tags not to output newline. Also merged and re-factored methods checking node types and node names.

                People

                • Assignee:
                  Unassigned
                  Reporter:
                  dukehoops
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  1 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: