ICEfaces
  1. ICEfaces
  2. ICE-1291

Component Showcase: Add accordion sample

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.6
    • Fix Version/s: 1.6DR#4, 1.6
    • Component/s: Sample Apps
    • Labels:
      None
    • Environment:
      All
    • Affects:
      Sample App./Tutorial

      Description

      Add a Accordion panel example to Component showcase

        Activity

        Rob Mayhew created issue -
        Ken Fyten made changes -
        Field Original Value New Value
        Fix Version/s 1.6 [ 10031 ]
        Assignee Priority P2
        Assignee Ken Fyten [ ken.fyten ] Patrick Corless [ patrick.corless ]
        Hide
        Ken Fyten added a comment -

        Initial version has been added. Needs to be reviewed and revised as required.

        Show
        Ken Fyten added a comment - Initial version has been added. Needs to be reviewed and revised as required.
        Patrick Corless made changes -
        Assignee Patrick Corless [ patrick.corless ] Darren Northcott [ darren.northcott ]
        Hide
        Patrick Corless added a comment -

        Darren, please update the status of this bug.

        Show
        Patrick Corless added a comment - Darren, please update the status of this bug.
        Ken Fyten made changes -
        Fix Version/s 1.6DR#4 [ 10060 ]
        Fix Version/s 1.6 [ 10031 ]
        Hide
        Ted Goddard added a comment -

        This would appear to be resolved; DR#3 contains an accordion sample.

        Show
        Ted Goddard added a comment - This would appear to be resolved; DR#3 contains an accordion sample.
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #13599 Thu Apr 19 12:56:29 MDT 2007 patrick.corless ICE-1291 - code format changes, not functional changes.
        Files Changed
        Commit graph MODIFY /icefaces/trunk/icefaces/samples/component-showcase/src/com/icesoft/icefaces/samples/showcase/layoutPanels/accordionPanel/AccordionBean.java
        Commit graph MODIFY /icefaces/trunk/icefaces/samples/component-showcase/web/inc/mainTemplate.jspx
        Commit graph MODIFY /icefaces/trunk/icefaces/samples/component-showcase/src/com/icesoft/icefaces/samples/showcase/components/textEntry/TextFieldsBean.java
        Commit graph MODIFY /icefaces/trunk/icefaces/samples/component-showcase/src/com/icesoft/icefaces/samples/showcase/layoutPanels/accordionPanel/AccordionItem.java
        Commit graph MODIFY /icefaces/trunk/icefaces/samples/component-showcase/web/inc/layoutPanels/accordionPanel.jspx
        Hide
        Darren Northcott added a comment -

        DR3 contains the accordion example

        Show
        Darren Northcott added a comment - DR3 contains the accordion example
        Darren Northcott made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Patrick Corless added a comment -

        For the beta of 1.6 we pulled the embedded tabset example as it shown a state issue with the accordion component. This example

        This demo is fine for the beta release but I would like to see the following changes made before the final release of 1.6.

        • move all text into the resource bundles
        • add javadoc to the accordion bean, especially the class definition.
        • separate the two examples into two separate beans.
        • Consolidate the faces version and the plain jsf version into one file as this is a maintenance issues with the current implementation. This can only be done by inlining the html includes.
        Show
        Patrick Corless added a comment - For the beta of 1.6 we pulled the embedded tabset example as it shown a state issue with the accordion component. This example This demo is fine for the beta release but I would like to see the following changes made before the final release of 1.6. move all text into the resource bundles add javadoc to the accordion bean, especially the class definition. separate the two examples into two separate beans. Consolidate the faces version and the plain jsf version into one file as this is a maintenance issues with the current implementation. This can only be done by inlining the html includes.
        Patrick Corless made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Patrick Corless made changes -
        Affects [Sample App./Tutorial]
        Priority Major [ 3 ] Minor [ 4 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #13777 Thu May 03 16:14:18 MDT 2007 darren.northcott ICE-1291 accordion panel inlining of html
        Files Changed
        Commit graph MODIFY /icefaces/trunk/icefaces/samples/component-showcase/src/com/icesoft/icefaces/samples/showcase/layoutPanels/accordionPanel/AccordionBean.java
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #13796 Thu May 03 19:52:00 MDT 2007 patrick.corless ICE-1291 added expaned=true for fruits accordion panel in JSF implementation.
        Files Changed
        Commit graph MODIFY /icefaces/trunk/icefaces/samples/component-showcase/web/inc/layoutPanels/accordionPanel.jspx
        Ken Fyten made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Ken Fyten made changes -
        Fix Version/s 1.6 [ 10031 ]
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Assignee Priority P2
        Assignee Darren Northcott [ darren.northcott ]

          People

          • Assignee:
            Unassigned
            Reporter:
            Rob Mayhew
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: