ICEfaces
  1. ICEfaces
  2. ICE-1247

UIInput.requestFocus() not working in IE 6 & 7 when moving from unrendered to rendered

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 1.5.2
    • Fix Version/s: 1.6DR#4, 1.6
    • Component/s: ICE-Components
    • Labels:
      None
    • Environment:
      Operating System: Windows XP
      Platform: PC

      Description

      calling requestFocus() on a SelectInputText component doesn't seem to work in IE
      6 or 7. Tested with 1.5.3

        Activity

        Philip Breau created issue -
        Hide
        Rob Mayhew added a comment -

        I ran a test with the following call and it works on IE7.
        Using 1.5.3 build.

        public String focusInputTextUserRequestFocus()

        { ((SelectInputText)inputText).requestFocus(); return null; }
        Show
        Rob Mayhew added a comment - I ran a test with the following call and it works on IE7. Using 1.5.3 build. public String focusInputTextUserRequestFocus() { ((SelectInputText)inputText).requestFocus(); return null; }
        Icefaces Administrator made changes -
        Field Original Value New Value
        issue.field.bugzillaimportkey 1319 12516
        Ken Fyten made changes -
        Priority Major [ 3 ] Critical [ 2 ]
        Ken Fyten made changes -
        Assignee Rob Mayhew [ rob.mayhew ]
        Hide
        Ken Fyten added a comment -

        If you can reproduce this, please re-open.

        Show
        Ken Fyten added a comment - If you can reproduce this, please re-open.
        Ken Fyten made changes -
        Status Open [ 1 ] Closed [ 6 ]
        Resolution Cannot Reproduce [ 5 ]
        Hide
        Philip Breau added a comment -

        doesn't work in IE6

        Show
        Philip Breau added a comment - doesn't work in IE6
        Philip Breau made changes -
        Resolution Cannot Reproduce [ 5 ]
        Status Closed [ 6 ] Reopened [ 4 ]
        Ken Fyten made changes -
        Fix Version/s 1.6DR#3 [ 10050 ]
        Assignee Priority P2
        Assignee Carlo Gug [ carlo.guglielmin ]
        Hide
        Carlo Guglielmin added a comment -

        I tested Address Demo, which uses a requestFocus() call on the combo box for State when an ambiguous city name is entered. To duplicate the test, enter 'Ashville' for the city, and click to the first name field. The State input will change to a dropdown and focus will be shifted to that.

        I tested 1.5.3, 1.6.0DR2, and the head of the repo, and the focus switched fine in both IE6 and Firefox.

        Show
        Carlo Guglielmin added a comment - I tested Address Demo, which uses a requestFocus() call on the combo box for State when an ambiguous city name is entered. To duplicate the test, enter 'Ashville' for the city, and click to the first name field. The State input will change to a dropdown and focus will be shifted to that. I tested 1.5.3, 1.6.0DR2, and the head of the repo, and the focus switched fine in both IE6 and Firefox.
        Hide
        Ken Fyten added a comment -

        Using the Address demo on IE7 with 1.5.3 and 1.6 DR#2 fails.

        Show
        Ken Fyten added a comment - Using the Address demo on IE7 with 1.5.3 and 1.6 DR#2 fails.
        Ken Fyten made changes -
        Summary SelectInputText.requestFocus() not working in IE 6 SelectInputText.requestFocus() not working in IE
        Assignee Priority P2 P1
        Assignee Carlo Gug [ carlo.guglielmin ] Rob Mayhew [ rob.mayhew ]
        Hide
        Rob Mayhew added a comment -

        This works in head IE6, FF2, IE7.

        Show
        Rob Mayhew added a comment - This works in head IE6, FF2, IE7.
        Rob Mayhew made changes -
        Status Reopened [ 4 ] Closed [ 6 ]
        Resolution Cannot Reproduce [ 5 ]
        Hide
        dukehoops added a comment -
        Show
        dukehoops added a comment - try ICE-1371
        Hide
        Philip Breau added a comment -

        the failure to apply focus is only reproducible when the component is moving from an unrendered to a rendered state on the same lifecycle pass

        Show
        Philip Breau added a comment - the failure to apply focus is only reproducible when the component is moving from an unrendered to a rendered state on the same lifecycle pass
        Philip Breau made changes -
        Resolution Cannot Reproduce [ 5 ]
        Status Closed [ 6 ] Reopened [ 4 ]
        Hide
        Philip Breau added a comment -

        1. open /support-3882/
        2. click 'focus input'

        • when being rendered on the same pass, the focus isn't applied
          3. click 'toggle hide input' so that the input is in the rendered state
          4. click 'focus input'
        • the input will now focus
        Show
        Philip Breau added a comment - 1. open /support-3882/ 2. click 'focus input' when being rendered on the same pass, the focus isn't applied 3. click 'toggle hide input' so that the input is in the rendered state 4. click 'focus input' the input will now focus
        Philip Breau made changes -
        Attachment Supportilla-3882.zip [ 10367 ]
        Philip Breau made changes -
        Summary SelectInputText.requestFocus() not working in IE UIInput.requestFocus() not working in IE 7 when moving from unrendered to rendered
        Philip Breau made changes -
        Summary UIInput.requestFocus() not working in IE 7 when moving from unrendered to rendered UIInput.requestFocus() not working in IE 6 & 7 when moving from unrendered to rendered
        Ken Fyten made changes -
        Fix Version/s 1.6 [ 10031 ]
        Fix Version/s 1.6DR#3 [ 10050 ]
        Assignee Priority P1 P2
        Ken Fyten made changes -
        Fix Version/s 1.6DR#4 [ 10060 ]
        Fix Version/s 1.6 [ 10031 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #13596 Thu Apr 19 11:03:55 MDT 2007 rob.mayhew Fix for ICE-1247. A short delay is required on IE.
        Files Changed
        Commit graph MODIFY /icefaces/trunk/icefaces/bridge/src/focus.js
        Hide
        Rob Mayhew added a comment -

        I had to add a slight delay to the focus call (100ms). IE 6 and 7 now focus properly.

        r13596

        Show
        Rob Mayhew added a comment - I had to add a slight delay to the focus call (100ms). IE 6 and 7 now focus properly. r13596
        Rob Mayhew made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Ted Goddard added a comment -

        A short delay prior to setting focus is unlikely to have any undesirable side effects (outside of focus behavior) as the delay wouldn't block anything else from occurring.

        However, the delay may mean that there is a period of time where nothing is focused, yet the user is expecting some component to be focused. We should take care to ensure that rapid focus operations on the part of the user aren't interfered with by setting the focus later.

        Show
        Ted Goddard added a comment - A short delay prior to setting focus is unlikely to have any undesirable side effects (outside of focus behavior) as the delay wouldn't block anything else from occurring. However, the delay may mean that there is a period of time where nothing is focused, yet the user is expecting some component to be focused. We should take care to ensure that rapid focus operations on the part of the user aren't interfered with by setting the focus later.
        Hide
        Rob Mayhew added a comment -

        In the case where a user changes focus before the server focus call is executed, the server focus call is ignored. Focus is only moved if the user is not interacting with the browser. (Keypress, or mouse click)

        Show
        Rob Mayhew added a comment - In the case where a user changes focus before the server focus call is executed, the server focus call is ignored. Focus is only moved if the user is not interacting with the browser. (Keypress, or mouse click)
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #13650 Thu Apr 26 13:18:17 MDT 2007 rob.mayhew Moved patch from head to 1.5 branch. ICE-1247
        Files Changed
        Commit graph MODIFY /icefaces/branches/icefaces-1.5/icefaces/bridge/src/focus.js
        Rob Mayhew made changes -
        Fix Version/s 1.5.4 [ 10034 ]
        Hide
        Rob Mayhew added a comment -

        Added fix to 1.5 branch. r13650

        Show
        Rob Mayhew added a comment - Added fix to 1.5 branch. r13650
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #13657 Thu Apr 26 15:42:14 MDT 2007 rob.mayhew Partial Fix for ICE-1247. Added titles to generated frames.
        Files Changed
        Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/inputfile/InputFileRenderer.java
        Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/context/DOMResponseWriter.java
        Commit graph MODIFY /icefaces/trunk/icefaces/bridge/lib/extras/style.js
        Commit graph MODIFY /icefaces/trunk/icefaces/bridge/lib/extras/autocomplete_ext.js
        Ken Fyten made changes -
        Fix Version/s 1.6 [ 10031 ]
        Fix Version/s 1.5.4 [ 10034 ]
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Assignee Priority P2
        Assignee Rob Mayhew [ rob.mayhew ]

          People

          • Assignee:
            Unassigned
            Reporter:
            Philip Breau
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: