ICEfaces
  1. ICEfaces
  2. ICE-1227

<f:loadBundle> gets cleaned up when using standardRequestScope="true"

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.5.2
    • Fix Version/s: 1.6DR#3, 1.6
    • Component/s: ICE-Components
    • Labels:
      None
    • Environment:
      Operating System: Windows XP
      Platform: PC

      Description

      One of the side effects of using standardRequestScope (ICE-1093) is that
      message bundles aren't reloaded after a partialSubmit and are cleared from the
      request map. We need a new <ice:loadBundle> component that works with
      standardRequestScope

        Activity

        Hide
        Ted Goddard added a comment -

        Yes, please use ice:loadBundle. f:loadBundle is implemented as a JSP tag rather than a JSF component, so it does not function well in all cases.

        Show
        Ted Goddard added a comment - Yes, please use ice:loadBundle. f:loadBundle is implemented as a JSP tag rather than a JSF component, so it does not function well in all cases.
        Hide
        Pankaj Singh added a comment -

        The above comment is not completely right. I just checked and found it to be working with <ice:loadbundle>. <f:loadbundle> does not work.

        Show
        Pankaj Singh added a comment - The above comment is not completely right. I just checked and found it to be working with <ice:loadbundle>. <f:loadbundle> does not work.
        Hide
        Pankaj Singh added a comment -

        This fix is not working. I have tested this issue in release 1.7.2 and 1.8
        For spring web flow integration I need standardrequestscope to be true.But now on partialsubmits or page refreshes message bundles are not loaded.

        Show
        Pankaj Singh added a comment - This fix is not working. I have tested this issue in release 1.7.2 and 1.8 For spring web flow integration I need standardrequestscope to be true.But now on partialsubmits or page refreshes message bundles are not loaded.
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Assignee Priority P1
        Assignee Adnan Durrani [ adnan.durrani ]
        Ken Fyten made changes -
        Fix Version/s 1.6 [ 10031 ]
        Ken Fyten made changes -
        Summary <ice:loadBundle> gets clean up when using standardRequestScope="ture" <f:loadBundle> gets cleaned up when using standardRequestScope="true"
        Adnan Durrani made changes -
        Summary need new <ice:loadBundle> component <ice:loadBundle> gets clean up when using standardRequestScope="ture"
        Adnan Durrani made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Fix Version/s 1.6DR#3 [ 10050 ]
        Fix Version/s 1.6 [ 10031 ]
        Resolution Fixed [ 1 ]
        Hide
        Adnan Durrani added a comment -

        Support of standardRequestScope has been reimplemented to the ICEfaces. I have retested the f:loadBundle with and without standardRequestScope set to true and it came across that the problem already has fixed by Mircea. The f:loadBundle works fine with page refreshes.

        Show
        Adnan Durrani added a comment - Support of standardRequestScope has been reimplemented to the ICEfaces. I have retested the f:loadBundle with and without standardRequestScope set to true and it came across that the problem already has fixed by Mircea. The f:loadBundle works fine with page refreshes.
        Ken Fyten made changes -
        Assignee Priority P1
        Assignee Mircea Toma [ mircea.toma ] Adnan Durrani [ adnan.durrani ]
        Ken Fyten made changes -
        Priority Major [ 3 ] Minor [ 4 ]
        Icefaces Administrator made changes -
        Field Original Value New Value
        issue.field.bugzillaimportkey 1297 12496
        Hide
        Adnan Durrani added a comment -

        I was testing component-showcase, the loadBundle working with page refresh but
        if you change the style theme, the theme does not change and the loadBundel does
        not exist in requestMap any more.

        Show
        Adnan Durrani added a comment - I was testing component-showcase, the loadBundle working with page refresh but if you change the style theme, the theme does not change and the loadBundel does not exist in requestMap any more.
        Hide
        Adnan Durrani added a comment -

        The loadBundle works properly on page refresh as well.

        I am wondering about standardRequestScope parameter, does icefaces not support
        this parameter anymore? I can see in the 1.5.2 src, if this parameter was set to
        true then we were clearing up the requestMap, but with the head this parameter
        never being evaluated.

        Show
        Adnan Durrani added a comment - The loadBundle works properly on page refresh as well. I am wondering about standardRequestScope parameter, does icefaces not support this parameter anymore? I can see in the 1.5.2 src, if this parameter was set to true then we were clearing up the requestMap, but with the head this parameter never being evaluated.
        Hide
        Ted Goddard added a comment -

        Does it recover when the page is refreshed? Previously this would result in a completely new requestMap
        and the bundles would be lost.

        Show
        Ted Goddard added a comment - Does it recover when the page is refreshed? Previously this would result in a completely new requestMap and the bundles would be lost.
        Hide
        Mircea Toma added a comment -

        Not much different. The HEAD has a different implementation than 1.5 branch, but functionality-wise it
        does the same thing. It saves the bundles that were put into the request during the parse phase and then
        injects them back in every request that comes in.

        Show
        Mircea Toma added a comment - Not much different. The HEAD has a different implementation than 1.5 branch, but functionality-wise it does the same thing. It saves the bundles that were put into the request during the parse phase and then injects them back in every request that comes in.
        Hide
        Ted Goddard added a comment -

        Good point; in the head, resource bundles are handled via a special case.

        Mircea, can you comment on how the 1.5 branch and the head differ in treatment of resource bundles?

        Show
        Ted Goddard added a comment - Good point; in the head, resource bundles are handled via a special case. Mircea, can you comment on how the 1.5 branch and the head differ in treatment of resource bundles?
        Hide
        Adnan Durrani added a comment -

        I have verified this behavior with v 1.5.2. I have created ice:loadBundle
        component as well. I have tried to reproduced same error with the head and it
        came accross that ICEfaces does not respecting standardRequestScope parameter
        anymore. So I stop working on ice:loadBundle, as f:loadBundle is already working
        with or without standardRequestScope.

        It is not that f:loadBundle is working, it is that support of the
        standardRequestScope has been removed according to my observation.

        Show
        Adnan Durrani added a comment - I have verified this behavior with v 1.5.2. I have created ice:loadBundle component as well. I have tried to reproduced same error with the head and it came accross that ICEfaces does not respecting standardRequestScope parameter anymore. So I stop working on ice:loadBundle, as f:loadBundle is already working with or without standardRequestScope. It is not that f:loadBundle is working, it is that support of the standardRequestScope has been removed according to my observation.
        Philip Breau created issue -

          People

          • Assignee:
            Unassigned
            Reporter:
            Philip Breau
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: