ICEfaces
  1. ICEfaces
  2. ICE-1175

Make minification of JavaScript configurable

    Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.5
    • Fix Version/s: 3.1.0.RC1, 3.1
    • Component/s: Release
    • Labels:
      None
    • Environment:
      Operating System: All
      Platform: All
    • Assignee Priority:
      P1
    • Affects:
      Documentation (User Guide, Ref. Guide, etc.), Compatibility/Configuration

      Description

      We now have compressed javascript files, which is a good thing for performance reason. However, it makes it more difficult for debugging and profiling. We have to manually modify the build files avoid minifying the JavaScript files. This takes time and can be error-prone.

      A better approach would be to automatically server human-readable / debug versions of all JavaScript files when running in JSF 2 "Development" project-stage. The other project-stages would continue to use minified resource files as they do now.

        Issue Links

          Activity

          Hide
          Mircea Toma added a comment -

          Modified 'core' and 'compat' builds to generate both compressed and uncompressed versions of the JS files. Modified also BridgeSetup and ExtrasSetup to insert the resources corresponding to the uncompressed files while running in Development mode.

          Show
          Mircea Toma added a comment - Modified 'core' and 'compat' builds to generate both compressed and uncompressed versions of the JS files. Modified also BridgeSetup and ExtrasSetup to insert the resources corresponding to the uncompressed files while running in Development mode.
          Hide
          Ken Fyten added a comment -

          Regression testing is showing the following new regression failures:

          Icefaces3/trunk revision# 29525
          Server: Tomcat7
          Browser: Firefox13

          Showcase:

          ace:autoCompleteEntry (All demos)

          • The list of autocomplete suggestions will not render when typing into the fields

          ace:draggable/droppable
          > Draggable

          • Possibly not a bug but when moving the location of the image and then changing one of the attributes of the draggable component, the image does not move back to it's original position. (In the past, changing the attributes caused the image to revert back to its original position)
            > Table Integration
          • Dragging the items into the shopping cart has no effect, the images just sit on top of the cart and don't populate themselves into the table. If refreshing the page the table gets populated with the appropriate item.

          ace:panel
          > Listener

          • The listener never gets called (or at least, the values do not get updated on the page) when interacting with the panel.

          ace:resizable
          > Resize Listener

          • The listener is not getting triggered (image never displays inside the panel)

          ace:textEntry

          • The textEntry fields will not submit when losing focus on them, must push enter to submit the field.

          Note that these have been verified to be unrelated to the recent Mojarra 2.1.9-patched update.

          Show
          Ken Fyten added a comment - Regression testing is showing the following new regression failures: Icefaces3/trunk revision# 29525 Server: Tomcat7 Browser: Firefox13 Showcase: ace:autoCompleteEntry (All demos) The list of autocomplete suggestions will not render when typing into the fields ace:draggable/droppable > Draggable Possibly not a bug but when moving the location of the image and then changing one of the attributes of the draggable component, the image does not move back to it's original position. (In the past, changing the attributes caused the image to revert back to its original position) > Table Integration Dragging the items into the shopping cart has no effect, the images just sit on top of the cart and don't populate themselves into the table. If refreshing the page the table gets populated with the appropriate item. ace:panel > Listener The listener never gets called (or at least, the values do not get updated on the page) when interacting with the panel. ace:resizable > Resize Listener The listener is not getting triggered (image never displays inside the panel) ace:textEntry The textEntry fields will not submit when losing focus on them, must push enter to submit the field. Note that these have been verified to be unrelated to the recent Mojarra 2.1.9-patched update.
          Hide
          Mircea Toma added a comment -

          ace:autoCompleteEntry and ace:textEntry regressions were caused by the patched Mojarra 2.1.9 update.

          Show
          Mircea Toma added a comment - ace:autoCompleteEntry and ace:textEntry regressions were caused by the patched Mojarra 2.1.9 update.
          Hide
          Mircea Toma added a comment - - edited

          Draggable/Table Integration, ace:panel/Listener and ace:resizable/Listener regressions cannot be reproduced when running with revision #29516 (which corresponds to the last commit for this issue).

          Show
          Mircea Toma added a comment - - edited Draggable/Table Integration, ace:panel/Listener and ace:resizable/Listener regressions cannot be reproduced when running with revision #29516 (which corresponds to the last commit for this issue).
          Hide
          Ken Fyten added a comment -

          The following issues are present when using project_stage="PRODUCTION" (and are not when project_stage="DEVELOPMENT"), tested using svn rvn#29542:

          ace:autoCompleteEntry (All demos)

          • The list of autocomplete suggestions will not render when typing into the fields

          ace:textEntry

          • The textEntry fields will not submit when losing focus on them, must push enter to submit the field.
          Show
          Ken Fyten added a comment - The following issues are present when using project_stage="PRODUCTION" (and are not when project_stage="DEVELOPMENT"), tested using svn rvn#29542: ace:autoCompleteEntry (All demos) The list of autocomplete suggestions will not render when typing into the fields ace:textEntry The textEntry fields will not submit when losing focus on them, must push enter to submit the field.
          Hide
          Mircea Toma added a comment -

          The problem was that after the uncompressed JS files were built the temporary files were removed before the compressed files would be build off these same files.

          Fixed 'compat' build to avoid removing the coalesced JS code before the the compressed JS resources are built.

          Show
          Mircea Toma added a comment - The problem was that after the uncompressed JS files were built the temporary files were removed before the compressed files would be build off these same files. Fixed 'compat' build to avoid removing the coalesced JS code before the the compressed JS resources are built.

            People

            • Assignee:
              Mircea Toma
              Reporter:
              Deryk Sinotte
            • Votes:
              1 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: