ICEfaces
  1. ICEfaces
  2. ICE-1159

Error Messaging: Nested forms are not throwing an exeption.

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.5.1
    • Fix Version/s: 1.6DR#2, 1.6
    • Component/s: ICE-Components
    • Labels:
      None
    • Environment:
      Operating System: Windows XP
      Platform: PC

      Activity

      Philip Breau created issue -
      Icefaces Administrator made changes -
      Field Original Value New Value
      issue.field.bugzillaimportkey 1210 12428
      Ken Fyten made changes -
      Priority Major [ 3 ] Minor [ 4 ]
      Ken Fyten made changes -
      Summary PanelTabSet (including nested forms in the tabs isn't throwing an exeption. Error MessagingPanelTabSet (including nested forms in the tabs isn't throwing an exeption.
      Ken Fyten made changes -
      Summary Error MessagingPanelTabSet (including nested forms in the tabs isn't throwing an exeption. Error Messaging: PanelTabSet (including nested forms in the tabs isn't throwing an exeption.
      Ken Fyten made changes -
      Assignee Philip Breau [ philip.breau ]
      Ken Fyten made changes -
      Fix Version/s 1.6 [ 10031 ]
      Ken Fyten made changes -
      Assignee Adnan Durrani [ adnan.durrani ]
      Ken Fyten made changes -
      Assignee Priority P3
      Hide
      Philip Breau added a comment -

      I would actually recommend raising the priority of this as it's one of the more important error messaging improvements. Nesting forms can result in indeterminant behaviour that can be very hard to diagnose on the surface.

      Show
      Philip Breau added a comment - I would actually recommend raising the priority of this as it's one of the more important error messaging improvements. Nesting forms can result in indeterminant behaviour that can be very hard to diagnose on the surface.
      Repository Revision Date User Message
      ICEsoft Public SVN Repository #13362 Thu Mar 01 17:48:53 MST 2007 adnan Fix for ICE-1159 [Error Messaging: Nested forms are not throwing an exeption.] The validation of nesting form has been added to the FormRenderer under the core branch, it will ensure that the Form action element can never be nested on a JSF page.
      Adding it inside the core FormRenderer would prohabite the nesting of any combination of h and ice form. If forms were found nested we throw a facesException, which force developers to fix the problem before proceeding ahead.
      Files Changed
      Commit graph MODIFY /icefaces/trunk/icefaces/core/src/com/icesoft/faces/renderkit/dom_html_basic/FormRenderer.java
      Hide
      Adnan Durrani added a comment -

      The validation of nesting form has been added to the FormRenderer under the core branch, it will ensure that the Form action element can never be nested on a JSF page.

      Adding it inside the core FormRenderer would prohabite the nesting of any combination of h and ice form. If forms were found nested we throw a facesException, which force developers to fix the problem before proceeding ahead.

      revision # 13362

      Show
      Adnan Durrani added a comment - The validation of nesting form has been added to the FormRenderer under the core branch, it will ensure that the Form action element can never be nested on a JSF page. Adding it inside the core FormRenderer would prohabite the nesting of any combination of h and ice form. If forms were found nested we throw a facesException, which force developers to fix the problem before proceeding ahead. revision # 13362
      Adnan Durrani made changes -
      Summary Error Messaging: PanelTabSet (including nested forms in the tabs isn't throwing an exeption. Error Messaging: Nested forms are not throwing an exeption.
      Description http://www.icefaces.org/JForum/posts/list/0/3358.page#15805 http://www.icefaces.org/JForum/posts/list/0/3358.page#15805
      Adnan Durrani made changes -
      Status Open [ 1 ] Resolved [ 5 ]
      Fix Version/s 1.6DR#2 [ 10040 ]
      Fix Version/s 1.6 [ 10031 ]
      Resolution Fixed [ 1 ]
      Ken Fyten made changes -
      Issue Type Bug [ 1 ] Improvement [ 4 ]
      Ken Fyten made changes -
      Fix Version/s 1.6 [ 10031 ]
      Ken Fyten made changes -
      Status Resolved [ 5 ] Closed [ 6 ]
      Assignee Priority P3
      Assignee Adnan Durrani [ adnan.durrani ]

        People

        • Assignee:
          Unassigned
          Reporter:
          Philip Breau
        • Votes:
          0 Vote for this issue
          Watchers:
          0 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved: