ICEfaces
  1. ICEfaces
  2. ICE-11513

Pressing Enter in ace:textEntry populates the field with inField label

    Details

      Description

      When an ace:textEntry has an inField label, if you focus on the field the label is removed, as expected, but if you press the Enter key, the field is populated with the label text.

        Activity

        Arturo Zambrano created issue -
        Arturo Zambrano made changes -
        Field Original Value New Value
        Assignee Arturo Zambrano [ artzambrano ]
        Ken Fyten made changes -
        Fix Version/s EE-3.3.0.GA_P09 [ 13781 ]
        Arturo Zambrano made changes -
        Affects Version/s EE-4.3.0.GA_P02 [ 13292 ]
        Arturo Zambrano made changes -
        Fix Version/s EE-4.3.0.GA_P03 [ 13570 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #53349 Mon Apr 19 08:44:15 MDT 2021 art.zambrano ICE-11513 prevent submit on enter on ace:textEntry with inField label when the field is empty, in order to avoid having the field populated with the inField label while it has focus
        Files Changed
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/textentry/textentry.js
        Hide
        Arturo Zambrano added a comment -

        r53349: prevent submit on enter on ace:textEntry with inField label when the field is empty, in order to avoid having the field populated with the inField label while it has focus (4.x trunk)
        r53350: committed fix to EE 3.3 maintenance branch.

        The issue was that when pressing enter on an empty ace:textEntry field with an inField label the DOMdiff detected a difference in the input field from being populated with the value to being empty, so it sent an update of the input field only. The field couldn't be submitted with the label in it as the value, though. It required to blur the field and focus again to be able to submit a user-entered value. On the 4.x trunk, things were more complicated as we also have the lazy loading behaviour, where we don't initialize the ace:textEntry component unti it is focused. There was another issue with it where the component was being reinitialized multiple times across dynamic updates, and the focus and blur listeners were being accomulated on the input field.

        Show
        Arturo Zambrano added a comment - r53349: prevent submit on enter on ace:textEntry with inField label when the field is empty, in order to avoid having the field populated with the inField label while it has focus (4.x trunk) r53350: committed fix to EE 3.3 maintenance branch. The issue was that when pressing enter on an empty ace:textEntry field with an inField label the DOMdiff detected a difference in the input field from being populated with the value to being empty, so it sent an update of the input field only. The field couldn't be submitted with the label in it as the value, though. It required to blur the field and focus again to be able to submit a user-entered value. On the 4.x trunk, things were more complicated as we also have the lazy loading behaviour, where we don't initialize the ace:textEntry component unti it is focused. There was another issue with it where the component was being reinitialized multiple times across dynamic updates, and the focus and blur listeners were being accomulated on the input field.
        Arturo Zambrano made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Arturo Zambrano added a comment -

        r53356, r53357: moved the previous fix to another point in the code path that will allow the fix to be applied when secret=true (EE 3.3 maintenance branch and customer P08 branch)

        Show
        Arturo Zambrano added a comment - r53356, r53357: moved the previous fix to another point in the code path that will allow the fix to be applied when secret=true (EE 3.3 maintenance branch and customer P08 branch)
        Hide
        Arturo Zambrano added a comment -

        r53362: Keep the fix at the two points in the code necessary for the secret and normal cases to work, while making sure each of those code blocks is only applied to one case (secret or normal) (3.3 EE maintenance branch).

        r53361: Committed fix to customer's branch

        Show
        Arturo Zambrano added a comment - r53362: Keep the fix at the two points in the code necessary for the secret and normal cases to work, while making sure each of those code blocks is only applied to one case (secret or normal) (3.3 EE maintenance branch). r53361: Committed fix to customer's branch
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Arturo Zambrano
            Reporter:
            Arturo Zambrano
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: