Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.3
    • Component/s: Release
    • Labels:
      None
    • Environment:
      ICEfaces 4.3
    • Affects:
      Documentation (User Guide, Ref. Guide, etc.), Compatibility/Configuration

      Description

      ICEfaces 4.3 will support JDK 1.8 through 10 only.

        Activity

        Ken Fyten created issue -
        Ken Fyten made changes -
        Field Original Value New Value
        Summary Support forJDK 1.8-10.0 Support for JDK 1.8-10.0
        Hide
        Ken Fyten added a comment -

        Okay all our builds now specify source and target class version compatibility with JDK 1.8.

        We have the following warnings that we should correct related to using jdk 1.8:

            [javac] Compiling 63 source files to /Users/Ken/Code/svn/icefaces4-trunk/icefaces/ace/generator/build
            [javac] /Users/Ken/Code/svn/icefaces4-trunk/icefaces/ace/generator/src/org/icefaces/ace/generator/merge/FacesConfigMerge.java:19: warning: OutputFormat is internal proprietary API and may be removed in a future release
            [javac] import com.sun.org.apache.xml.internal.serialize.OutputFormat;
            [javac]                                                 ^
            [javac] /Users/Ken/Code/svn/icefaces4-trunk/icefaces/ace/generator/src/org/icefaces/ace/generator/merge/FacesConfigMerge.java:20: warning: XMLSerializer is internal proprietary API and may be removed in a future release
            [javac] import com.sun.org.apache.xml.internal.serialize.XMLSerializer;
        ...
         
         [javac] /Users/Ken/Code/svn/icefaces4-trunk/icefaces/ace/component/src/org/icefaces/ace/model/tree/NodeModelLazyListKeyConverter.java:45: warning: non-varargs call of varargs method with inexact argument type for last parameter;
            [javac]         return new NodeKey(indexes);
            [javac]                            ^
            [javac]   cast to Object for a varargs call
            [javac]   cast to Object[] for a non-varargs call and to suppress this warning
        
        compile:
            [javac] Compiling 194 source files to /Users/Ken/Code/svn/icefaces4-trunk/icefaces/core/build/classes
            [javac] /Users/Ken/Code/svn/icefaces4-trunk/icefaces/core/src/main/java/org/icefaces/util/EnvUtils.java:298: warning: non-varargs call of varargs method with inexact argument type for last parameter;
            [javac]                         Object returnValue = method1.invoke(myfacesConfigInstance, noparams);
            [javac]                                                                                    ^
            [javac]   cast to Object for a varargs call
            [javac]   cast to Object[] for a non-varargs call and to suppress this warning
            [javac] /Users/Ken/Code/svn/icefaces4-trunk/icefaces/core/src/main/java/org/icefaces/util/EnvUtils.java:300: warning: non-varargs call of varargs method with inexact argument type for last parameter;
            [javac]                         Object returnValue2 = method2.invoke(myfacesConfigInstance, noparams);
            [javac]                                                                                     ^
            [javac]   cast to Object for a varargs call
            [javac]   cast to Object[] for a non-varargs call and to suppress this warning
            [javac] /Users/Ken/Code/svn/icefaces4-trunk/icefaces/core/src/main/java/org/icefaces/util/EnvUtils.java:302: warning: non-varargs call of varargs method with inexact argument type for last parameter;
            [javac]                         Object returnValue3 = method3.invoke(myfacesConfigInstance, noparams);
            [javac]                                                                                     ^
            [javac]   cast to Object for a varargs call
            [javac]   cast to Object[] for a non-varargs call and to suppress this warning
        
        Show
        Ken Fyten added a comment - Okay all our builds now specify source and target class version compatibility with JDK 1.8. We have the following warnings that we should correct related to using jdk 1.8: [javac] Compiling 63 source files to /Users/Ken/Code/svn/icefaces4-trunk/icefaces/ace/generator/build [javac] /Users/Ken/Code/svn/icefaces4-trunk/icefaces/ace/generator/src/org/icefaces/ace/generator/merge/FacesConfigMerge.java:19: warning: OutputFormat is internal proprietary API and may be removed in a future release [javac] import com.sun.org.apache.xml.internal.serialize.OutputFormat; [javac] ^ [javac] /Users/Ken/Code/svn/icefaces4-trunk/icefaces/ace/generator/src/org/icefaces/ace/generator/merge/FacesConfigMerge.java:20: warning: XMLSerializer is internal proprietary API and may be removed in a future release [javac] import com.sun.org.apache.xml.internal.serialize.XMLSerializer; ... [javac] /Users/Ken/Code/svn/icefaces4-trunk/icefaces/ace/component/src/org/icefaces/ace/model/tree/NodeModelLazyListKeyConverter.java:45: warning: non-varargs call of varargs method with inexact argument type for last parameter; [javac] return new NodeKey(indexes); [javac] ^ [javac] cast to Object for a varargs call [javac] cast to Object [] for a non-varargs call and to suppress this warning compile: [javac] Compiling 194 source files to /Users/Ken/Code/svn/icefaces4-trunk/icefaces/core/build/classes [javac] /Users/Ken/Code/svn/icefaces4-trunk/icefaces/core/src/main/java/org/icefaces/util/EnvUtils.java:298: warning: non-varargs call of varargs method with inexact argument type for last parameter; [javac] Object returnValue = method1.invoke(myfacesConfigInstance, noparams); [javac] ^ [javac] cast to Object for a varargs call [javac] cast to Object [] for a non-varargs call and to suppress this warning [javac] /Users/Ken/Code/svn/icefaces4-trunk/icefaces/core/src/main/java/org/icefaces/util/EnvUtils.java:300: warning: non-varargs call of varargs method with inexact argument type for last parameter; [javac] Object returnValue2 = method2.invoke(myfacesConfigInstance, noparams); [javac] ^ [javac] cast to Object for a varargs call [javac] cast to Object [] for a non-varargs call and to suppress this warning [javac] /Users/Ken/Code/svn/icefaces4-trunk/icefaces/core/src/main/java/org/icefaces/util/EnvUtils.java:302: warning: non-varargs call of varargs method with inexact argument type for last parameter; [javac] Object returnValue3 = method3.invoke(myfacesConfigInstance, noparams); [javac] ^ [javac] cast to Object for a varargs call [javac] cast to Object [] for a non-varargs call and to suppress this warning
        Hide
        Ken Fyten added a comment -

        Also when running showcase attempting to use the left-side menu fails with:

        Type Exception Report
        
        Message /resources/examples/ace/selectmenu/selectMenuOverview.xhtml @38,193 value="#{selectMenuBean.province}": Property [province] not found on type [org.icefaces.dialog.SelectMenuBean] 
        Show
        Ken Fyten added a comment - Also when running showcase attempting to use the left-side menu fails with: Type Exception Report Message /resources/examples/ace/selectmenu/selectMenuOverview.xhtml @38,193 value= "#{selectMenuBean.province}" : Property [province] not found on type [org.icefaces.dialog.SelectMenuBean]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #52504 Tue Jul 03 17:44:09 MDT 2018 ken.fyten ICE-11413 - Update build files and master pom to configure for JDK 1.8 source and target versions.
        Files Changed
        Commit graph MODIFY /icefaces4/trunk/icefaces/mobi/component/build.xml
        Commit graph MODIFY /icepush/branches/icepush-core-4.x-maintenance/icepush/build.properties
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/generator/build.xml
        Commit graph MODIFY /icepush/branches/icepush-core-4.x-maintenance/icepush/build-common.xml
        Commit graph MODIFY /icefaces4/trunk/icefaces/samples/build/common.xml
        Commit graph MODIFY /icefaces4/trunk/icefaces/pom.xml
        Commit graph MODIFY /icefaces4/trunk/icefaces/common-tasks.xml
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/build.xml
        Commit graph MODIFY /icefaces4/trunk/icefaces/core/build.xml
        Commit graph MODIFY /icefaces4/trunk/icefaces/build.properties
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/tools/batchminify/build.xml
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #52505 Wed Jul 04 12:25:32 MDT 2018 art.zambrano ICE-11413 fixes to correct varargs method invocation warnings and API warnings, for which the Xerces 2.12.0 library had to be added
        Files Changed
        Commit graph MODIFY /icefaces4/trunk/icefaces/core/src/main/java/org/icefaces/util/EnvUtils.java
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/generator/src/org/icefaces/ace/generator/merge/FacesConfigMerge.java
        Commit graph ADD /icefaces4/trunk/icefaces/lib/xercesImpl.jar
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/model/tree/NodeModelLazyListKeyConverter.java
        Commit graph ADD /icefaces4/trunk/icefaces/lib/xml-apis.jar
        Hide
        Arturo Zambrano added a comment -

        r52505: fixes to correct varargs method invocation warnings and API warnings, for which the Xerces 2.12.0 library had to be added

        The showcase is now working correctly as well.

        Show
        Arturo Zambrano added a comment - r52505: fixes to correct varargs method invocation warnings and API warnings, for which the Xerces 2.12.0 library had to be added The showcase is now working correctly as well.
        Arturo Zambrano made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Ken Fyten made changes -
        Fix Version/s 4.3 [ 13096 ]
        Hide
        Ken Fyten added a comment -

        Please verify that the xerces 2.12.0 lib is only required while building ICEfaces itself, and not for runtime deployments.

        Show
        Ken Fyten added a comment - Please verify that the xerces 2.12.0 lib is only required while building ICEfaces itself, and not for runtime deployments.
        Ken Fyten made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Hide
        Arturo Zambrano added a comment -

        Yes, Xerces is only used for compiling and not at runtime. We only use it to merge our custom faces-config.xml with the generated faces-config.xml, and we include the merged faces-config.xml in the ace jar

        Show
        Arturo Zambrano added a comment - Yes, Xerces is only used for compiling and not at runtime. We only use it to merge our custom faces-config.xml with the generated faces-config.xml, and we include the merged faces-config.xml in the ace jar
        Arturo Zambrano made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #52508 Fri Jul 06 16:05:16 MDT 2018 ken.fyten ICE-11413 - Update build file to configure for JDK 1.8 source and target versions.
        Files Changed
        Commit graph MODIFY /icepush/trunk/icepush/build-common.xml
        Commit graph MODIFY /icepush/trunk/icepush/build.properties
        Commit graph MODIFY /icepush/trunk/icepush/pom.xml
        Ken Fyten made changes -
        Affects Documentation (User Guide, Ref. Guide, etc.),Compatibility/Configuration [ 10003, 10002 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #52509 Fri Jul 06 17:14:45 MDT 2018 art.zambrano ICE-11413 added javax.inject library for building javadoc targets without errors
        Files Changed
        Commit graph ADD /icefaces4/trunk/icefaces/lib/javax.inject-2.1.95.jar
        Hide
        Arturo Zambrano added a comment -

        r52509: added javax.inject library (javax.inject-2.1.95.jar) for building javadoc targets without errors

        Show
        Arturo Zambrano added a comment - r52509: added javax.inject library (javax.inject-2.1.95.jar) for building javadoc targets without errors
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Unassigned
            Reporter:
            Ken Fyten
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: