Details
-
Type: Bug
-
Status: Closed
-
Priority: Major
-
Resolution: Fixed
-
Affects Version/s: EE-4.2.0.GA, EE-3.3.0.GA_P05
-
Fix Version/s: 4.3, EE-3.3.0.GA_P06
-
Component/s: ACE-Components
-
Labels:None
-
Environment:ace
-
Support Case References:
Description
Using ace:dyanmicResource id="......" type="button", the renderer does not write the id to the html markup.
The container is rendered with the id, but the id of the element is only written when the type is not "button"
....
from DynamicResourceRenderer code....
{code}
...
if ("button".equals(dynamicResource.getType())) {
writer.startElement(HTML.INPUT_ELEM, null);
if (disabled) {
writer.writeAttribute(HTML.DISABLED_ATTR, HTML.DISABLED_ATTR, null);
}
writer.writeAttribute(HTML.TYPE_ATTR, "button", null);
writer.writeAttribute(HTML.VALUE_ATTR, label, null);
writer.writeAttribute(HTML.ONCLICK_ATTR, "window.open('" + resource.getRequestPath() + "');", null);
writeStyleAttributes(dynamicResource, writer);
writer.endElement(HTML.INPUT_ELEM);
} else {
if (disabled) {
writer.startElement(HTML.SPAN_ELEM, null);
} else {
writer.startElement(HTML.ANCHOR_ELEM, null);
writer.writeAttribute(HTML.HREF_ATTR, resource.getRequestPath(), null);
String target = dynamicResource.getTarget();
if (target != null) {
writer.writeAttribute(HTML.TARGET_ATTR, target, null);
}
}
writer.writeAttribute(HTML.ID_ATTR, clientId, null);
String image = dynamicResource.getImage();
.....
{code}
The container is rendered with the id, but the id of the element is only written when the type is not "button"
....
from DynamicResourceRenderer code....
{code}
...
if ("button".equals(dynamicResource.getType())) {
writer.startElement(HTML.INPUT_ELEM, null);
if (disabled) {
writer.writeAttribute(HTML.DISABLED_ATTR, HTML.DISABLED_ATTR, null);
}
writer.writeAttribute(HTML.TYPE_ATTR, "button", null);
writer.writeAttribute(HTML.VALUE_ATTR, label, null);
writer.writeAttribute(HTML.ONCLICK_ATTR, "window.open('" + resource.getRequestPath() + "');", null);
writeStyleAttributes(dynamicResource, writer);
writer.endElement(HTML.INPUT_ELEM);
} else {
if (disabled) {
writer.startElement(HTML.SPAN_ELEM, null);
} else {
writer.startElement(HTML.ANCHOR_ELEM, null);
writer.writeAttribute(HTML.HREF_ATTR, resource.getRequestPath(), null);
String target = dynamicResource.getTarget();
if (target != null) {
writer.writeAttribute(HTML.TARGET_ATTR, target, null);
}
}
writer.writeAttribute(HTML.ID_ATTR, clientId, null);
String image = dynamicResource.getImage();
.....
{code}
Activity
Judy Guglielmin
created issue -
Judy Guglielmin
made changes -
Field | Original Value | New Value |
---|---|---|
Assignee | Arturo Zambrano [ artzambrano ] |
Judy Guglielmin
made changes -
Fix Version/s | 4.3 [ 13096 ] | |
Fix Version/s | EE-3.3.0.GA_P07 [ 13118 ] |
Repository | Revision | Date | User | Message |
ICEsoft Public SVN Repository | #52359 | Tue Mar 27 19:38:16 MDT 2018 | art.zambrano | |
Files Changed | ||||
MODIFY
/icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/dynamicresource/DynamicResourceRenderer.java
|
Arturo Zambrano
made changes -
Status | Open [ 1 ] | Resolved [ 5 ] |
Resolution | Fixed [ 1 ] |
Judy Guglielmin
made changes -
Support Case References | Support Case 14313:- https://icesoft.my.salesforce.com/5000g00001sOXDC?srPos=0&srKp=500 |
Support Case 14313:- https://icesoft.my.salesforce.com/5000g00001sOXDC?srPos=0&srKp=500
Support Case 14310:- https://icesoft.my.salesforce.com/5000g00001sO111 |
Judy Guglielmin
made changes -
Support Case References |
Support Case 14313:- https://icesoft.my.salesforce.com/5000g00001sOXDC?srPos=0&srKp=500
Support Case 14310:- https://icesoft.my.salesforce.com/5000g00001sO111 |
Support Case 14313:- https://icesoft.my.salesforce.com/5000g00001sOXDC?srPos=0&srKp=500
Support Case 14310:- https://icesoft.my.salesforce.com/5000g00001sO111 Support Case 14311:- https://icesoft.my.salesforce.com/5000g00001sO1dF Support Case 14309 |
Judy Guglielmin
made changes -
Support Case References |
Support Case 14313:- https://icesoft.my.salesforce.com/5000g00001sOXDC?srPos=0&srKp=500
Support Case 14310:- https://icesoft.my.salesforce.com/5000g00001sO111 Support Case 14311:- https://icesoft.my.salesforce.com/5000g00001sO1dF Support Case 14309 |
Support Case 14313:- https://icesoft.my.salesforce.com/5000g00001sOXDC?srPos=0&srKp=500
|
Ken Fyten
made changes -
Fix Version/s | EE-3.3.0.GA_P06 [ 13114 ] | |
Fix Version/s | EE-3.3.0.GA_P07 [ 13118 ] |
Ken Fyten
made changes -
Status | Resolved [ 5 ] | Closed [ 6 ] |
r52359: fix to render client id on button element when the type is 'button'; added another fix to force a full update of the component when changing types, in order to avoid some dom diff issues (4.0 trunk)
r52360: committed fix to the 3.3 EE m aintenance branch