ICEfaces
  1. ICEfaces
  2. ICE-11375

ice: components send value to a converter even when null, causing an NPE

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: EE-3.3.0.GA_P05
          • Fix Version/s: EE-3.3.0.GA_P06
          • Component/s: ICE-Components
          • Labels:
            None
          • Environment:
            Any

            Description

            When the value of our ice:inputText component is null and there's a converter specified for this component, a NullPointerException occurs because our component sends the value to the converter anyway, unlike h:inputText, which doesn't send it, avoiding this kind of issues.

              Activity

              Ascending order - Click to sort in descending order
              Arturo Zambrano created issue -
              Arturo Zambrano made changes -
              Field Original Value New Value
              Assignee Arturo Zambrano [ artzambrano ]
              Arturo Zambrano made changes -
              Fix Version/s EE-3.3.0.GA_P06 [ 13114 ]
              Judy Guglielmin made changes -
              Support Case References Support case 14249 Support case 14249:- https://icesoft.my.salesforce.com/5000g00001opMwk
              Ken Fyten made changes -
              Assignee Priority P1 [ 10010 ]
              Hide
              Permalink
              Arturo Zambrano added a comment -

              r52128: fix to avoid sending a null value to a converter, in order to prevent possible NullPointerException exceptions

              This fix is actually applied for all compat (ice:*) components.

              Looking at the mojarra source code, this behaviour is confirmed. The following two pages have discuss this fact in more detail.

              https://stackoverflow.com/questions/27048438/jsf-custom-converter-not-called-on-null-value
              https://stackoverflow.com/questions/35347001/jsf-converter-with-null-value

              Show
              Arturo Zambrano added a comment - r52128: fix to avoid sending a null value to a converter, in order to prevent possible NullPointerException exceptions This fix is actually applied for all compat (ice:*) components. Looking at the mojarra source code, this behaviour is confirmed. The following two pages have discuss this fact in more detail. https://stackoverflow.com/questions/27048438/jsf-custom-converter-not-called-on-null-value https://stackoverflow.com/questions/35347001/jsf-converter-with-null-value
              Arturo Zambrano made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #52129 Thu Dec 07 10:29:03 MST 2017 art.zambrano ICE-11375 cleaned up code, removed temporary comments and commented out code
              Files Changed
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/datatable/datatable.js
              Arturo Zambrano made changes -
              Comment [ Summary of features that work and don't work in conjunction with column pinning.

              h4. Working
              * selection
              * sorting
              * filtering (the whole table is slightly shifted to the right after filtering a pinned column, no more shifting on subsequent filtering actions)
              * panel expansion
              * row expansion
              * row listener

              h4. Not Working
              * paginator (misalignments after paginating when at least one column is pinned, it seems like applying resizeScrolling() afterwards fixes them)
              * column reordering (misalignments when reordering a column when at least one column is pinned)
              * column resizing (column resizing functionality not possible at all on scrollable tables, not directly related to column pinning)
              * grouping, column group (as expected)
              * live scrolling (misalignments occur after the first live scrollling dynamic update)
              * cell editor (pinned columns are moved to the left edge of the page when activating the cell editor)

              * table config panel (changes to table structure or table order won't work, but sorting and name changes will work) ]
              Arturo Zambrano made changes -
              Comment [ r52129: cleaned up code, removed temporary comments and commented out code ]
              Ken Fyten made changes -
              Summary ice:inputText sends value to the converter even if it's null, causing an NPE ice:input* components (e.g. ice:inputText) send value to the converter even when null, causing an NPE
              Ken Fyten made changes -
              Summary ice:input* components (e.g. ice:inputText) send value to the converter even when null, causing an NPE ice: input components (e.g. ice:inputText) send value to the converter even when null, causing an NPE
              Ken Fyten made changes -
              Summary ice: input components (e.g. ice:inputText) send value to the converter even when null, causing an NPE ice: components send value to a converter even when null, causing an NPE
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]

                People

                • Assignee:
                  Arturo Zambrano
                  Reporter:
                  Arturo Zambrano
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: