ICEfaces
  1. ICEfaces
  2. ICE-11299

Add ace:colorEntry to the Emporium demo

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: EE-4.2.0.GA
    • Component/s: ACE-Components, Sample Apps
    • Labels:
      None
    • Environment:
      ICEfaces 4.2
    • Assignee Priority:
      P2
    • Affects:
      Sample App./Tutorial

      Description

      The Emporium sample app. allows the user to specify a color for the fore and background of Notifications in the Settings tab.

      We should replace the existing input components for these colors with the new ace:colorEntry component from IF 4.2.

        Activity

        Ken Fyten created issue -
        Hide
        Ken Fyten added a comment -

        Screenshot of the Settings tab.

        Show
        Ken Fyten added a comment - Screenshot of the Settings tab.
        Ken Fyten made changes -
        Field Original Value New Value
        Attachment Screen Shot 2017-05-09 at 2.14.02 PM.png [ 22517 ]
        Ken Fyten made changes -
        Assignee Judy Guglielmin [ judy.guglielmin ]
        Fix Version/s EE-4.2.0.GA [ 13071 ]
        Affects Sample App./Tutorial [ 10001 ]
        Assignee Priority P2 [ 10011 ]
        Hide
        Judy Guglielmin added a comment -

        rev 5153 which depends on ICE-11306

        Show
        Judy Guglielmin added a comment - rev 5153 which depends on ICE-11306
        Judy Guglielmin made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #51538 Tue May 16 16:57:56 MDT 2017 judy.guglielmin ICE-11299 depends on ICE-11306
        Files Changed
        Commit graph DEL /icefaces4/trunk/icefaces/samples/ace/emporium/src/main/webapp/resources/components/colorPicker.xhtml
        Commit graph MODIFY /icefaces4/trunk/icefaces/samples/ace/emporium/src/main/java/org/icefaces/demo/emporium/settings/SettingsBean.java
        Commit graph MODIFY /icefaces4/trunk/icefaces/samples/ace/emporium/src/main/webapp/WEB-INF/includes/settings-tab.xhtml
        Commit graph DEL /icefaces4/trunk/icefaces/samples/ace/emporium/src/main/java/org/icefaces/demo/emporium/util/ColorRGBA.java
        Commit graph MODIFY /icefaces4/trunk/icefaces/samples/ace/emporium/src/main/java/org/icefaces/demo/emporium/util/ListData.java
        Hide
        Liana Munroe added a comment -

        Verified functionality ICEfaces 4 trunk r51542, tomcat 8, MS Edge, IE 11, 10, 9, 8, FF 47, Chrome 57.

        Color values are returned as high scale values such as 92.579665464546545441584% and do not fit into the colorEntry. See attached screenshot 1.PNG

        Reopening JIRA to have colors shown as HEX values instead of RGB %

        Show
        Liana Munroe added a comment - Verified functionality ICEfaces 4 trunk r51542, tomcat 8, MS Edge, IE 11, 10, 9, 8, FF 47, Chrome 57. Color values are returned as high scale values such as 92.579665464546545441584% and do not fit into the colorEntry. See attached screenshot 1.PNG Reopening JIRA to have colors shown as HEX values instead of RGB %
        Liana Munroe made changes -
        Attachment 1.PNG [ 22535 ]
        Liana Munroe made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Hide
        Judy Guglielmin added a comment -

        The SwatchEntry class allows RGB as well as NAME rather than HEX. Without modifying the javascript plugin to reformat the RGB as well as the styling to use smaller font and larger sized input, it appeared that using the NAME colorFormat was simplest solution.

        rev 51557

        Show
        Judy Guglielmin added a comment - The SwatchEntry class allows RGB as well as NAME rather than HEX. Without modifying the javascript plugin to reformat the RGB as well as the styling to use smaller font and larger sized input, it appeared that using the NAME colorFormat was simplest solution. rev 51557
        Judy Guglielmin made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #51557 Wed May 24 14:46:08 MDT 2017 judy.guglielmin ICE-11299 without changing the plugin to reformat the RGB output as well as modifying the styling and font size as well, easiest just to use the color "NAME" to define the color. This means that opacity really isn't used though, so not sure how important that was in the original intent of the app.
        Files Changed
        Commit graph MODIFY /icefaces4/trunk/icefaces/samples/ace/emporium/src/main/java/org/icefaces/demo/emporium/settings/SettingsBean.java
        Commit graph MODIFY /icefaces4/trunk/icefaces/samples/ace/emporium/src/main/java/org/icefaces/demo/emporium/util/ListData.java
        Hide
        Liana Munroe added a comment -

        Verified ICEfaces 4 trunk r51557

        Show
        Liana Munroe added a comment - Verified ICEfaces 4 trunk r51557
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Judy Guglielmin
            Reporter:
            Ken Fyten
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: