ICEfaces
  1. ICEfaces
  2. ICE-11273

Reset type ace:pushButton fails with mobi date and time spinners

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 4.2
          • Fix Version/s: EE-4.2.0.GA
          • Component/s: ACE-Components, MOBI-Components
          • Labels:
            None
          • Environment:
            ICEfaces4 trunk r51330
            Browsers: all (tested on MsEdge, FF49)
            Server: Tomcat7
          • Assignee Priority:
            P2

            Description

            On a test page with a "Reset" type ace:pushButton and a mobi:dateSpinner and mobi:timeSpinner, the values in the mobi components are changed; when clicking the "Reset" type ace:pushButton, the updated values are reset only in the input entries; if clicking the calendar icons and re-opening the mobi components, the values are not reset.
            See attached screen shots.

            QA test app:
            http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces4/Sparkle/Nightly/pushButton

            Test page: /ICE-10114mobi.jsf

            1. 1.PNG
              8 kB
            2. 2.PNG
              7 kB
            3. reset.PNG
              46 kB

              Activity

              Ascending order - Click to sort in descending order
              Carmen Cristurean created issue -
              Carmen Cristurean made changes -
              Field Original Value New Value
              Fix Version/s EE-4.2.0.GA [ 13071 ]
              Carmen Cristurean made changes -
              Attachment reset.PNG [ 22487 ]
              Ken Fyten made changes -
              Assignee Judy Guglielmin [ judy.guglielmin ]
              Assignee Priority P2 [ 10011 ]
              Ken Fyten made changes -
              Security Private [ 10001 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #51378 Thu Mar 23 16:20:28 MDT 2017 judy.guglielmin ICE-11273 noted that dependency for jar was on core instead of ace so fixed that while looking at mobi jira.
              Files Changed
              Commit graph MODIFY /icefaces4/trunk/icefaces/mobi/component/resources/icefaces.mobi/META-INCLUDE/faces-config.xml
              Hide
              Permalink
              Judy Guglielmin added a comment -

              rev 41466 timespinner and dateSpinner now have clear and reset support. pushButton QA test updated (ICE-10114mobi.xhtml) rev 46908 to make testing clearer.

              Show
              Judy Guglielmin added a comment - rev 41466 timespinner and dateSpinner now have clear and reset support. pushButton QA test updated ( ICE-10114 mobi.xhtml) rev 46908 to make testing clearer.
              Judy Guglielmin made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #51466 Wed May 03 16:35:07 MDT 2017 judy.guglielmin ICE-11273 dateSpinner and timeSpinner reset and clear now functioning. QA pushButton test modified for clearer testing rev 46908
              Files Changed
              Commit graph MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/renderkit/InputRenderer.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/mobi/component/resources/org.icefaces.component.datespinner/datespinner.js
              Commit graph MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/component/datespinner/DateSpinnerRenderer.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/mobi/component/resources/org.icefaces.component.timespinner/timespinner.js
              Commit graph MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/component/timespinner/TimeSpinnerRenderer.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/component/datespinner/DateSpinner.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/core/core.js
              Commit graph MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/component/datespinner/DateSpinnerMeta.java
              Hide
              Permalink
              Liana Munroe added a comment -

              Tested with ICEfaces 4 trunk r51480, Tomcat 8.
              After using the Clear button then opening the date or time picker, the components are no longer usable as they are loaded with blank values. When toggling up or down the value returned is NaN. See attached screenshots 1.PNG and 2.PNG

              To reproduce:
              Use QA test app /ICE-10114mobi.jsf found at:
              http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces4/Sparkle/Nightly/pushButton

              1.) Open app and press the Clear button for the date and time spinners, the text input fields are cleared.
              2.) Click on the popup calendar icon for either the date or time picker. Picker values are blank.

              Show
              Liana Munroe added a comment - Tested with ICEfaces 4 trunk r51480, Tomcat 8. After using the Clear button then opening the date or time picker, the components are no longer usable as they are loaded with blank values. When toggling up or down the value returned is NaN. See attached screenshots 1.PNG and 2.PNG To reproduce: Use QA test app / ICE-10114 mobi.jsf found at: http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces4/Sparkle/Nightly/pushButton 1.) Open app and press the Clear button for the date and time spinners, the text input fields are cleared. 2.) Click on the popup calendar icon for either the date or time picker. Picker values are blank.
              Liana Munroe made changes -
              Attachment 1.PNG [ 22515 ]
              Attachment 2.PNG [ 22516 ]
              Liana Munroe made changes -
              Description On a test page with a "Reset" type ace:pushButton and a mobi:dateSpinner and mobi:timeSpinner, the values in the mobi components are changed; when clicking the "Reset" type ace:pushButton, the updated values are reset only in the input entries; if clicking the calendar icons and re-opening the mobi components, the values are not reset.
              See attached screen shot.

              QA test app:
              http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces4/Sparkle/Nightly/pushButton

              Test page: /ICE-10114mobi.jsf

              		On a test page with a "Reset" type ace:pushButton and a mobi:dateSpinner and mobi:timeSpinner, the values in the mobi components are changed; when clicking the "Reset" type ace:pushButton, the updated values are reset only in the input entries; if clicking the calendar icons and re-opening the mobi components, the values are not reset.
              See attached screen shots.

              QA test app:
              http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces4/Sparkle/Nightly/pushButton

              Test page: /ICE-10114mobi.jsf

              Liana Munroe made changes -
              Resolution Fixed [ 1 ]
              Status Resolved [ 5 ] Reopened [ 4 ]
              Hide
              Permalink
              Judy Guglielmin added a comment -

              rev 51501

              Show
              Judy Guglielmin added a comment - rev 51501
              Judy Guglielmin made changes -
              Status Reopened [ 4 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #51501 Tue May 09 15:19:29 MDT 2017 judy.guglielmin ICE-11273 fix so that clear does not reproduce not available values and that reset respects clear and uses different way to reset for date
              Files Changed
              Commit graph MODIFY /icefaces4/trunk/icefaces/mobi/component/resources/org.icefaces.component.datespinner/datespinner.js
              Commit graph MODIFY /icefaces4/trunk/icefaces/mobi/component/resources/org.icefaces.component.timespinner/timespinner.js
              Hide
              Permalink
              Liana Munroe added a comment -

              Tested with ICEfaces 4 trunk r51503. The date and time pickers are still rendered with empty values after pressing the Clear button.

              Show
              Liana Munroe added a comment - Tested with ICEfaces 4 trunk r51503. The date and time pickers are still rendered with empty values after pressing the Clear button.
              Liana Munroe made changes -
              Resolution Fixed [ 1 ]
              Status Resolved [ 5 ] Reopened [ 4 ]
              Hide
              Permalink
              Ken Fyten added a comment -

              The reset and clear functions should affect the submitted value for the component, not he picklist values.

              Reset

              1. Form loads with my birthday as the selected date and my birthtime as the selected time (say Sept. 20th, 1979 @ 2am).
              2. I edit those values to Sept. 22nd, 2017 @ 5:00pm
              3. I press Reset, now the values for the date and time entry are reset to the original values they had when the form was loaded, my birthday and time (Sept. 20th, 1979 @ 2am).

              Clear

              1. Form loads with my birthday as the selected date and my birthtime as the selected time (say Sept. 20th, 1979 @ 2am).
              2. I edit those values to Sept. 22nd, 2017 @ 5:00pm
              3. I press Clear, now the values for the date and time entry are reset to null values, as if nothing had ever been entered for them.
              Show
              Ken Fyten added a comment - The reset and clear functions should affect the submitted value for the component, not he picklist values. Reset Form loads with my birthday as the selected date and my birthtime as the selected time (say Sept. 20th, 1979 @ 2am). I edit those values to Sept. 22nd, 2017 @ 5:00pm I press Reset, now the values for the date and time entry are reset to the original values they had when the form was loaded, my birthday and time (Sept. 20th, 1979 @ 2am). Clear Form loads with my birthday as the selected date and my birthtime as the selected time (say Sept. 20th, 1979 @ 2am). I edit those values to Sept. 22nd, 2017 @ 5:00pm I press Clear, now the values for the date and time entry are reset to null values, as if nothing had ever been entered for them.
              Hide
              Permalink
              Liana Munroe added a comment - - edited

              For an example of the Clear functionality with dateTimeEntry use the /ClearResetSubmit.jsf test (ace:pushButton Clear/Reset/Submit Attributes) app at:
              http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces4/Sparkle/Nightly/pushButton

              Show
              Liana Munroe added a comment - - edited For an example of the Clear functionality with dateTimeEntry use the /ClearResetSubmit.jsf test (ace:pushButton Clear/Reset/Submit Attributes) app at: http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces4/Sparkle/Nightly/pushButton
              Hide
              Permalink
              Judy Guglielmin added a comment -

              rev 51515 when useNative is false, the popups are no longer cleared of values when the clear button on the test (triggering the "clear" function) is fired.

              Show
              Judy Guglielmin added a comment - rev 51515 when useNative is false, the popups are no longer cleared of values when the clear button on the test (triggering the "clear" function) is fired.
              Judy Guglielmin made changes -
              Status Reopened [ 4 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #51515 Thu May 11 11:04:04 MDT 2017 judy.guglielmin ICE-11273 useNative is false, popups do not get cleared when clear function is used.
              Files Changed
              Commit graph MODIFY /icefaces4/trunk/icefaces/mobi/component/resources/org.icefaces.component.datespinner/datespinner.js
              Commit graph MODIFY /icefaces4/trunk/icefaces/mobi/component/resources/org.icefaces.component.timespinner/timespinner.js
              Hide
              Permalink
              Liana Munroe added a comment -

              Verified ICEfaces 4 trunk r51517, tomcat 8, MS Edge, IE 11, 10, FF 47, Chrome 57, android 6.0.1, ios 10.2

              Show
              Liana Munroe added a comment - Verified ICEfaces 4 trunk r51517, tomcat 8, MS Edge, IE 11, 10, FF 47, Chrome 57, android 6.0.1, ios 10.2
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]

                People

                • Assignee:
                  Judy Guglielmin
                  Reporter:
                  Carmen Cristurean
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  4 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: