ICEfaces
  1. ICEfaces
  2. ICE-11253

FileEntryUpload.java does not add URL parameters to the ExternalContext request parameter map

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 4.2.BETA
    • Fix Version/s: 4.2
    • Component/s: ACE-Components
    • Labels:
      None
    • Environment:
      Reproducible in a portlet environment, but technically not a portlet issue.
    • Assignee Priority:
      P1

      Description

      When uploading a file, visible input fields and hidden input fields will be returned as parts. But parameters found on the URL contained in the form's action attribute are not returned as parts.

      FileEntryUpload.java only builds up a list of parameters from the parts that it finds. It needs to add the URL parameters as well.

      For example, in a portlet environment the following are URL parameters:
      ice.view=vtggqoq1:0
      _jsfBridgeAjax=true
      ice.fileEntry.multipart=true
      ice.window=isizq7jutb
      _facesViewIdResource=/WEB-INF/views/portletViewMode.xhtml

      h3. Steps to Reproduce:

      A. Follow steps #1 - #11 in ICE-11241.

      B. Using the browser inspection tools, view the list of network requests

      C. Using the "Choose Files" button, select a file to upload.

      D. Click on the "Add Attachment" button

      (/) Expected Results

      The file is uploaded and appears in the list of uploaded files.

      (x) Actual Results

      The file is not uploaded and does not appear in the list of uploaded files and the partial-response will contain markup outside of the <partial-response>...</partial-response>

        Activity

        Neil Griffin created issue -
        Neil Griffin made changes -
        Field Original Value New Value
        Attachment ICE-11253.patch [ 22469 ]
        Ken Fyten made changes -
        Assignee Mircea Toma [ mircea.toma ]
        Fix Version/s 4.2 [ 12870 ]
        Affects Version/s 4.2.BETA [ 13091 ]
        Assignee Priority P1 [ 10010 ]
        Hide
        Mircea Toma added a comment -

        Merge in the URL parameters with the multipart paramterers of the upload request.

        Show
        Mircea Toma added a comment - Merge in the URL parameters with the multipart paramterers of the upload request.
        Mircea Toma made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Mircea Toma added a comment -

        Created follow up case ICE-11260.

        Show
        Mircea Toma added a comment - Created follow up case ICE-11260 .
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #50939 Mon Mar 06 14:19:56 MST 2017 mircea.toma ICE-11253 Merge in the URL parameters of the upload request.
        Files Changed
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/fileentry/FileEntryUpload.java
        Hide
        Liana Munroe added a comment -

        Tested showcase and QA fileEntry test apps with ICEfaces 4.2.0 Jenkins build 2. Verified no new issues found. All uploaded files are present. Tomcat 8, MS Edge 38, IE 11, 10, 9, Chrome 56, FF 47.

        Show
        Liana Munroe added a comment - Tested showcase and QA fileEntry test apps with ICEfaces 4.2.0 Jenkins build 2. Verified no new issues found. All uploaded files are present. Tomcat 8, MS Edge 38, IE 11, 10, 9, Chrome 56, FF 47.
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Mircea Toma
            Reporter:
            Neil Griffin
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: