ICEfaces
  1. ICEfaces
  2. ICE-11239

ace:tabSet - tabPane with ace:dataTable being instantiated when not shown

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: EE-4.1.0.GA, EE-3.3.0.GA_P04, 4.2.BETA
    • Fix Version/s: EE-4.2.0.GA, EE-3.3.0.GA_P05
    • Component/s: ACE-Components
    • Labels:
      None
    • Environment:
      All

      Description

      An ace:tabSet is set to display two tabPane's. Each tabPane has a ViewScoped bean assigned to it. In this scenario, only the active tab should be initialized when the page is loaded.

      This is true unless the second tabPane has an ace:dataTable on the page. With the dataTable included, it is initializing the View scoped bean on load and is doing so before the bean for the first tabPane.

      No changes to the cache attribute of the ace:tabPane have any effect on this behavior.

        Activity

        Hide
        Arran Mccullough added a comment -

        Attached test case.

        Steps:

        • Load welcomeICEfaces .jsf
        • In the server logs it will show the following (incorrect):
          TabPaneTwoBean Initialized!
          TabPaneOneBean Initialized!
        • With the ace:dataTable commented out of the second tabPane the following is shown on page load (correct):
          TabPaneOneBean Initialized!
        Show
        Arran Mccullough added a comment - Attached test case. Steps: Load welcomeICEfaces .jsf In the server logs it will show the following (incorrect): TabPaneTwoBean Initialized! TabPaneOneBean Initialized! With the ace:dataTable commented out of the second tabPane the following is shown on page load (correct): TabPaneOneBean Initialized!
        Hide
        Ken Fyten added a comment -

        Something related to the tabpane's cache mode setting perhaps?

        Show
        Ken Fyten added a comment - Something related to the tabpane's cache mode setting perhaps?
        Hide
        Mircea Toma added a comment -

        This behaviour where the dataTable's values are evaluated is caused by the fix for issue ICE-9585 . Reverting the fix solves this problem without visible regressions in data table's behaviour.

        Show
        Mircea Toma added a comment - This behaviour where the dataTable's values are evaluated is caused by the fix for issue ICE-9585 . Reverting the fix solves this problem without visible regressions in data table's behaviour.
        Hide
        Ken Fyten added a comment -

        Assigned to Art to investigate further.

        Show
        Ken Fyten added a comment - Assigned to Art to investigate further.
        Hide
        Arturo Zambrano added a comment -

        r51397: fix during visitTree to only regenerate the data model when it is necessary to visit rows, thus preventing initializing view-scoped beans bound to ace:dataTable components that haven't come into view yet

        This fix doesn't break ICE-9585, as tested with attached welcomeICEfaces.xhtml modified version.

        Show
        Arturo Zambrano added a comment - r51397: fix during visitTree to only regenerate the data model when it is necessary to visit rows, thus preventing initializing view-scoped beans bound to ace:dataTable components that haven't come into view yet This fix doesn't break ICE-9585 , as tested with attached welcomeICEfaces.xhtml modified version.
        Hide
        Carmen Cristurean added a comment -

        Verified ICEfaces4 trunk r 51397 with attached case, on MsEdge38, IE11, FF49, Chrome56 and Tomcat7.

        Show
        Carmen Cristurean added a comment - Verified ICEfaces4 trunk r 51397 with attached case, on MsEdge38, IE11, FF49, Chrome56 and Tomcat7.
        Hide
        Ken Fyten added a comment -

        Re-open to backport to the EE 3.3 maintenance branch.

        Show
        Ken Fyten added a comment - Re-open to backport to the EE 3.3 maintenance branch.
        Hide
        Arturo Zambrano added a comment -

        r51452: backported fix to the EE 3.3 maintenance branch.

        Show
        Arturo Zambrano added a comment - r51452: backported fix to the EE 3.3 maintenance branch.
        Hide
        Liana Munroe added a comment -

        Verified using attached test case and ICEfaces EE-3.3.0 maintenance branch r51455, Tomcat 8, MS edge, IE 11, 10, 9, 8, 7, FF 47, Chrome 57.

        Show
        Liana Munroe added a comment - Verified using attached test case and ICEfaces EE-3.3.0 maintenance branch r51455, Tomcat 8, MS edge, IE 11, 10, 9, 8, 7, FF 47, Chrome 57.
        Hide
        Ken Fyten added a comment -

        Resolved.

        Show
        Ken Fyten added a comment - Resolved.

          People

          • Assignee:
            Arturo Zambrano
            Reporter:
            Arran Mccullough
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: