ICEfaces
  1. ICEfaces
  2. ICE-11230

refactor locale support into ComponentUtils and remove from CoreRenderer Class

          Details

          • Type: Task Task
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 4.2.BETA
          • Fix Version/s: 4.2
          • Component/s: ACE-Components
          • Labels:
            None
          • Environment:
            jsf2 ace

            Description

            The CoreRenderer class is inherited by many of the components (makes sense if you put things like Ajax support in there and all components that support ace:ajax inherit). but the locale support is not used by all components and was Static, so moved it to the ComponentUtils class-> used by
            ColorEntry, DataTable, TableConfigPanel, as well as clientValidation.

              Activity

              Ascending order - Click to sort in descending order
              Judy Guglielmin created issue -
              Judy Guglielmin made changes -
              Field Original Value New Value
              Assignee Judy Guglielmin [ judy.guglielmin ]
              Hide
              Permalink
              Judy Guglielmin added a comment -

              rev 50374

              Show
              Judy Guglielmin added a comment - rev 50374
              Judy Guglielmin made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Hide
              Permalink
              Judy Guglielmin added a comment -

              remove commented out static methods from CoreRenderer

              Show
              Judy Guglielmin added a comment - remove commented out static methods from CoreRenderer
              Judy Guglielmin made changes -
              Resolution Fixed [ 1 ]
              Status Resolved [ 5 ] Reopened [ 4 ]
              Hide
              Permalink
              Judy Guglielmin added a comment -

              rev 50375 - removed commented out methods.

              Show
              Judy Guglielmin added a comment - rev 50375 - removed commented out methods.
              Hide
              Permalink
              Judy Guglielmin added a comment -

              rev 50375

              Show
              Judy Guglielmin added a comment - rev 50375
              Judy Guglielmin made changes -
              Status Reopened [ 4 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #50374 Fri Feb 03 15:01:46 MST 2017 judy.guglielmin ICE-11230
              Files Changed
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/clientValidator/LengthValidator.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/tableconfigpanel/TableConfigPanelRenderer.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/clientValidator/PatternValidator.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/datatable/DataTableRenderer.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/renderkit/CoreRenderer.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/clientValidator/DecimalValidator.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/clientValidator/ValueRangeValidator.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/clientValidator/RequiredValidator.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #50375 Fri Feb 03 15:05:08 MST 2017 judy.guglielmin ICE-11230
              Files Changed
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/renderkit/CoreRenderer.java
              Hide
              Permalink
              Judy Guglielmin added a comment -

              looks like mobile components have dependency here as well, so will have them use ComponentUtils as well.

              Show
              Judy Guglielmin added a comment - looks like mobile components have dependency here as well, so will have them use ComponentUtils as well.
              Judy Guglielmin made changes -
              Resolution Fixed [ 1 ]
              Status Resolved [ 5 ] Reopened [ 4 ]
              Hide
              Permalink
              Judy Guglielmin added a comment -

              rev 50376 remove dependency of dateSpinner to ace CoreRenderer (now uses ComponentUtils )

              Show
              Judy Guglielmin added a comment - rev 50376 remove dependency of dateSpinner to ace CoreRenderer (now uses ComponentUtils )
              Judy Guglielmin made changes -
              Status Reopened [ 4 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #50376 Fri Feb 03 16:03:15 MST 2017 judy.guglielmin ICE-11230 dateSpinner had dependency on ace CoreRenderer, so removed that and now it uses ComponentUtils as well.
              Files Changed
              Commit graph MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/component/datespinner/DateSpinnerRenderer.java
              Hide
              Permalink
              Carmen Cristurean added a comment - - edited

              Verified IF4 trunk r 50376 > showcase > dateSpinner in MsEdge38, Chrome55, FF49, IE11.
              Ran showcase > clientValidate*, dataTable, tableConfigPanel automated tests in Firefox49.

              Show
              Carmen Cristurean added a comment - - edited Verified IF4 trunk r 50376 > showcase > dateSpinner in MsEdge38, Chrome55, FF49, IE11. Ran showcase > clientValidate*, dataTable, tableConfigPanel automated tests in Firefox49.
              Ken Fyten made changes -
              Fix Version/s 4.2 [ 12870 ]
              Ken Fyten made changes -
              Security Private [ 10001 ]
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]

                People

                • Assignee:
                  Judy Guglielmin
                  Reporter:
                  Judy Guglielmin
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: