ICEfaces
  1. ICEfaces
  2. ICE-11216

Add HTML element "on*" passthru attributes to applicable ACE components

          Details

          • Type: Improvement Improvement
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: None
          • Fix Version/s: 4.2
          • Component/s: ACE-Components
          • Labels:
            None
          • Environment:
            ICEfaces 4, ACE components
          • Assignee Priority:
            P2
          • Affects:
            Documentation (User Guide, Ref. Guide, etc.)

            Description

            As of ICEfaces 4.1.1, only the ACE button components (ace:pushButton, ace:linkButton, ace:checkboxButton, ace:radioButton) support the common HTML element passthru attributes:

            onblur
            onchange
            onclick
            ondblclick
            onfocus
            onkeydown
            onkeypress
            onkeyup
            onmousedown
            onmousemove
            onmouseout
            onmouseover
            onmouseup
            onselect


            These same attributes should be added to the following additional ACE components where they are mostly applicable and feasible due to the design / layout of the components:

            autoCompleteEntry
            comboBox
            textEntry
            textAreaEntry
            maskedEntry
            panel
            selectMenu
            simpleSelectOneMenu
            themeSelect

              Activity

              Ascending order - Click to sort in descending order
              Ken Fyten created issue -
              Ken Fyten made changes -
              Field Original Value New Value
              Assignee Mircea Toma [ mircea.toma ]
              Fix Version/s 4.2 [ 12870 ]
              Affects Documentation (User Guide, Ref. Guide, etc.) [ 10003 ]
              Assignee Priority P2 [ 10011 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #50321 Mon Jan 23 19:26:33 MST 2017 mircea.toma ICE-11216 Added definitions for pass-through attributes. Modified renderer to make use of the defined attributes.
              Files Changed
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/textentry/TextEntryMeta.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/textareaentry/TextAreaEntryMeta.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/maskedentry/MaskedEntryMeta.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/simpleselectonemenu/SimpleSelectOneMenuRenderer.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/renderkit/CoreRenderer.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/themeselect/ThemeSelectRenderer.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/combobox/ComboBoxMeta.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/panel/PanelRenderer.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/panel/PanelMeta.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/themeselect/ThemeSelectMeta.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/selectmenu/SelectMenuRenderer.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/maskedentry/MaskedEntryRenderer.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/selectmenu/SelectMenuMeta.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/textareaentry/TextAreaEntryRenderer.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/autocompleteentry/AutoCompleteEntryMeta.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/autocompleteentry/AutoCompleteEntryRenderer.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/util/ComponentUtils.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/textentry/TextEntryRenderer.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/combobox/ComboBoxRenderer.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/simpleselectonemenu/SimpleSelectOneMenuMeta.java
              Hide
              Permalink
              Mircea Toma added a comment -

              Added definitions for pass-through attributes. Modified renderers to make use of the defined attributes.

              Show
              Mircea Toma added a comment - Added definitions for pass-through attributes. Modified renderers to make use of the defined attributes.
              Mircea Toma made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #50323 Tue Jan 24 06:41:43 MST 2017 mircea.toma ICE-11216 Removed unused methods.
              Files Changed
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/renderkit/CoreRenderer.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/util/ComponentUtils.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #50326 Tue Jan 24 07:34:30 MST 2017 mircea.toma ICE-11216 Refactor and simplify.
              Files Changed
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/selectmenu/SelectMenuRenderer.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/maskedentry/MaskedEntryRenderer.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/simpleselectonemenu/SimpleSelectOneMenuRenderer.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/themeselect/ThemeSelectRenderer.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/util/ComponentUtils.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/panel/PanelRenderer.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/combobox/ComboBoxRenderer.java
              Hide
              Permalink
              Mircea Toma added a comment -

              1) The events you mentioned don't make sense for those components. For example the panel cannot receive focus, so onblur and onfocus will never be fired. Also since those events do not bubble up the root element cannot be used to capture events fired by its children. Same thing is true for onselect, the HTML element that receives the event listeners for selectMenu will not fire that event type.

              As for simpleSelectMenu and themeSelect I added the "onselect" passthrough attribute.

              Show
              Mircea Toma added a comment - 1) The events you mentioned don't make sense for those components. For example the panel cannot receive focus, so onblur and onfocus will never be fired. Also since those events do not bubble up the root element cannot be used to capture events fired by its children. Same thing is true for onselect , the HTML element that receives the event listeners for selectMenu will not fire that event type. As for simpleSelectMenu and themeSelect I added the "onselect" passthrough attribute.
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #50331 Tue Jan 24 14:42:49 MST 2017 mircea.toma ICE-11216 Add "oonselect" pass-through attribute.
              Files Changed
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/themeselect/ThemeSelectMeta.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #50332 Tue Jan 24 14:46:09 MST 2017 mircea.toma ICE-11216 Add "onselect" passthrough attribute.
              Files Changed
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/simpleselectonemenu/SimpleSelectOneMenuMeta.java
              Hide
              Permalink
              Carmen Cristurean added a comment -

              Issue 1) is verified with IF4 trunk r50332; re-opening the JIRA for the issues 2) and 3) .

              Show
              Carmen Cristurean added a comment - Issue 1) is verified with IF4 trunk r50332; re-opening the JIRA for the issues 2) and 3) .
              Carmen Cristurean made changes -
              Resolution Fixed [ 1 ]
              Status Resolved [ 5 ] Reopened [ 4 ]
              Hide
              Permalink
              Mircea Toma added a comment - - edited

              2) a) b) c) d)
              3)
              Added passthrough attributes in the meta class to have them rendered. These atttributes were previously rendered by an older passthrough attribute rendering utility.

              Show
              Mircea Toma added a comment - - edited 2) a) b) c) d) 3) Added passthrough attributes in the meta class to have them rendered. These atttributes were previously rendered by an older passthrough attribute rendering utility.
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #50333 Wed Jan 25 14:59:52 MST 2017 mircea.toma ICE-11216 Added passthrough attributes that were previously rendered by older passthrough attribute rendering utility.
              Files Changed
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/textentry/TextEntryMeta.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/textentry/TextEntryRenderer.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #50334 Wed Jan 25 15:07:47 MST 2017 mircea.toma ICE-11216 Added passthrough attributes that were previously rendered by an older utility.
              Files Changed
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/textareaentry/TextAreaEntryMeta.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #50335 Wed Jan 25 15:09:50 MST 2017 mircea.toma ICE-11216 Removed unused methods.
              Files Changed
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/textentry/TextEntry.java
              Hide
              Permalink
              Mircea Toma added a comment -

              Modified ColorEntry and GraphicImage to stop using the old passthrough attribute utility. Fixed code generator to add @PassthroughAttributes annotation to base class when the meta class has the annotation as well. Removed unused PassThruAttributeWriter class.

              Show
              Mircea Toma added a comment - Modified ColorEntry and GraphicImage to stop using the old passthrough attribute utility. Fixed code generator to add @PassthroughAttributes annotation to base class when the meta class has the annotation as well. Removed unused PassThruAttributeWriter class.
              Mircea Toma made changes -
              Status Reopened [ 4 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #50336 Wed Jan 25 15:37:51 MST 2017 mircea.toma ICE-11216 Modified ColorEntry and GraphicImage to stop using the old passthrough attribute utility. Fixed code generator to add PassthroughAttributes annotation to base class when the meta class has the annotation as well. Removed unused PassThruAttributeWriter.
              Files Changed
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/datetimeentry/DateTimeEntryRenderer.java
              Commit graph DEL /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/util/PassThruAttributeWriter.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/maskedentry/MaskedEntryRenderer.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/colorentry/ColorEntryRenderer.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/graphicimage/GraphicImageMeta.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/textareaentry/TextAreaEntryRenderer.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/generator/src/org/icefaces/ace/generator/artifacts/ComponentArtifact.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/graphicimage/GraphicImageRenderer.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #50337 Wed Jan 25 15:45:51 MST 2017 mircea.toma ICE-11216 Remove unused fields and methods. Add back url field.
              Files Changed
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/graphicimage/GraphicImage.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/graphicimage/GraphicImageMeta.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #50342 Thu Jan 26 09:51:03 MST 2017 mircea.toma ICE-11216 Replaced mechanism for rendering pass-through attributes.
              Files Changed
              Commit graph MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/component/flipswitch/FlipSwitchRenderer.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/component/pagepanel/PagePanelRenderer.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/component/pagepanel/PagePanel.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/component/datespinner/DateSpinnerRenderer.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/component/timespinner/TimeSpinner.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/component/deviceresource/DeviceResourceRenderer.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/component/timespinner/TimeSpinnerRenderer.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/component/flipswitch/FlipSwitch.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/component/datespinner/DateSpinner.java
              Hide
              Permalink
              Carmen Cristurean added a comment -

              Verified issues 2) and 3) with ICEfaces4 trunk r50347 in Chrome, FF49, MsEdge, IE11.

              Show
              Carmen Cristurean added a comment - Verified issues 2) and 3) with ICEfaces4 trunk r50347 in Chrome, FF49, MsEdge, IE11.
              Hide
              Permalink
              Carmen Cristurean added a comment - - edited

              ICEfaces4 trunk r 50347:
              Verified showcase > colorEntry in FF49.
              Ran QA regressions for ace:graphicImage in Chrome/FF49, the style attribute testing fails: the style cannot be changed dynamically on the ace:graphicImage.
              This is not an issue with IF4 Trunk Jenkins Build# 2328.

              QA test app:
              http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces4/Sparkle/Nightly/graphicImage
              Test page: /graphicImageDynAttribute.jsf

              Show
              Carmen Cristurean added a comment - - edited ICEfaces4 trunk r 50347: Verified showcase > colorEntry in FF49. Ran QA regressions for ace:graphicImage in Chrome/FF49, the style attribute testing fails: the style cannot be changed dynamically on the ace:graphicImage. This is not an issue with IF4 Trunk Jenkins Build# 2328. QA test app: http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces4/Sparkle/Nightly/graphicImage Test page: /graphicImageDynAttribute.jsf
              Carmen Cristurean made changes -
              Resolution Fixed [ 1 ]
              Status Resolved [ 5 ] Reopened [ 4 ]
              Security Private [ 10001 ]
              Hide
              Permalink
              Mircea Toma added a comment -

              Added "style" pass-through attribute for the graphicImage component. Removed the component defined attribute with the same name, the renderer does not handle it specifically.

              Show
              Mircea Toma added a comment - Added "style" pass-through attribute for the graphicImage component. Removed the component defined attribute with the same name, the renderer does not handle it specifically.
              Mircea Toma made changes -
              Status Reopened [ 4 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #50349 Mon Jan 30 13:09:52 MST 2017 mircea.toma ICE-11216 Added "style" pass-through attribute. Removed the component defined attribute with the same name, the renderer does not handle it specifically.
              Files Changed
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/graphicimage/GraphicImageMeta.java
              Hide
              Permalink
              Carmen Cristurean added a comment -

              Verified ICEfaces4 trunk r 50349 in IE11, MsEdge38, Chrome55, FF49 by running QA ace:graphicImage regressions.

              Show
              Carmen Cristurean added a comment - Verified ICEfaces4 trunk r 50349 in IE11, MsEdge38, Chrome55, FF49 by running QA ace:graphicImage regressions.
              Ken Fyten made changes -
              Security Private [ 10001 ]
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]

                People

                • Assignee:
                  Mircea Toma
                  Reporter:
                  Ken Fyten
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: