ICEfaces
  1. ICEfaces
  2. ICE-11216

Add HTML element "on*" passthru attributes to applicable ACE components

          Details

          • Type: Improvement Improvement
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: None
          • Fix Version/s: 4.2
          • Component/s: ACE-Components
          • Labels:
            None
          • Environment:
            ICEfaces 4, ACE components
          • Assignee Priority:
            P2
          • Affects:
            Documentation (User Guide, Ref. Guide, etc.)

            Description

            As of ICEfaces 4.1.1, only the ACE button components (ace:pushButton, ace:linkButton, ace:checkboxButton, ace:radioButton) support the common HTML element passthru attributes:

            onblur
            onchange
            onclick
            ondblclick
            onfocus
            onkeydown
            onkeypress
            onkeyup
            onmousedown
            onmousemove
            onmouseout
            onmouseover
            onmouseup
            onselect


            These same attributes should be added to the following additional ACE components where they are mostly applicable and feasible due to the design / layout of the components:

            autoCompleteEntry
            comboBox
            textEntry
            textAreaEntry
            maskedEntry
            panel
            selectMenu
            simpleSelectOneMenu
            themeSelect

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              Mircea Toma added a comment -

              Added definitions for pass-through attributes. Modified renderers to make use of the defined attributes.

              Show
              Mircea Toma added a comment - Added definitions for pass-through attributes. Modified renderers to make use of the defined attributes.
              Hide
              Permalink
              Mircea Toma added a comment -

              1) The events you mentioned don't make sense for those components. For example the panel cannot receive focus, so onblur and onfocus will never be fired. Also since those events do not bubble up the root element cannot be used to capture events fired by its children. Same thing is true for onselect, the HTML element that receives the event listeners for selectMenu will not fire that event type.

              As for simpleSelectMenu and themeSelect I added the "onselect" passthrough attribute.

              Show
              Mircea Toma added a comment - 1) The events you mentioned don't make sense for those components. For example the panel cannot receive focus, so onblur and onfocus will never be fired. Also since those events do not bubble up the root element cannot be used to capture events fired by its children. Same thing is true for onselect , the HTML element that receives the event listeners for selectMenu will not fire that event type. As for simpleSelectMenu and themeSelect I added the "onselect" passthrough attribute.
              Hide
              Permalink
              Carmen Cristurean added a comment -

              Issue 1) is verified with IF4 trunk r50332; re-opening the JIRA for the issues 2) and 3) .

              Show
              Carmen Cristurean added a comment - Issue 1) is verified with IF4 trunk r50332; re-opening the JIRA for the issues 2) and 3) .
              Hide
              Permalink
              Mircea Toma added a comment - - edited

              2) a) b) c) d)
              3)
              Added passthrough attributes in the meta class to have them rendered. These atttributes were previously rendered by an older passthrough attribute rendering utility.

              Show
              Mircea Toma added a comment - - edited 2) a) b) c) d) 3) Added passthrough attributes in the meta class to have them rendered. These atttributes were previously rendered by an older passthrough attribute rendering utility.
              Hide
              Permalink
              Mircea Toma added a comment -

              Modified ColorEntry and GraphicImage to stop using the old passthrough attribute utility. Fixed code generator to add @PassthroughAttributes annotation to base class when the meta class has the annotation as well. Removed unused PassThruAttributeWriter class.

              Show
              Mircea Toma added a comment - Modified ColorEntry and GraphicImage to stop using the old passthrough attribute utility. Fixed code generator to add @PassthroughAttributes annotation to base class when the meta class has the annotation as well. Removed unused PassThruAttributeWriter class.
              Hide
              Permalink
              Carmen Cristurean added a comment -

              Verified issues 2) and 3) with ICEfaces4 trunk r50347 in Chrome, FF49, MsEdge, IE11.

              Show
              Carmen Cristurean added a comment - Verified issues 2) and 3) with ICEfaces4 trunk r50347 in Chrome, FF49, MsEdge, IE11.
              Hide
              Permalink
              Carmen Cristurean added a comment - - edited

              ICEfaces4 trunk r 50347:
              Verified showcase > colorEntry in FF49.
              Ran QA regressions for ace:graphicImage in Chrome/FF49, the style attribute testing fails: the style cannot be changed dynamically on the ace:graphicImage.
              This is not an issue with IF4 Trunk Jenkins Build# 2328.

              QA test app:
              http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces4/Sparkle/Nightly/graphicImage
              Test page: /graphicImageDynAttribute.jsf

              Show
              Carmen Cristurean added a comment - - edited ICEfaces4 trunk r 50347: Verified showcase > colorEntry in FF49. Ran QA regressions for ace:graphicImage in Chrome/FF49, the style attribute testing fails: the style cannot be changed dynamically on the ace:graphicImage. This is not an issue with IF4 Trunk Jenkins Build# 2328. QA test app: http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces4/Sparkle/Nightly/graphicImage Test page: /graphicImageDynAttribute.jsf
              Hide
              Permalink
              Mircea Toma added a comment -

              Added "style" pass-through attribute for the graphicImage component. Removed the component defined attribute with the same name, the renderer does not handle it specifically.

              Show
              Mircea Toma added a comment - Added "style" pass-through attribute for the graphicImage component. Removed the component defined attribute with the same name, the renderer does not handle it specifically.
              Hide
              Permalink
              Carmen Cristurean added a comment -

              Verified ICEfaces4 trunk r 50349 in IE11, MsEdge38, Chrome55, FF49 by running QA ace:graphicImage regressions.

              Show
              Carmen Cristurean added a comment - Verified ICEfaces4 trunk r 50349 in IE11, MsEdge38, Chrome55, FF49 by running QA ace:graphicImage regressions.

                People

                • Assignee:
                  Mircea Toma
                  Reporter:
                  Ken Fyten
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: