[ICE-11174] Modify generator for tlddoc to include passthrough attributes on components already supporting them - ICEsoft JIRA Issue Tracker

Details

Type: Improvement
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: EE-4.1.0.GA, EE-3.3.0.GA_P04
Fix Version/s: 4.2
Component/s: ACE-Components
Labels:
None
Environment:
jsf2 ace generator

Assignee Priority:
P1
ICEsoft Forum Reference:
http://www.icesoft.org/JForum/posts/list/23225.page#81057
Affects:

Documentation (User Guide, Ref. Guide, etc.)

Description

The currently generated tlddocs do not include passthrough attributes for components which support passthrough attributes. For example ace:pushButton does not show that the "onclick", "onblur" etc attributes are supported.

See h:commandButton tlddoc:-
https://docs.oracle.com/cd/E17802_01/j2ee/javaee/javaserverfaces/2.0/docs/pdldocs/facelets/

<ace:pushButton> <ace:linkButton> <ace:textEntry> are three such components.

Activity

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#50017	Fri Jan 13 16:12:55 MST 2017	mircea.toma	~~ICE-11174~~ Added back @Inherited attribute to the PassthroughAttributes annotation.
				Files Changed
				MODIFY /icefaces4/trunk/icefaces/core/src/main/java/org/icefaces/component/PassthroughAttributes.java

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#50016	Thu Jan 12 17:44:13 MST 2017	mircea.toma	~~ICE-11174~~ Move PassthroughAttributes into core to avoid circular dependency between code generation and components. Add tlddoc and javadocs fields to the annotation so that it can be modified when it is used.
				Files Changed
				MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/radiobutton/RadioButtonRenderer.java MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/pushbutton/PushButtonMeta.java DEL /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/PassthroughAttributes.java MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/checkboxbutton/CheckboxButtonMeta.java ADD /icefaces4/trunk/icefaces/core/src/main/java/org/icefaces/component/PassthroughAttributes.java MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/radiobutton/RadioButtonMeta.java MODIFY /icefaces4/trunk/icefaces/ace/generator/src/org/icefaces/ace/generator/artifacts/ComponentArtifact.java MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/linkbutton/LinkButtonMeta.java MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/pushbutton/PushButtonRenderer.java MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/linkbutton/LinkButtonRenderer.java MODIFY /icefaces4/trunk/icefaces/ace/generator/src/org/icefaces/ace/generator/context/MetaContext.java MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/checkboxbutton/CheckboxButtonRenderer.java

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#50015	Thu Jan 12 17:24:16 MST 2017	mircea.toma	~~ICE-11174~~ Updated components that pass attributes through to use the annotations.
				Files Changed
				MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/radiobutton/RadioButtonRenderer.java MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/pushbutton/PushButtonMeta.java MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/checkboxbutton/CheckboxButtonMeta.java MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/radiobutton/RadioButtonMeta.java MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/linkbutton/LinkButtonMeta.java MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/pushbutton/PushButtonRenderer.java MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/linkbutton/LinkButtonRenderer.java MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/checkboxbutton/CheckboxButtonRenderer.java

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#50014	Thu Jan 12 16:50:58 MST 2017	mircea.toma	~~ICE-11174~~ Introduce PassthroughAttributes annotation to specify the list of component attributes that are passed through as HTML attributes by the renderer. Modify component and tld generators to make use of the annotation.
				Files Changed
				ADD /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/PassthroughAttributes.java MODIFY /icefaces4/trunk/icefaces/ace/generator/src/org/icefaces/ace/generator/xmlbuilder/FaceletTagLibBuilder.java MODIFY /icefaces4/trunk/icefaces/ace/generator/src/org/icefaces/ace/generator/utils/PropertyValues.java MODIFY /icefaces4/trunk/icefaces/ace/generator/src/org/icefaces/ace/generator/artifacts/ComponentArtifact.java MODIFY /icefaces4/trunk/icefaces/ace/generator/src/org/icefaces/ace/generator/context/MetaContext.java

Modify generator for tlddoc to include passthrough attributes on components already supporting them

Details

Description

Activity

People

Dates