Arturo Zambrano added a comment - 23/May/17 3:31 PM r51550: added filtering capabilities to ace:list, including all the features and modes already supported by ace:dataTable

Arturo Zambrano added a comment - 25/May/17 1:25 PM r51560: added sorting capabilities to ace:list

Ken Fyten added a comment - 25/May/17 3:18 PM Please add suitable showcase demos for these new features.

Liana Munroe added a comment - 26/May/17 1:32 PM - edited As of ICEfaces 4 r51560 (Jenkins continuous IF 4 trunk build 2558) most ace:list apps throw an NPE when making selections or dragging. This can be seen in all showcase ace:list, listControl and listExporter demos. Server log: 26-May-2017 13:12:37.022 WARNING [http-apr-8080-exec-6] com.sun.faces.lifecycle. UpdateModelValuesPhase.execute java.lang.NullPointerException 26-May-2017 13:12:42.295 SEVERE [http-apr-8080-exec-9] com.sun.faces.context.Aja xExceptionHandlerImpl.handlePartialResponseError java.lang.NullPointerException at org.icefaces.ace.util.ComponentUtils.resolveField(ComponentUtils.java :121) at org.icefaces.ace.model.table.SortCriteria.<init>(SortCriteria.java:36 ) at org.icefaces.ace.component.list.ACEList.getSortCriteria(ACEList.java: 504) at org.icefaces.ace.component.list.ACEList.processSorting(ACEList.java:4 87) at org.icefaces.ace.component.list.ACEList.processUpdates(ACEList.java:3 45) at javax.faces.component.UIComponentBase.processUpdates(UIComponentBase. java:1291) at javax.faces.component.UIComponentBase.processUpdates(UIComponentBase. java:1291) at javax.faces.component.UIForm.processUpdates(UIForm.java:281) at javax.faces.component.UIComponentBase.processUpdates(UIComponentBase. java:1291) at javax.faces.component.UIComponentBase.processUpdates(UIComponentBase. java:1291) at org.icefaces.ace.component.panel.Panel.processUpdates(Panel.java:131) at javax.faces.component.UIComponentBase.processUpdates(UIComponentBase. java:1291) at javax.faces.component.UIComponentBase.processUpdates(UIComponentBase. java:1291) at javax.faces.component.UIComponentBase.processUpdates(UIComponentBase. java:1291) at javax.faces.component.UIComponentBase.processUpdates(UIComponentBase. java:1291) at javax.faces.component.UIComponentBase.processUpdates(UIComponentBase. java:1291) at javax.faces.component.UIViewRoot.processUpdates(UIViewRoot.java:1254) at com.sun.faces.lifecycle.UpdateModelValuesPhase.execute(UpdateModelVal uesPhase.java:78) at com.sun.faces.lifecycle.Phase.doPhase(Phase.java:101) at com.sun.faces.lifecycle.LifecycleImpl.execute(LifecycleImpl.java:198) at javax.faces.webapp.FacesServlet.service(FacesServlet.java:658) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(Appl icationFilterChain.java:292) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationF ilterChain.java:207) at org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52 ) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(Appl icationFilterChain.java:240) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationF ilterChain.java:207) at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperV alve.java:212) at org.apache.catalina.core.StandardContextValve.invoke(StandardContextV alve.java:106) at org.apache.catalina.authenticator.AuthenticatorBase.invoke(Authentica torBase.java:502) at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.j ava:141) at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.j ava:79) at org.apache.catalina.valves.AbstractAccessLogValve.invoke(AbstractAcce ssLogValve.java:616) at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineVal ve.java:88) at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.jav a:522) at org.apache.coyote.http11.AbstractHttp11Processor.process(AbstractHttp 11Processor.java:1095) at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process( AbstractProtocol.java:672) at org.apache.tomcat.util.net.AprEndpoint$SocketProcessor.doRun(AprEndpo int .java:2500) at org.apache.tomcat.util.net.AprEndpoint$SocketProcessor.run(AprEndpoin t.java:2489) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor. java:1145) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor .java:615) at org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskTh read.java:61) at java.lang. Thread .run( Thread .java:745)

Arturo Zambrano added a comment - 26/May/17 2:23 PM r51567: fixed positioning of sort controls r51568: ace:list sorting and filtering demos

Arturo Zambrano added a comment - 26/May/17 2:52 PM r51569: fix to prevent NPEs, by making more explicit checks to see if sorting is taking place

Liana Munroe added a comment - 29/May/17 10:07 AM Tested with ICEfaces 4 trunk r51569. Tomcat 8, Chrome 57, FF 47, IE 11. NPEs are no longer found however an issue was revealed which started at r51550. All instances of ace:list reordering fail upon the second reorder submit. This can be seen in any of the showcase demos that use reordering with a list of return values. To reproduce: Use showcase demo ace:list > Reordering Select the top item in the list and then the down arrow. Press submit, the list to the right is reordered properly. Press the down arrow again and then submit. The list is not updated.

Arturo Zambrano added a comment - 30/May/17 11:35 AM r51572: fix for reordering issue

Liana Munroe added a comment - 31/May/17 9:59 AM Tested with ICEfaces 4 trunk r51577, tomcat 8, Chrome 57, IE 11, FF 47. Verified that reordering issue is resolved however this fix introduces an issue with list sorting. When using the showcase demo ace:list > Sorting, the list of selections is no longer sort-able. This issue was not present in IF 4 trunk r51571. To reproduce: Use the showcase ace:list > Sorting demo CTrl + Click to select 4 list items then submit selection to create the new list. The original list remains sort-able but the new list can not be sorted.

Arturo Zambrano added a comment - 08/Jun/17 11:44 AM r51606: fixed issues with sorting and reordering; added sort and filter ajax events

Liana Munroe added a comment - 09/Jun/17 2:29 PM Verified ICEfaces 4 trunk r51622, Tomcat 8, MS Edge, IE 11, 10, 9, 8, FF 47, Chrome 57.

Ken Fyten added a comment - 15/Jun/17 11:21 AM - edited Review Notes Sorting The sort header arrow behaviour should match that of the ace:dataTable sort arrows. Specifically: Clicking anywhere in the header should toggle the current sort order. When an arrow has focus, keyboard spacebar should activate/toggle the sort. Filtering From an aesthetics point of view I think the demo would be clearer/nicer if we just sized the example so there was only 1 item in each row (single column). Make the list scrollable so the page height doesn't get too long. Even whitespace around the filter field on all sides. Can we use the dataset from the ace:dataTable filtering demo? That would provide more matches for each chassis type.

Ken Fyten added a comment - 15/Jun/17 11:21 AM Re-opened for review notes.

Arturo Zambrano added a comment - 15/Jun/17 2:51 PM r51646: clicking anywhere in the header will toggle the current sort order; when an arrow has focus, keyboard spacebar or enter will activate/toggle the sort; added some whitespace to the top of the filter field to make it look more even an all sides

Arturo Zambrano added a comment - 15/Jun/17 3:14 PM r51647: modified ace:list > Filtering demo to display all items in one column; changed data set to that of ace:dataTable > Filtering demo to display more results; made list scrollable

Arturo Zambrano added a comment - 15/Jun/17 3:27 PM r51648: a more thorough adjustment to even out the whitespace around the filter field

Liana Munroe added a comment - 16/Jun/17 10:13 AM Verified ICEfaces 4 trunk r51657, Tomcat 8, MS Edge, IE 11, 10, 9, 8, FF 47, Chrome 59.

Ken Fyten added a comment - 16/Jun/17 11:36 AM New changes look good. Can you add a col-header label to the ace:list sorting and filtering demos?

Arturo Zambrano added a comment - 22/Jun/17 1:53 PM - edited r51686: added header and footer facets in Meta class; fixed issue with footer facet only showing when the header facet is specified r51687: added list headers to sorting and filtering demos

Liana Munroe added a comment - 27/Jun/17 2:27 PM Verified showcase demo ICEfaces 4 trunk r51693, Tomcat 8, MS Edge, IE 11, 10, 9, 8, FF 47, Chrome 59.

Ken Fyten added a comment - 28/Jun/17 12:53 PM Re-opened to backport to EE 3.3. maintenance branch.

Arturo Zambrano added a comment - 04/Jul/17 3:24 PM r51706: backported filtering and sorting capabilities to the EE 3.3 maintenance branch Note that range filtering is not supported in the 3.3 branch (either in ace:dataTable or in ace:list). All the other filtering and sorting features were successfully backported.

Liana Munroe added a comment - 09/Aug/17 11:22 AM Please add ace:list sort/filter demos to EE-3.3.0 showcase.

Arturo Zambrano added a comment - 10/Aug/17 5:45 PM r51824: corrected namespaces in demo r51825: added window. prefix to widgetVar for resolving it correctly

Liana Munroe added a comment - 11/Aug/17 9:33 AM Verified ICEfaces EE-3.3.0 maintenance branch r51826