ICEfaces
  1. ICEfaces
  2. ICE-11123

Support using buttonGroup with none-nested buttons via "group" attribute

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.2.BETA, 4.2
    • Component/s: ACE-Components, Sample Apps
    • Labels:
      None
    • Environment:
      ICEfaces 4.x
    • Assignee Priority:
      P2
    • Affects:
      Sample App./Tutorial

      Description

      The original intention for ace:buttonGroup was to support two distinct modes of operation:
      1. Directly nested child checkboxButton and radioButton components.
      2. None-nested buttons via specifying the id of a buttonGroup in the "group" attribute of radioButton/checkboxButton.

      The 1st (nested) scenario has been working since ICEfaces 4.0, but the 2nd (none-nested) scenario has not worked until now.

        Activity

        Ken Fyten created issue -
        Ken Fyten made changes -
        Field Original Value New Value
        Assignee Judy Guglielmin [ judy.guglielmin ]
        Fix Version/s 4.2 [ 12870 ]
        Affects Sample App./Tutorial [ 10001 ]
        Ken Fyten made changes -
        Assignee Priority P2 [ 10011 ]
        Judy Guglielmin made changes -
        Assignee Judy Guglielmin [ judy.guglielmin ] Ken Fyten [ ken.fyten ]
        Judy Guglielmin made changes -
        Assignee Ken Fyten [ ken.fyten ] Judy Guglielmin [ judy.guglielmin ]
        Hide
        Judy Guglielmin added a comment -

        rev 49344 has two new examples plus code to support the buttonGroup that can be used before the buttons on the page (from any location).
        Note that the number of rows is something for QA to copy to their tests and then should be removed from the showcase example.

        Show
        Judy Guglielmin added a comment - rev 49344 has two new examples plus code to support the buttonGroup that can be used before the buttons on the page (from any location). Note that the number of rows is something for QA to copy to their tests and then should be removed from the showcase example.
        Judy Guglielmin made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #49344 Thu Oct 06 13:41:21 MDT 2016 judy.guglielmin ICE-11123 clean up examples and take label attribute off of checkboxButton so it renders as a checkbox. remove reference to all in one group.
        Files Changed
        Commit graph MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/buttonGroup/buttonGroupDataTableColumn.xhtml
        Commit graph MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/java/org/icefaces/samples/showcase/example/ace/buttonGroup/ButtonGroupDataTable.java
        Commit graph MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/buttonGroup/buttonGroupByRow.xhtml
        Commit graph MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/resources/org/icefaces/samples/showcase/view/resources/messages.properties
        Hide
        Judy Guglielmin added a comment -

        found an unused attribute I added when first starting this work so cleaning it up.

        Show
        Judy Guglielmin added a comment - found an unused attribute I added when first starting this work so cleaning it up.
        Judy Guglielmin made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Hide
        Judy Guglielmin added a comment -

        rev 49345

        Show
        Judy Guglielmin added a comment - rev 49345
        Judy Guglielmin made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #49345 Thu Oct 06 14:06:05 MDT 2016 judy.guglielmin ICE-11123 remove unused meta attribute
        Files Changed
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/radiobutton/RadioButtonMeta.java
        Ken Fyten made changes -
        Summary Add new ace:buttonPanel demo to showcase for non-nested use-case Support using buttonGroup with none-nested buttons via "group" attribute
        Ken Fyten made changes -
        Description The current Showcase demo for the ace:buttonGroup component only shows the use-case where all the child ace:radiobutton or ace:checkboxbutton components are nested inside the buttonGroup.

        We should add another demo that illustrates using the ace:buttonGroup with the child components outside of the buttonGroup, but associated with it via their "group" attribute.
        The original intention for ace:buttonGroup was to support two distinct modes of operation:
        1. Directly nested child checkboxButton and radioButton components.
        2. None-nested buttons via specifying the id of a buttonGroup in the "group" attribute of radioButton/checkboxButton.

        The 1st (nested) scenario has been working since ICEfaces 4.0, but the 2nd (none-nested) scenario has not worked until now.
        Hide
        Liana Munroe added a comment - - edited

        Tested with ICEfaces 4 trunk r49346, Tomcat 7/8 WIndows7, FF 47, Chrome 53, IE 11.
        Added QA test applications /ICE-11123.jsf and /ICE-11123-2.jsf to:
        http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces4/Sparkle/Nightly/buttonGroup.

        In the QA test applications and the showcase demos the 500 and 1000 row dataTables performed poorly.
        The loading of 500 rows took ~6 seconds. Each selection of a checkbox or radioButton took > 1 second.
        -The loading of 1000 rows was only accomplished with Chrome browser, taking about 20 seconds. FF and IE both locked up with long running script errors. See attached screen shot. Making a radioButton or checkboxButton selection can take from 4 to 15 seconds depending on the browser.

        Show
        Liana Munroe added a comment - - edited Tested with ICEfaces 4 trunk r49346, Tomcat 7/8 WIndows7, FF 47, Chrome 53, IE 11. Added QA test applications / ICE-11123 .jsf and / ICE-11123 -2.jsf to: http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces4/Sparkle/Nightly/buttonGroup . In the QA test applications and the showcase demos the 500 and 1000 row dataTables performed poorly. The loading of 500 rows took ~6 seconds. Each selection of a checkbox or radioButton took > 1 second. -The loading of 1000 rows was only accomplished with Chrome browser, taking about 20 seconds. FF and IE both locked up with long running script errors. See attached screen shot. Making a radioButton or checkboxButton selection can take from 4 to 15 seconds depending on the browser.
        Liana Munroe made changes -
        Attachment Script.PNG [ 22313 ]
        Judy Guglielmin made changes -
        Security Private [ 10001 ]
        Hide
        Judy Guglielmin added a comment -

        need to remove QA tests from showcase example

        Show
        Judy Guglielmin added a comment - need to remove QA tests from showcase example
        Judy Guglielmin made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Hide
        Judy Guglielmin added a comment -

        rev 49588...removed ability to change number of rows in examples of column and row. (they are now in QA tests)

        Show
        Judy Guglielmin added a comment - rev 49588...removed ability to change number of rows in examples of column and row. (they are now in QA tests)
        Judy Guglielmin made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #49588 Mon Nov 28 15:23:14 MST 2016 judy.guglielmin ICE-11123 removed the dynamic number of rows to examples (now in QA tests)
        Files Changed
        Commit graph MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/buttonGroup/buttonGroupDataTableColumn.xhtml
        Commit graph MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/java/org/icefaces/samples/showcase/example/ace/buttonGroup/ButtonGroupDataTable.java
        Commit graph MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/buttonGroup/buttonGroupByRow.xhtml
        Commit graph MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/java/org/icefaces/samples/showcase/example/ace/buttonGroup/ButtonGroupRow.java
        Ken Fyten made changes -
        Fix Version/s 4.2.BETA [ 13091 ]
        Ken Fyten made changes -
        Security Private [ 10001 ]
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Judy Guglielmin
            Reporter:
            Ken Fyten
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: