[ICE-11098] Support building ICEfaces using JDK 1.8 - ICEsoft JIRA Issue Tracker

Details

Type: Task
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: None
Fix Version/s: EE-3.3.0.GA_P04
Component/s: Release
Labels:
None
Environment:
ICEfaces EE 3.3.0.GA

Affects:

Documentation (User Guide, Ref. Guide, etc.), Compatibility/Configuration

Description

Due to the change in JDK 1.8 that forces the Javadoc doLint inspection to be enabled by default the current ICEfaces ant builds will fail at the javadoc target when compiled with JDK 1.8.

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Ken Fyten added a comment - 08/Jul/16 4:39 PM - edited

Added optional system property for use with ant command line to disable the javadoc doclint when wanting to compile with JDK 1.8. Not required otherwise.

Commit for icefaces EE 3.3 maintenance branches (files have also been committed to the ICEfaces EE 3.3.0.GA_P04 tag):

[16:41:07] - svn commit -m "ICE-11098 - Added new optional parameter for turning off javadoc doclints ("ant -DwithDoclint=true etc...") which must be set to for javadoc targets to work on Java 1.8." 2 packets
[16:41:07] - Committing packet 1 of 2
[16:41:08] - Sending        /Users/Ken/Code/svn/icefaces-ee3-trunk/icefaces-ee/build.xml
[16:41:08] - Sending        /Users/Ken/Code/svn/icefaces-ee3-trunk/icefaces-ee/ee-comps/ee-accessible/components/build.xml
[16:41:08] - Sending        /Users/Ken/Code/svn/icefaces-ee3-trunk/icefaces-ee/ee-comps/ee-composite/build.xml
[16:41:08] - Transmitting file data...
[16:41:08] - Committed revision 45261.

[16:41:08] - Committing packet 2 of 2
[16:41:09] - Sending        /Users/Ken/Code/svn/icefaces-ee3-trunk/icefaces-ee/icefaces/ace/component/build.xml
[16:41:09] - Sending        /Users/Ken/Code/svn/icefaces-ee3-trunk/icefaces-ee/icefaces/build.xml
[16:41:09] - Sending        /Users/Ken/Code/svn/icefaces-ee3-trunk/icefaces-ee/icefaces/compat/components/build.xml
[16:41:09] - Sending        /Users/Ken/Code/svn/icefaces-ee3-trunk/icefaces-ee/icefaces/compat/core/build.xml
[16:41:09] - Sending        /Users/Ken/Code/svn/icefaces-ee3-trunk/icefaces-ee/icefaces/core/build.xml
[16:41:09] - Sending        /Users/Ken/Code/svn/icefaces-ee3-trunk/icefaces-ee/icepush-ee/core/build.xml
[16:41:12] - Committed revision 49038.

Show

Ken Fyten added a comment - 08/Jul/16 4:39 PM - edited Added optional system property for use with ant command line to disable the javadoc doclint when wanting to compile with JDK 1.8. Not required otherwise. Commit for icefaces EE 3.3 maintenance branches (files have also been committed to the ICEfaces EE 3.3.0.GA_P04 tag): [16:41:07] - svn commit -m "ICE-11098 - Added new optional parameter for turning off javadoc doclints (" ant -DwithDoclint= true etc... ") which must be set to for javadoc targets to work on Java 1.8." 2 packets [16:41:07] - Committing packet 1 of 2 [16:41:08] - Sending /Users/Ken/Code/svn/icefaces-ee3-trunk/icefaces-ee/build.xml [16:41:08] - Sending /Users/Ken/Code/svn/icefaces-ee3-trunk/icefaces-ee/ee-comps/ee-accessible/components/build.xml [16:41:08] - Sending /Users/Ken/Code/svn/icefaces-ee3-trunk/icefaces-ee/ee-comps/ee-composite/build.xml [16:41:08] - Transmitting file data... [16:41:08] - Committed revision 45261. [16:41:08] - Committing packet 2 of 2 [16:41:09] - Sending /Users/Ken/Code/svn/icefaces-ee3-trunk/icefaces-ee/icefaces/ace/component/build.xml [16:41:09] - Sending /Users/Ken/Code/svn/icefaces-ee3-trunk/icefaces-ee/icefaces/build.xml [16:41:09] - Sending /Users/Ken/Code/svn/icefaces-ee3-trunk/icefaces-ee/icefaces/compat/components/build.xml [16:41:09] - Sending /Users/Ken/Code/svn/icefaces-ee3-trunk/icefaces-ee/icefaces/compat/core/build.xml [16:41:09] - Sending /Users/Ken/Code/svn/icefaces-ee3-trunk/icefaces-ee/icefaces/core/build.xml [16:41:09] - Sending /Users/Ken/Code/svn/icefaces-ee3-trunk/icefaces-ee/icepush-ee/core/build.xml [16:41:12] - Committed revision 49038.

Hide

Permalink

Ken Fyten added a comment - 08/Jul/16 4:41 PM

The icefaces core bundle ant build now completes successfully using JDK 1.8 with the "ant -DwithDoclint=false" specified. However, the icefaces-ee composite components bundle build is failing with the following compilation error (jdk 1.8 specific):

    [javac] /Users/Ken/Code/svn/icefaces-ee3-trunk/icefaces-ee/bundle/ICEfaces-EE-3.3.0.GA_P04-SNAPSHOT-bin/ee-comps/ee-composite/src/com/icesoft/faces/facelets/component/table/autosort/SortableDataModel.java:83: error: cannot access Transformer
    [javac]                     Object prop1 = transformer.transform(o1);
    [javac]                                               ^
    [javac]   class file for org.apache.commons.collections.Transformer not found

Show

Ken Fyten added a comment - 08/Jul/16 4:41 PM The icefaces core bundle ant build now completes successfully using JDK 1.8 with the "ant -DwithDoclint=false" specified. However, the icefaces-ee composite components bundle build is failing with the following compilation error (jdk 1.8 specific): [javac] /Users/Ken/Code/svn/icefaces-ee3-trunk/icefaces-ee/bundle/ICEfaces-EE-3.3.0.GA_P04-SNAPSHOT-bin/ee-comps/ee-composite/src/com/icesoft/faces/facelets/component/table/autosort/SortableDataModel.java:83: error: cannot access Transformer [javac] Object prop1 = transformer.transform(o1); [javac] ^ [javac] class file for org.apache.commons.collections.Transformer not found

Hide

Permalink

Judy Guglielmin added a comment - 14/Jul/16 9:47 AM - edited

This is a direct result of removing commons-collections from the lib/compat folder (ICE_10843). Once it is re-instated, the build occurs fine. Interestingly enough, with JDK 1.6, this error does not occur, but with JDK 1.8 it does. ALthough the SortableDataModel in comps-ee library imports
import org.apache.commons.beanutils.BeanToPropertyValueTransformer
review of this class
https://commons.apache.org/proper/commons-beanutils/apidocs/org/apache/commons/beanutils/BeanToPropertyValueTransformer.html
shows it implements
implements org.apache.commons.collections.Transformer
Due to security reasons, will only ensure that the interface now becomes part of the ee-comps library, rather than re-stating the jar.

I also will commit changes to the builds which will automatically detect the java version and then will use the correct javadoc command based upon the java version detected. The -source property in the ant javadoc command is not respected (as it is in the javac command).

no command-line will further be required for javadoc once this commit is made.

Show

Judy Guglielmin added a comment - 14/Jul/16 9:47 AM - edited This is a direct result of removing commons-collections from the lib/compat folder (ICE_10843). Once it is re-instated, the build occurs fine. Interestingly enough, with JDK 1.6, this error does not occur, but with JDK 1.8 it does. ALthough the SortableDataModel in comps-ee library imports import org.apache.commons.beanutils.BeanToPropertyValueTransformer review of this class https://commons.apache.org/proper/commons-beanutils/apidocs/org/apache/commons/beanutils/BeanToPropertyValueTransformer.html shows it implements implements org.apache.commons.collections.Transformer Due to security reasons, will only ensure that the interface now becomes part of the ee-comps library, rather than re-stating the jar. I also will commit changes to the builds which will automatically detect the java version and then will use the correct javadoc command based upon the java version detected. The -source property in the ant javadoc command is not respected (as it is in the javac command). no command-line will further be required for javadoc once this commit is made.

Hide

Permalink

Judy Guglielmin added a comment - 14/Jul/16 12:25 PM

.for ee3:- rev 49049 and 45269. PLease test ee bundle creation with java 1.8 as well as java 1.6 or 1.7. (the builds should check and the javadoc will be run with correct parameters without adding any command line parameters)

Show

Judy Guglielmin added a comment - 14/Jul/16 12:25 PM .for ee3:- rev 49049 and 45269. PLease test ee bundle creation with java 1.8 as well as java 1.6 or 1.7. (the builds should check and the javadoc will be run with correct parameters without adding any command line parameters)

Hide

Permalink

Judy Guglielmin added a comment - 14/Jul/16 12:26 PM

re 49049 and 45269 for ee3.
IPCK-438 will contain similar fixes for ee4 and will resolve this for ee4 and open source builds.

Show

Judy Guglielmin added a comment - 14/Jul/16 12:26 PM re 49049 and 45269 for ee3. IPCK-438 will contain similar fixes for ee4 and will resolve this for ee4 and open source builds.

Hide

Permalink

Carmen Cristurean added a comment - 17/Jul/16 9:50 PM

Verified ICEfaces EE-3.3.0.GA_P04 Build #2 ant build ('clean.build.projects') and bundle creation ('bundle') with the following java versions:

java version "1.8.0_66"
Java(TM) SE Runtime Environment (build 1.8.0_66-b18)
Java HotSpot(TM) 64-Bit Server VM (build 25.66-b18, mixed mode)

java version "1.7.0_51"
Java(TM) SE Runtime Environment (build 1.7.0_51-b13)
Java HotSpot(TM) 64-Bit Server VM (build 24.51-b03, mixed mode)

java version "1.6.0_45"
Java(TM) SE Runtime Environment (build 1.6.0_45-b06)
Java HotSpot(TM) Client VM (build 20.45-b01, mixed mode, sharing)

Show

Carmen Cristurean added a comment - 17/Jul/16 9:50 PM Verified ICEfaces EE-3.3.0.GA_P04 Build #2 ant build ('clean.build.projects') and bundle creation ('bundle') with the following java versions: java version "1.8.0_66" Java(TM) SE Runtime Environment (build 1.8.0_66-b18) Java HotSpot(TM) 64-Bit Server VM (build 25.66-b18, mixed mode) java version "1.7.0_51" Java(TM) SE Runtime Environment (build 1.7.0_51-b13) Java HotSpot(TM) 64-Bit Server VM (build 24.51-b03, mixed mode) java version "1.6.0_45" Java(TM) SE Runtime Environment (build 1.6.0_45-b06) Java HotSpot(TM) Client VM (build 20.45-b01, mixed mode, sharing)

People

Assignee:

Judy Guglielmin

Reporter:

Ken Fyten

Votes:

0 Vote for this issue

Watchers:

3 Start watching this issue

Dates

Created:

08/Jul/16 3:56 PM

Updated:

13/Mar/17 1:32 PM

Resolved:

14/Jul/16 12:26 PM