ICEfaces
  1. ICEfaces
  2. ICE-109

BridgeFacesContext gets created twice in PersistentFacesServlet.service()

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.5
    • Fix Version/s: 1.6DR#1, 1.6
    • Component/s: Framework
    • Labels:
      None
    • Environment:
      Operating System: All
      Platform: All

      Description

      I dumped out a stack trace from the constructor for the BridgeFacesContext and noticed that it gets
      called twice for every call to the PersistentFacesServlet. I'm of the opinion we should know why we are
      doing this and either (a) document it or (b) fix it so that we avoid any unnecessary object creation.

      BridgeFacesContext: 1
      java.lang.Exception: Stack trace
              at java.lang.Thread.dumpStack()V(Unknown Source)
              at com.icesoft.faces.context.BridgeFacesContext.<init>(Ljavax.faces.context.ExternalContext;)V
      (BridgeFacesContext.java:31)
              at com.icesoft.faces.context.FacesContextFactoryImpl.getFacesContext
      (Ljava.lang.Object;Ljava.lang.Object;Ljava.lang.Object;Ljavax.faces.lifecycle.Lifecycle;)
      Ljavax.faces.context.FacesContext;(FacesContextFactoryImpl.java:51)
              at com.icesoft.faces.webapp.xmlhttp.PersistentFacesCommonlet.getFacesContext
      (Ljava.lang.Object;Ljava.lang.Object;Ljava.lang.Object;)Ljavax.faces.context.FacesContext;
      (PersistentFacesCommonlet.java:150)
              at com.icesoft.faces.webapp.xmlhttp.PersistentFacesServlet.service
      (Ljavax.servlet.ServletRequest;Ljavax.servlet.ServletResponse;)V(PersistentFacesServlet.java:110)
      ....
              

      BridgeFacesContext: 2
      java.lang.Exception: Stack trace
              at java.lang.Thread.dumpStack()V(Unknown Source)
              at com.icesoft.faces.context.BridgeFacesContext.<init>(Ljavax.faces.context.ExternalContext;)V
      (BridgeFacesContext.java:31)
              at com.icesoft.faces.webapp.xmlhttp.PersistentFacesServlet.setupPersistentContext
      (Ljavax.servlet.ServletContext;Ljavax.servlet.http.HttpServletRequest;)V(PersistentFacesServlet.java:233)
              at com.icesoft.faces.webapp.xmlhttp.PersistentFacesServlet.service
      (Ljavax.servlet.ServletRequest;Ljavax.servlet.ServletResponse;)V(PersistentFacesServlet.java:143)
      ...

        Activity

        There are no subversion log entries for this issue yet.

          People

          • Assignee:
            Unassigned
            Reporter:
            Deryk Sinotte
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: