ICEfaces
  1. ICEfaces
  2. ICE-109

BridgeFacesContext gets created twice in PersistentFacesServlet.service()

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.5
    • Fix Version/s: 1.6DR#1, 1.6
    • Component/s: Framework
    • Labels:
      None
    • Environment:
      Operating System: All
      Platform: All

      Description

      I dumped out a stack trace from the constructor for the BridgeFacesContext and noticed that it gets
      called twice for every call to the PersistentFacesServlet. I'm of the opinion we should know why we are
      doing this and either (a) document it or (b) fix it so that we avoid any unnecessary object creation.

      BridgeFacesContext: 1
      java.lang.Exception: Stack trace
              at java.lang.Thread.dumpStack()V(Unknown Source)
              at com.icesoft.faces.context.BridgeFacesContext.<init>(Ljavax.faces.context.ExternalContext;)V
      (BridgeFacesContext.java:31)
              at com.icesoft.faces.context.FacesContextFactoryImpl.getFacesContext
      (Ljava.lang.Object;Ljava.lang.Object;Ljava.lang.Object;Ljavax.faces.lifecycle.Lifecycle;)
      Ljavax.faces.context.FacesContext;(FacesContextFactoryImpl.java:51)
              at com.icesoft.faces.webapp.xmlhttp.PersistentFacesCommonlet.getFacesContext
      (Ljava.lang.Object;Ljava.lang.Object;Ljava.lang.Object;)Ljavax.faces.context.FacesContext;
      (PersistentFacesCommonlet.java:150)
              at com.icesoft.faces.webapp.xmlhttp.PersistentFacesServlet.service
      (Ljavax.servlet.ServletRequest;Ljavax.servlet.ServletResponse;)V(PersistentFacesServlet.java:110)
      ....
              

      BridgeFacesContext: 2
      java.lang.Exception: Stack trace
              at java.lang.Thread.dumpStack()V(Unknown Source)
              at com.icesoft.faces.context.BridgeFacesContext.<init>(Ljavax.faces.context.ExternalContext;)V
      (BridgeFacesContext.java:31)
              at com.icesoft.faces.webapp.xmlhttp.PersistentFacesServlet.setupPersistentContext
      (Ljavax.servlet.ServletContext;Ljavax.servlet.http.HttpServletRequest;)V(PersistentFacesServlet.java:233)
              at com.icesoft.faces.webapp.xmlhttp.PersistentFacesServlet.service
      (Ljavax.servlet.ServletRequest;Ljavax.servlet.ServletResponse;)V(PersistentFacesServlet.java:143)
      ...

        Activity

        Deryk Sinotte created issue -
        Icefaces Administrator made changes -
        Field Original Value New Value
        issue.field.bugzillaimportkey 110 11378
        made changes -
        Link This issue is duplicated by ICE-261 [ ICE-261 ]
        Ken Fyten made changes -
        Affects Version/s 1.5 [ 10027 ]
        Affects Version/s Alpha [ 10022 ]
        Ken Fyten made changes -
        Assignee Priority P2
        Assignee Ted Goddard [ ted.goddard ] Mircea Toma [ mircea.toma ]
        Mircea Toma made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Ken Fyten made changes -
        Fix Version/s 1.6DR#1 [ 10035 ]
        Fix Version/s 1.6 [ 10031 ]
        Ken Fyten made changes -
        Fix Version/s 1.6 [ 10031 ]
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Assignee Priority P2
        Assignee Mircea Toma [ mircea.toma ]

          People

          • Assignee:
            Unassigned
            Reporter:
            Deryk Sinotte
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: