ICEfaces
  1. ICEfaces
  2. ICE-10951

Difference in behavior of ace:ajax between ICEfaces 3.3 and ICEfaces 4.1.1

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 4.1
    • Fix Version/s: 4.1.1
    • Component/s: Framework
    • Labels:
      None
    • Environment:
      Liferay Portal 6.2
    • Assignee Priority:
      P1

      Description

      Steps to Reproduce:

      1. Deploy the attached icefaces3-portlet-3.0.0-SNAPSHOT.war to the Liferay Portal 6.2 /deploy folder

      2. Add a new page named ICE3

      3. Add the portlet named ICEfaces3 to the ICE3 portal page

      4. Re-render the ICE3 portal page

      5. Click the Submit button, and all of the form fields turn red/invalid except for the Date of Birth field

      6. In the ZIP Code field, type: 32801

      7. Press the TAB key on the keyboard in order to blur out of the ZIP code field

      8. Note that the City field contains "Orlando" and the "State" dropdown contains "FL"

      9. Repeat steps 1-7 for the attachment icefaces4-portlet-4.0.0-SNAPSHOT.war (using a paged named ICE4 instead of ICE3).

      If the bug is fixed, then the City field should contain "Orlando" and the "State" dropdown contains "FL"

      Otherwise, if the bug still exists, then the City field will not contain a value.

      Here is the source code for the [icefaces3-portlet|https://github.com/liferay/liferay-faces-bridge-impl/blob/3.x/demos/icefaces3-portlet] and [icefaces4-portlet|https://github.com/liferay/liferay-faces-bridge-impl/blob/4.x/demos/icefaces4-portlet/].

      Note that the code that triggers the XHR is [line#73 of applicant.xhtml|https://github.com/liferay/liferay-faces-bridge-impl/blob/4.x/demos/icefaces4-portlet/src/main/webapp/WEB-INF/views/applicant.xhtml#L73]:
      {code}
      <ace:ajax execute="@this" render="postalCodeField provinceIdField cityField" />
      {code}
      ... which simply calls a ValueChangeListener at [line#142 of ApplicantBackingBean.java|https://github.com/liferay/liferay-faces-bridge-impl/blob/4.x/demos/icefaces4-portlet/src/main/java/com/liferay/faces/demos/bean/ApplicantBackingBean.java#L142].

      It appears as though the {{cityField}} is not getting re-rendered, even though it is specified in the render attribute of {{ace:ajax}}.

        Activity

        Neil Griffin created issue -
        Neil Griffin made changes -
        Field Original Value New Value
        Attachment icefaces3-portlet-3.0.0-SNAPSHOT.war [ 22065 ]
        Neil Griffin made changes -
        Ken Fyten made changes -
        Assignee Mircea Toma [ mircea.toma ]
        Fix Version/s 4.1.1 [ 12972 ]
        Ken Fyten made changes -
        Assignee Priority P1 [ 10010 ]
        Hide
        Mircea Toma added a comment -

        Modified TextEntryRenderer to avoid rendering the submitted value when null even if the component is invalid. This change hopefully refines ICE-9146 fixes.

        Show
        Mircea Toma added a comment - Modified TextEntryRenderer to avoid rendering the submitted value when null even if the component is invalid. This change hopefully refines ICE-9146 fixes.
        Mircea Toma made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #47632 Fri Feb 12 15:04:56 MST 2016 mircea.toma ICE-10951 Avoid rendering the submitted value when null even if the component is invalid.
        Files Changed
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/textentry/TextEntryRenderer.java
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #47633 Fri Feb 12 16:21:11 MST 2016 ken.fyten ICE-10951 Avoid rendering the submitted value when null even if the component is invalid.
        Files Changed
        Commit graph MODIFY /icefaces4/branches/icefaces-4.1.1/icefaces/samples/showcase/showcase/src/main/webapp/WEB-INF/web.xml
        Commit graph MODIFY /icefaces4/branches/icefaces-4.1.1/icefaces/ace/component/src/org/icefaces/ace/component/textentry/TextEntryRenderer.java
        Hide
        Carmen Cristurean added a comment -

        All QA textEntry tests have been run on IF4 trunk r. 47632/ Jenkins ICEfaces 4.1.1 Build#5 on FF41, Chrome48, IE11.
        Note: one IE11 issue was found on Jenkins 4.1.1 build#5/EE-4.1.0 libs, but not on IF4 trunk r.47632, that was added to ICE-10965.

        Show
        Carmen Cristurean added a comment - All QA textEntry tests have been run on IF4 trunk r. 47632/ Jenkins ICEfaces 4.1.1 Build#5 on FF41, Chrome48, IE11. Note: one IE11 issue was found on Jenkins 4.1.1 build#5/EE-4.1.0 libs, but not on IF4 trunk r.47632, that was added to ICE-10965.
        Hide
        Carmen Cristurean added a comment - - edited

        Verified ICEfaces4 trunk r.47790 with attached test case (icefaces4-portlet-4.0.0-SNAPSHOT.war) on Liferay 6.2/Tomcat 7.0.42 on FF41.
        Test case fails on IF4 trunk r.47790 if replacing the "City" and "ZIP Code" textEntry components with textAreaEntry and maskedEntry components.

        Show
        Carmen Cristurean added a comment - - edited Verified ICEfaces4 trunk r.47790 with attached test case (icefaces4-portlet-4.0.0-SNAPSHOT.war) on Liferay 6.2/Tomcat 7.0.42 on FF41. Test case fails on IF4 trunk r.47790 if replacing the "City" and "ZIP Code" textEntry components with textAreaEntry and maskedEntry components.
        Hide
        Neil Griffin added a comment -

        Also verified.

        Show
        Neil Griffin added a comment - Also verified.
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Mircea Toma
            Reporter:
            Neil Griffin
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: