ICEfaces
  1. ICEfaces
  2. ICE-10939

Specifying a styleClass value in ace:pushButton makes it lose original look

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.3
    • Fix Version/s: 4.1.1
    • Component/s: ACE-Components
    • Labels:
      None
    • Environment:
      Any

      Description

      When specifying a styleClass value in ace:pushButton, the default value of the class attribute of the root div is replaced with the specified value instead of it being added to the default value, which is 'ice-pusbutton' and is necessary for all the related CSS to be applied to the button.

        Activity

        Arturo Zambrano created issue -
        Arturo Zambrano made changes -
        Field Original Value New Value
        Assignee Arturo Zambrano [ artzambrano ]
        Arturo Zambrano made changes -
        Fix Version/s 4.1.1 [ 12972 ]
        Hide
        Arturo Zambrano added a comment -

        r47059: fix to append specified styleClass to the default root CSS class

        Show
        Arturo Zambrano added a comment - r47059: fix to append specified styleClass to the default root CSS class
        Arturo Zambrano made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #47059 Tue Feb 02 11:38:53 MST 2016 art.zambrano ICE-10939 fix to append specified styleClass to the default root CSS class
        Files Changed
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/pushbutton/PushButtonRenderer.java
        Ken Fyten made changes -
        Affects Version/s 3.3 [ 10370 ]
        Affects Version/s 4.1 [ 11375 ]
        Hide
        Liana Munroe added a comment -

        Verified ICEfaces 4 trunk r47077. Tomcat 8, FF 43, Chrome 47, IE 11, 10, 9, 8.

        Show
        Liana Munroe added a comment - Verified ICEfaces 4 trunk r47077. Tomcat 8, FF 43, Chrome 47, IE 11, 10, 9, 8.
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #47088 Thu Feb 04 11:17:22 MST 2016 ken.fyten ICE-10926 - ace:pushButton, added 'submit' value to 'type’ attribute
        ICE-10939 - fix to append specified styleClass to the default root CSS class
        Files Changed
        Commit graph MODIFY /icefaces4/branches/icefaces-4.1.1/icefaces/ace/component/src/org/icefaces/ace/component/pushbutton/PushButtonMeta.java
        Commit graph MODIFY /icefaces4/branches/icefaces-4.1.1/icefaces/ace/component/resources/icefaces.ace/pushbutton/pushbutton.js
        Commit graph MODIFY /icefaces4/branches/icefaces-4.1.1/icefaces/ace/component/src/org/icefaces/ace/component/pushbutton/PushButtonRenderer.java
        Hide
        Carmen Cristurean added a comment -

        Verified Jenkins ICEfaces-4.1.1 Build#1 on IE8, IE11, Chrome48, FF41.

        Show
        Carmen Cristurean added a comment - Verified Jenkins ICEfaces-4.1.1 Build#1 on IE8, IE11, Chrome48, FF41.
        Hide
        Facio Fac added a comment -

        please suggest how can i change these java files and js files in my existing jars. i am using icefaces-4.1.1 latest as of this date but its not fixed in the download version.

        Thanks in Advance.

        Show
        Facio Fac added a comment - please suggest how can i change these java files and js files in my existing jars. i am using icefaces-4.1.1 latest as of this date but its not fixed in the download version. Thanks in Advance.
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Arturo Zambrano
            Reporter:
            Arturo Zambrano
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: