ICEfaces
  1. ICEfaces
  2. ICE-10926

ace:pushButton, restore capability to render a 'submit' type button

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 4.1
    • Fix Version/s: 4.1.1
    • Component/s: ACE-Components
    • Labels:
      None
    • Environment:
      Any

      Description

      After the ICE-10115 improvement, the 'type' attribute in ace:pushButton ceased to be a pass-thru attribute, which prevents users from being able to render a button of type 'submit', so that the browser handle the request natively. Moreover, in version 4.0, this was possible, but two requests were made instead of just one when using the 'submit' type. This JIRA is to restore the capability to render a button of type 'submit', while only doing one request when the button is activated.

        Activity

        Arturo Zambrano created issue -
        Arturo Zambrano made changes -
        Field Original Value New Value
        Assignee Arturo Zambrano [ artzambrano ]
        Arturo Zambrano made changes -
        Fix Version/s 4.1.1 [ 12972 ]
        Arturo Zambrano made changes -
        Hide
        Arturo Zambrano added a comment -

        r46969: ace:pushButton, added 'submit' value to 'type' attribute

        Also removed 'type' from the list of pass-thru attributes in the wiki entry for ace:pushButton.

        Show
        Arturo Zambrano added a comment - r46969: ace:pushButton, added 'submit' value to 'type' attribute Also removed 'type' from the list of pass-thru attributes in the wiki entry for ace:pushButton.
        Arturo Zambrano made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #46969 Tue Jan 12 14:45:04 MST 2016 art.zambrano ICE-10926 ace:pushButton, added 'submit' value to 'type' attribute
        Files Changed
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/pushbutton/PushButtonMeta.java
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/pushbutton/pushbutton.js
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/pushbutton/PushButtonRenderer.java
        Hide
        Liana Munroe added a comment - - edited

        Verified ICEfaces 4 trunk r46970. Tomcat 8, FF 43, Chrome 47, IE 11, 10, 9, 8.
        All the mentioned browsers except IE 8 offer to remember the form fields.
        QA test app /pushButtonTypeSubmit.jsf was added to:
        C:\svn\repo\qa\trunk\Regression-Icefaces4\Sparkle\Nightly\pushButton

        Show
        Liana Munroe added a comment - - edited Verified ICEfaces 4 trunk r46970. Tomcat 8, FF 43, Chrome 47, IE 11, 10, 9, 8. All the mentioned browsers except IE 8 offer to remember the form fields. QA test app /pushButtonTypeSubmit.jsf was added to: C:\svn\repo\qa\trunk\Regression-Icefaces4\Sparkle\Nightly\pushButton
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #47088 Thu Feb 04 11:17:22 MST 2016 ken.fyten ICE-10926 - ace:pushButton, added 'submit' value to 'type’ attribute
        ICE-10939 - fix to append specified styleClass to the default root CSS class
        Files Changed
        Commit graph MODIFY /icefaces4/branches/icefaces-4.1.1/icefaces/ace/component/src/org/icefaces/ace/component/pushbutton/PushButtonMeta.java
        Commit graph MODIFY /icefaces4/branches/icefaces-4.1.1/icefaces/ace/component/resources/icefaces.ace/pushbutton/pushbutton.js
        Commit graph MODIFY /icefaces4/branches/icefaces-4.1.1/icefaces/ace/component/src/org/icefaces/ace/component/pushbutton/PushButtonRenderer.java
        Hide
        Carmen Cristurean added a comment -

        Verified Jenkins ICEfaces-4.1.1 Build#1 with the QA /pushButtonTypeSubmit.jsf test on IE11, Chrome48, FF41.

        Show
        Carmen Cristurean added a comment - Verified Jenkins ICEfaces-4.1.1 Build#1 with the QA /pushButtonTypeSubmit.jsf test on IE11, Chrome48, FF41.
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Arturo Zambrano
            Reporter:
            Arturo Zambrano
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: