ICEfaces
  1. ICEfaces
  2. ICE-10897

Support for Client-side Validators with "immediate=true" during ace:ajax submits

          Details

            Description

            Client validators currently only support the use of "immediate=true" for full (none ace:ajax) submits.

            This JIRA is to extend support for "immediate=true" to cases where ace:ajax is specified.

            Integration with *:ajax behaviours that have immediate=true needs to be handled by the component renderers. Having a generic solution is not possible in this case. Only the renderers know about what event types are available and how they match to the DOM events and elements.

              Activity

              Ascending order - Click to sort in descending order
              Ken Fyten created issue -
              Ken Fyten made changes -
              Field Original Value New Value
              Fix Version/s EE-4.1.0.GA [ 12171 ]
              Hide
              Permalink
              Mircea Toma added a comment -

              Implemented generic strategy to support "immediate=true" attributes defined on f:ajax or ace:ajax facets.

              Show
              Mircea Toma added a comment - Implemented generic strategy to support "immediate=true" attributes defined on f:ajax or ace:ajax facets.
              Mircea Toma made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Ken Fyten made changes -
              Fix Version/s 4.1 [ 11375 ]
              Fix Version/s EE-4.1.0.GA [ 12171 ]
              Ken Fyten made changes -
              Assignee Mircea Toma [ mircea.toma ]
              Ken Fyten made changes -
              Fix Version/s EE-4.1.0.GA [ 12171 ]
              Fix Version/s 4.1 [ 11375 ]
              Ken Fyten made changes -
              Fix Version/s 4.1 [ 11375 ]
              Fix Version/s EE-4.1.0.GA [ 12171 ]
              Ken Fyten made changes -
              Resolution Fixed [ 1 ]
              Status Resolved [ 5 ] Reopened [ 4 ]
              Hide
              Permalink
              Mircea Toma added a comment -

              Applied changes to 4.1 tag.

              Show
              Mircea Toma added a comment - Applied changes to 4.1 tag.
              Mircea Toma made changes -
              Status Reopened [ 4 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #46570 Thu Dec 17 13:01:14 MST 2015 mircea.toma ICE-10897 Implemented generic strategy to support 'immediate=true' attributes defined on f:ajax or ace:ajax facets.
              Files Changed
              Commit graph MODIFY /icefaces4/tags/icefaces-4.1.0/icefaces/ace/component/src/org/icefaces/ace/component/clientValidator/ImmediateComponentCollector.java
              Commit graph MODIFY /icefaces4/tags/icefaces-4.1.0/icefaces/ace/component/resources/icefaces.ace/clientvalidator/clientvalidator.js
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #46571 Thu Dec 17 14:58:33 MST 2015 mircea.toma ICE-10897 Define ice.submitFunction that keeps on pointing to jsf.ajax.request even when latter is overridden.
              Files Changed
              Commit graph MODIFY /icefaces4/trunk/icefaces/core/src/main/javascript/application.js
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #46572 Thu Dec 17 14:58:58 MST 2015 mircea.toma ICE-10897 Define ice.submitFunction that keeps on pointing to jsf.ajax.request even when latter is overridden.
              Files Changed
              Commit graph MODIFY /icefaces4/tags/icefaces-4.1.0/icefaces/core/src/main/javascript/application.js
              Ken Fyten made changes -
              Resolution Fixed [ 1 ]
              Status Resolved [ 5 ] Reopened [ 4 ]
              Ken Fyten made changes -
              Fix Version/s EE-4.1.0.GA [ 12171 ]
              Fix Version/s 4.1 [ 11375 ]
              Hide
              Permalink
              Liana Munroe added a comment - - edited

              Tested with ICEfaces 4 trunk / 4.1 tag r46574.
              Immediate=true with f:ajax and ace:pushButton or ace:linkButton functions correctly.
              When used with ace:ajax the actionListen is not called in the button if a clientValidator is blocking the submit.
              Updated test application /textEntryClientValidateLength6.jsf
              http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces4/Sparkle/Nightly/textEntry

              To reproduce:

              • Use the /textEntryClientValidateLength6.jsf test application
              • In the second form there is ace:textEntry2 which uses ace:ajax and immediate="true" within the Cancel Button.
              • Type one character into textEntry2 and press Submit. A validation message appears.
              • Press the Cancel Button, the validation message should be removed but is not and the page is not updated with "You pressed cancel".
              Show
              Liana Munroe added a comment - - edited Tested with ICEfaces 4 trunk / 4.1 tag r46574. Immediate=true with f:ajax and ace:pushButton or ace:linkButton functions correctly. When used with ace:ajax the actionListen is not called in the button if a clientValidator is blocking the submit. Updated test application /textEntryClientValidateLength6.jsf http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces4/Sparkle/Nightly/textEntry To reproduce: Use the /textEntryClientValidateLength6.jsf test application In the second form there is ace:textEntry2 which uses ace:ajax and immediate="true" within the Cancel Button. Type one character into textEntry2 and press Submit. A validation message appears. Press the Cancel Button, the validation message should be removed but is not and the page is not updated with "You pressed cancel".
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #46578 Thu Dec 17 16:26:07 MST 2015 mircea.toma ICE-10897 Revert changes for 4.1 release.
              Files Changed
              Commit graph MODIFY /icefaces4/tags/icefaces-4.1.0/icefaces/ace/component/src/org/icefaces/ace/component/clientValidator/ImmediateComponentCollector.java
              Commit graph MODIFY /icefaces4/tags/icefaces-4.1.0/icefaces/core/src/main/javascript/application.js
              Commit graph MODIFY /icefaces4/tags/icefaces-4.1.0/icefaces/ace/component/resources/icefaces.ace/clientvalidator/clientvalidator.js
              Hide
              Permalink
              Ken Fyten added a comment -

              We should also extend the test cases for this to include testing the ACE entry components with "immediate=true" and ace:ajax specified in the entry components. (for EE 4.1).

              Show
              Ken Fyten added a comment - We should also extend the test cases for this to include testing the ACE entry components with "immediate=true" and ace:ajax specified in the entry components. (for EE 4.1).
              Ken Fyten made changes -
              Fix Version/s 4.2 [ 12870 ]
              Fix Version/s EE-4.1.0.GA [ 12171 ]
              Hide
              Permalink
              Mircea Toma added a comment -

              Modified isImmediate function in clientvalidator.js to confirm component submission when there's no event type defined by ace:ajax facet.

              Show
              Mircea Toma added a comment - Modified isImmediate function in clientvalidator.js to confirm component submission when there's no event type defined by ace:ajax facet.
              Mircea Toma made changes -
              Status Reopened [ 4 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #48511 Mon Mar 14 18:23:18 MDT 2016 mircea.toma ICE-10897 Modified isImmediate function to confirm component submission when there's no event type defined by ace:ajax facet.
              Files Changed
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/clientvalidator/clientvalidator.js
              Hide
              Permalink
              Carmen Cristurean added a comment -

              Verified Liana's use case above with QA test app for textEntry > textEntryClientValidateLength6.jsf , on ICEfaces4 trunk r.48512, IE11, Chrome48, FF41.

              Show
              Carmen Cristurean added a comment - Verified Liana's use case above with QA test app for textEntry > textEntryClientValidateLength6.jsf , on ICEfaces4 trunk r.48512, IE11, Chrome48, FF41.
              Ken Fyten made changes -
              Fix Version/s EE-4.1.0.GA [ 12171 ]
              Fix Version/s 4.2 [ 12870 ]
              Ken Fyten made changes -
              Fix Version/s EE-4.1.0.BETA [ 13072 ]
              Ken Fyten made changes -
              Fix Version/s 4.2.BETA [ 13091 ]
              Fix Version/s 4.2 [ 12870 ]
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]

                People

                • Assignee:
                  Mircea Toma
                  Reporter:
                  Ken Fyten
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  4 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: