ICEfaces
  1. ICEfaces
  2. ICE-10849

ace:dataTable - Add styling for hovering over a selected row

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: EE-4.0.0.GA, EE-3.3.0.GA_P03
    • Fix Version/s: 4.1, EE-3.3.0.GA_P04
    • Component/s: ACE-Components
    • Labels:
      None
    • Environment:
      All

      Description

      Currently if you select a row and hover over the row, the styling doesn't indicate that it is selected. It maintains just the hover styling. This is evident with the default theme as well as many of the other ones.

      This feature request is to add new styling for hovering over a selected row. This will help differentiate between selected and non-selected row.

        Activity

        Arran Mccullough created issue -
        Arran Mccullough made changes -
        Field Original Value New Value
        Summary ace:dataTable - Add a styling for hovering over a selected row ace:dataTable - Add styling for hovering over a selected row
        Ken Fyten made changes -
        Assignee Arturo Zambrano [ artzambrano ]
        Fix Version/s 4.1 [ 11375 ]
        Fix Version/s EE-3.3.0.GA_P04 [ 12270 ]
        Priority Major [ 3 ] Minor [ 4 ]
        Assignee Priority P2 [ 10011 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #46285 Tue Nov 24 15:20:18 MST 2015 art.zambrano ICE-10849 ace:dataTable, added distinct styling for hovering over a selected row
        Files Changed
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/datatable/datatable.js
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/datatable/datatable.css
        Hide
        Arturo Zambrano added a comment -

        r46285: ace:dataTable, added distinct styling for hovering over a selected row.

        Since, Themeroller doesn't provide a distinct hover styling for an element that is already active and the styling used for warning messages just doesn't apply nicely to the data table, the new styling for hovering over selected rows is based on opacity. This way, it won't be necessary to modify all existing themes or to have to extend Themeroller. By using opacity, we make sure the styling is also noticeable on themes that use background images, as opposed to solid colours. The opacity is based on the active (selected) styling to signal that the row is already selected. Basing the opacity on the hover styling would make the colour too light in most themes and harder to distinguish.

        Show
        Arturo Zambrano added a comment - r46285: ace:dataTable, added distinct styling for hovering over a selected row. Since, Themeroller doesn't provide a distinct hover styling for an element that is already active and the styling used for warning messages just doesn't apply nicely to the data table, the new styling for hovering over selected rows is based on opacity. This way, it won't be necessary to modify all existing themes or to have to extend Themeroller. By using opacity, we make sure the styling is also noticeable on themes that use background images, as opposed to solid colours. The opacity is based on the active (selected) styling to signal that the row is already selected. Basing the opacity on the hover styling would make the colour too light in most themes and harder to distinguish.
        Hide
        Arturo Zambrano added a comment -

        r46286: committed fix to the 3.3 EE maintenance branch.

        Show
        Arturo Zambrano added a comment - r46286: committed fix to the 3.3 EE maintenance branch.
        Arturo Zambrano made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Liana Munroe added a comment -

        Verified ICEfaces 4 trunk, EE-3.3.0 maintenance branch r46287, Tomcat 7, IE 11, 10, 9, 8, 7, FF 34, Chrome 46.

        Show
        Liana Munroe added a comment - Verified ICEfaces 4 trunk, EE-3.3.0 maintenance branch r46287, Tomcat 7, IE 11, 10, 9, 8, 7, FF 34, Chrome 46.
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Arturo Zambrano
            Reporter:
            Arran Mccullough
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: