[ICE-10827] New ace:clientValidateEqualTo client-side validator - ICEsoft JIRA Issue Tracker

Details

Type: New Feature
Status: Closed
Priority: Major
Resolution: Won't Fix
Affects Version/s: None
Fix Version/s: 4.1
Component/s: ACE-Components
Labels:
None
Environment:
ICEfaces 4.1

Assignee Priority:
P1
Affects:

Documentation (User Guide, Ref. Guide, etc.), Sample App./Tutorial

Description

Add support for client-side validation that an input component's value is equivalent to another specified input components value.

Wraps the jQuery Validation min function in an ICEfaces / JSF friendly component.

---------------
Description: Requires the element to be the same as another one.

equalTo( other ) other Type: Selector
The selector for the element to compare the current values

Src: http://jqueryvalidation.org/equalTo-method
----------------

This validator should be supported by the following input components:

ACE
- ace:autoCompleteEntry
- ace:checkboxButton
- ace:checkboxButtons
- ace:comboBox
- ace:dateTimeEntry
- ace:maskedEntry
- ace:radioButton
- ace:radioButtons
- ace:richTextEntry
- ace:selectMenu
- ace:simpleSelectOneMenu
- ace:sliderEntry
- ace:textAreaEntry
- ace:textEntry

MOBI:
mobi:dateSpinner
mobi:timeSpinner
mobi:flipSwitch

Issue Links

blocks

ICE-5377 Support for client-side validators for ACE and MOBI input components

Closed

Activity

Ascending order - Click to sort in descending order

Ken Fyten created issue - 22/Oct/15 5:33 PM

Ken Fyten made changes - 22/Oct/15 5:36 PM

Field	Original Value	New Value
Description	Add support for client-side validation that an input component contains a minimum decimal value. Wraps the jQuery Validation min function in an ICEfaces / JSF friendly component. --------------- Description: Makes the element require a given minimum. min( value ) value Type: Number Minimum value required http://jqueryvalidation.org/min-method ---------------- This validator should be supported by the following input components: ACE - ace:autoCompleteEntry - ace:comboBox - ace:maskedEntry - ace:richTextEntry - ace:sliderEntry - ace:textAreaEntry - ace:textEntry	Add support for client-side validation that an input component's value is equivalent to another specified input components value. Wraps the jQuery Validation min function in an ICEfaces / JSF friendly component. --------------- Description: Requires the element to be the same as another one. equalTo( other ) other Type: Selector The selector for the element to compare the current values Src: http://jqueryvalidation.org/equalTo-method ---------------- This validator should be supported by the following input components: ACE - ace:autoCompleteEntry - ace:checkboxButton - ace:checkboxButtons - ace:comboBox - ace:dateTimeEntry - ace:maskedEntry - ace:radioButton - ace:radioButtons - ace:richTextEntry - ace:selectMenu - ace:simpleSelectOneMenu - ace:sliderEntry - ace:textAreaEntry - ace:textEntry MOBI: mobi:dateSpinner mobi:timeSpinner mobi:flipSwitch

Ken Fyten made changes - 22/Oct/15 5:36 PM

Link

This issue blocks ~~ICE-5377~~ [ ~~ICE-5377~~ ]

Ken Fyten made changes - 23/Oct/15 1:59 PM

Assignee Priority

P1 [ 10010 ]

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#46164	Mon Nov 02 15:27:37 MST 2015	mircea.toma	~~ICE-10827~~ Implemented ace:clientValidateEqualTo client-side validator.
				Files Changed
				ADD /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/clientValidator/EqualToValidator.java MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/resources/messages.properties ADD /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/clientValidator/EqualToValidatorMeta.java

Hide

Permalink

Mircea Toma added a comment - 02/Nov/15 3:30 PM

Implemented ace:clientValidateEqualTo client-side validator. The validated component can compared only to other Validateable component. When defined, the label of the other component will be used in the validation message as reference.

Show

Mircea Toma added a comment - 02/Nov/15 3:30 PM Implemented ace:clientValidateEqualTo client-side validator. The validated component can compared only to other Validateable component. When defined, the label of the other component will be used in the validation message as reference.

Mircea Toma made changes - 02/Nov/15 3:30 PM

Status	Open [ 1 ]	Resolved [ 5 ]
Resolution		Fixed [ 1 ]

Hide

Permalink

Liana Munroe added a comment - 04/Nov/15 2:33 PM

As per ~~ICE-5377~~ ace:sliderEntry and mobi:flipswitch will no longer be Validatetable.

Show

Liana Munroe added a comment - 04/Nov/15 2:33 PM As per ICE-5377 ace:sliderEntry and mobi:flipswitch will no longer be Validatetable.

Hide

Permalink

Ken Fyten added a comment - 05/Nov/15 4:01 PM

Upon review we've decided that ace:sliderEntry should be supported, can be compared to another component with an integer value.

Also, mobi:flipSwitch, ace:checkboxButton, and ace:radioButton could be comparables for this validator.

Show

Ken Fyten added a comment - 05/Nov/15 4:01 PM Upon review we've decided that ace:sliderEntry should be supported, can be compared to another component with an integer value. Also, mobi:flipSwitch, ace:checkboxButton, and ace:radioButton could be comparables for this validator.

Ken Fyten made changes - 05/Nov/15 4:01 PM

Resolution	Fixed [ 1 ]
Status	Resolved [ 5 ]	Reopened [ 4 ]

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#46195	Mon Nov 09 14:26:30 MST 2015	mircea.toma	~~ICE-10827~~ Make slider validateable once again.
				Files Changed
				MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/sliderentry/SliderEntry.java

Hide

Permalink

Mircea Toma added a comment - 09/Nov/15 2:26 PM

Made slider validateable once again.

Show

Mircea Toma added a comment - 09/Nov/15 2:26 PM Made slider validateable once again.

Mircea Toma made changes - 09/Nov/15 2:26 PM

Status	Reopened [ 4 ]	Resolved [ 5 ]
Resolution		Fixed [ 1 ]

Mircea Toma made changes - 09/Nov/15 2:28 PM

Resolution	Fixed [ 1 ]
Status	Resolved [ 5 ]	Reopened [ 4 ]

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#46196	Mon Nov 09 14:29:13 MST 2015	mircea.toma	~~ICE-10827~~ Make flipwitch validateable.
				Files Changed
				MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/component/flipswitch/FlipSwitch.java

Hide

Permalink

Mircea Toma added a comment - 09/Nov/15 2:29 PM

Made flipswitch component validateable as well.

Show

Mircea Toma added a comment - 09/Nov/15 2:29 PM Made flipswitch component validateable as well.

Mircea Toma made changes - 09/Nov/15 2:29 PM

Status	Reopened [ 4 ]	Resolved [ 5 ]
Resolution		Fixed [ 1 ]

Hide

Permalink

Liana Munroe added a comment - 12/Nov/15 1:31 PM - edited

Tested with ICEfaces 4 trunk r46213.
ace:sliderEntry and mobi:flipswitch using ace:clientValidateEqualTo are not functional. There are no messages rendered when the compared values differ.
Test applications at: /sliderEntryClientValidateEqualTo.jsf, /flipswitchClientValidateEqualTo.jsf
http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces4/Sparkle/Nightly/sliderEntry
http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces4/Sparkle/Manual/flipswitch

Also as mentioned in ~~ICE-5377~~, ace:radioButton, ace:checkboxButton, ace:comboBox, ace:selectMenu with ace:clientValidateEqualTo are also not functional. There are no messages rendered when the compared values differ.

Show

Liana Munroe added a comment - 12/Nov/15 1:31 PM - edited Tested with ICEfaces 4 trunk r46213. ace:sliderEntry and mobi:flipswitch using ace:clientValidateEqualTo are not functional. There are no messages rendered when the compared values differ. Test applications at: /sliderEntryClientValidateEqualTo.jsf, /flipswitchClientValidateEqualTo.jsf http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces4/Sparkle/Nightly/sliderEntry http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces4/Sparkle/Manual/flipswitch Also as mentioned in ICE-5377 , ace:radioButton, ace:checkboxButton, ace:comboBox, ace:selectMenu with ace:clientValidateEqualTo are also not functional. There are no messages rendered when the compared values differ.

Liana Munroe made changes - 12/Nov/15 1:32 PM

Resolution	Fixed [ 1 ]
Status	Resolved [ 5 ]	Reopened [ 4 ]

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#46226	Mon Nov 16 16:55:52 MST 2015	mircea.toma	~~ICE-10827~~ Modified renderer to satisfy jQuery validation constraints.
				Files Changed
				MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/radiobutton/RadioButtonRenderer.java MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/radiobutton/RadioButton.java MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/checkboxbutton/CheckboxButton.java MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/checkboxbutton/CheckboxButtonRenderer.java

Hide

Permalink

Mircea Toma added a comment - 16/Nov/15 4:58 PM - edited

Modified ace:radioButton and ace:checkboxButton renderers to satisfy jQuery validation constraints. Also fixed Validateable.getValidatedElementId method to point to the value holder element.

Show

Mircea Toma added a comment - 16/Nov/15 4:58 PM - edited Modified ace:radioButton and ace:checkboxButton renderers to satisfy jQuery validation constraints. Also fixed Validateable.getValidatedElementId method to point to the value holder element.

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#46228	Tue Nov 17 05:00:52 MST 2015	mircea.toma	~~ICE-10827~~ Modified renderer to satisfy jQuery validation requirements.
				Files Changed
				MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/component/flipswitch/FlipSwitchRenderer.java MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/sliderentry/SliderEntryRenderer.java

Hide

Permalink

Mircea Toma added a comment - 17/Nov/15 5:04 AM

Modified ace:sliderEntry and mobi:flipswitch renderers to satisfy jQuery validation constraints.
The test cases for these components should be modified so that the compared components are placed in separate forms. When the referenced component value is changed a submit should be issued, only when the validated component is modified the submit should be blocked. This approach will ensure that the state on the client is kept in sync with the one on the server.

Show

Mircea Toma added a comment - 17/Nov/15 5:04 AM Modified ace:sliderEntry and mobi:flipswitch renderers to satisfy jQuery validation constraints. The test cases for these components should be modified so that the compared components are placed in separate forms. When the referenced component value is changed a submit should be issued, only when the validated component is modified the submit should be blocked. This approach will ensure that the state on the client is kept in sync with the one on the server.

Hide

Permalink

Ken Fyten added a comment - 17/Nov/15 4:51 PM

Due to the state complexities inherent with using this validator type we've decided it's real-world usefulness is limited in terms of being a client-side validator and will be removing it from the 4.1 release.

Show

Ken Fyten added a comment - 17/Nov/15 4:51 PM Due to the state complexities inherent with using this validator type we've decided it's real-world usefulness is limited in terms of being a client-side validator and will be removing it from the 4.1 release.

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#46246	Thu Nov 19 11:48:40 MST 2015	mircea.toma	~~ICE-10827~~ Back off from implementing Validateable.
				Files Changed
				MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/radiobutton/RadioButtonRenderer.java MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/radiobutton/RadioButton.java MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/component/flipswitch/FlipSwitchRenderer.java MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/sliderentry/SliderEntry.java MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/checkboxbutton/CheckboxButton.java MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/sliderentry/SliderEntryRenderer.java MODIFY /icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/component/flipswitch/FlipSwitch.java MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/checkboxbutton/CheckboxButtonRenderer.java

Hide

Permalink

Mircea Toma added a comment - 19/Nov/15 11:48 AM - edited

Backed off from implementing Validateable for ace:sliderEntry, mobi:flipswitch, ace:checkboxButton and ace:radioButton.

Show

Mircea Toma added a comment - 19/Nov/15 11:48 AM - edited Backed off from implementing Validateable for ace:sliderEntry , mobi:flipswitch , ace:checkboxButton and ace:radioButton .

Hide

Permalink

Ken Fyten added a comment - 19/Nov/15 4:48 PM

The actual EqualTo validator code needs to be removed from the repo as well.

Show

Ken Fyten added a comment - 19/Nov/15 4:48 PM The actual EqualTo validator code needs to be removed from the repo as well.

Hide

Permalink

Mircea Toma added a comment - 25/Nov/15 11:36 AM

Removed ace:clientValidateEqualto validator due inherent state synchronization complexities in the context of JSF.

Show

Mircea Toma added a comment - 25/Nov/15 11:36 AM Removed ace:clientValidateEqualto validator due inherent state synchronization complexities in the context of JSF.

Mircea Toma made changes - 25/Nov/15 11:36 AM

Status	Reopened [ 4 ]	Resolved [ 5 ]
Resolution		Won't Fix [ 2 ]

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#46290	Wed Nov 25 11:37:12 MST 2015	mircea.toma	~~ICE-10827~~ Removed 'equalTo' validator due inherent state synchronization complexities in the context of JSF.
				Files Changed
				DEL /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/clientValidator/EqualToValidator.java DEL /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/clientValidator/EqualToValidatorMeta.java

Ken Fyten made changes - 13/Mar/17 1:33 PM

Status

Resolved [ 5 ]

Closed [ 6 ]

People

Assignee:

Mircea Toma

Reporter:

Ken Fyten

Votes:

0 Vote for this issue

Watchers:

3 Start watching this issue

Dates

Created:

22/Oct/15 5:33 PM

Updated:

13/Mar/17 1:33 PM

Resolved:

25/Nov/15 11:36 AM