ICEfaces
  1. ICEfaces
  2. ICE-10744

showcase - demos that use ace:messages not clearing errors

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 4.0
    • Fix Version/s: 4.1
    • Component/s: Sample Apps
    • Labels:
      None
    • Environment:
      ICEfaces4 trunk revision# 45077
      Server: tomcat7
      Browser: IE7, FF3.6/34 & Chrome43
      JSF: Mojarra 2.2.10
    • Assignee Priority:
      P2
    • Affects:
      Sample App./Tutorial

      Description

      The showcase demos that use a messages component to show errors (ace:messages) are not clearing these errors from the messages when the user navigates to another demo in the showcase. This is confusing for the user as the new demo renders with the old error messages from the previous demo.

      For example:

      showcase > FileEntry > Callback:
      When navigating to the Callback demo all messages generated on previous fileEntry demos are rendered inside a single message panel, like in attached screen shot.
      1. callback.PNG
        32 kB
      2. callback1.PNG
        19 kB

        Issue Links

          Activity

          Carmen Cristurean created issue -
          Carmen Cristurean made changes -
          Field Original Value New Value
          Attachment callback.PNG [ 20180 ]
          Ken Fyten made changes -
          Summary showcase - ace:fileEntry error messages on Callback demo showcase - demos that use ace:messages not clearing errors
          Assignee Judy Guglielmin [ judy.guglielmin ]
          Security Private [ 10001 ]
          Fix Version/s 4.1 [ 11375 ]
          Affects Version/s 4.0 [ 11382 ]
          Priority Major [ 3 ] Minor [ 4 ]
          Description showcase > FileEntry > Callback:
          When navigating to the Callback demo all messages generated on previous fileEntry demos are rendered inside a single message panel, like in attached screen shot.
          The showcase demos that use a messages component to show errors (ace:messages) are not clearing these errors from the messages when the user navigates to another demo in the showcase. This is confusing for the user as the new demo renders with the old error messages from the previous demo.

          For example:

          showcase > FileEntry > Callback:
          When navigating to the Callback demo all messages generated on previous fileEntry demos are rendered inside a single message panel, like in attached screen shot.
          Affects Sample App./Tutorial [ 10001 ]
          Assignee Priority P2 [ 10011 ]
          Component/s ACE-Components [ 10050 ]
          Ken Fyten made changes -
          Link This issue is duplicated by ICE-10534 [ ICE-10534 ]
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #46259 Fri Nov 20 16:26:25 MST 2015 judy.guglielmin ICE-10744. Used the <ace:message for="..with a unique id for each fileEntry example. No need to use ace:messages when there is a single component in the form. for the ace:messages and ace:growlMessages examples used <icecore:config messagePersistence="false"/> to clear the messages between the samples.
          Files Changed
          Commit graph MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/growlmessages/growlmessages.xhtml
          Commit graph MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/fileentry/fileentry.xhtml
          Commit graph MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/fileentry/fileEntryCallback.xhtml
          Commit graph MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/fileentry/fileEntryMultiple.xhtml
          Commit graph MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/fileentry/fileEntryValidation.xhtml
          Commit graph MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/fileentry/fileEntryFailpop.xhtml
          Commit graph MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/messages/messages.xhtml
          Commit graph MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/fileentry/fileEntryListener.xhtml
          Hide
          Judy Guglielmin added a comment -

          rev 46259
          note that the fileEntry examples all had the same id and so used <ace:message for="...." with a unique id for each example to ensure that the actual message (since the fileEntry is the only component on the form don't need ace:messages), is tied to a unique component id.
          For the growlMessages and ace:messages example use the following
          <icecore:config messagePersistence="false"/>
          to clear the messages between requests.

          Show
          Judy Guglielmin added a comment - rev 46259 note that the fileEntry examples all had the same id and so used <ace:message for="...." with a unique id for each example to ensure that the actual message (since the fileEntry is the only component on the form don't need ace:messages), is tied to a unique component id. For the growlMessages and ace:messages example use the following <icecore:config messagePersistence="false"/> to clear the messages between requests.
          Judy Guglielmin made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Hide
          Carmen Cristurean added a comment - - edited

          Re-opening because of regressions found on ICEfaces4 trunk r46259:
          1) showcase > fileEntry - Callback:
          The error message when trying to upload a .pdf file fails to explain what is wrong with the upload; it only prints the name of the file (see callback1.PNG attached).

          2) messages > Overview:
          When tabbing through the entries, only the last message is rendered (all browsers).

          Show
          Carmen Cristurean added a comment - - edited Re-opening because of regressions found on ICEfaces4 trunk r46259: 1) showcase > fileEntry - Callback: The error message when trying to upload a .pdf file fails to explain what is wrong with the upload; it only prints the name of the file (see callback1.PNG attached). 2) messages > Overview: When tabbing through the entries, only the last message is rendered (all browsers).
          Carmen Cristurean made changes -
          Resolution Fixed [ 1 ]
          Status Resolved [ 5 ] Reopened [ 4 ]
          Carmen Cristurean made changes -
          Attachment callback1.PNG [ 22001 ]
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #46278 Tue Nov 24 11:13:40 MST 2015 judy.guglielmin ICE-10744 added appropriate attributes to ace:message to get all info
          Files Changed
          Commit graph MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/fileentry/fileEntryCallback.xhtml
          Commit graph MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/fileentry/fileEntryValidation.xhtml
          Commit graph MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/fileentry/fileEntryFailpop.xhtml
          Commit graph MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/fileentry/fileEntryListener.xhtml
          Hide
          Judy Guglielmin added a comment -

          rev 46306

          Show
          Judy Guglielmin added a comment - rev 46306
          Judy Guglielmin made changes -
          Status Reopened [ 4 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #46306 Tue Dec 01 10:41:13 MST 2015 judy.guglielmin ICE-10744 added value "@inView" to "for" attribute to allow users to select messages for components only existing in the current view. Both ace:messages and ace:growlMessages now have this new feature.
          Files Changed
          Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/growlmessages/GrowlMessagesMeta.java
          Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/messages/MessagesMeta.java
          Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/growlmessages/GrowlMessagesRenderer.java
          Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/messages/MessagesRenderer.java
          Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/util/ComponentUtils.java
          Hide
          Carmen Cristurean added a comment -

          ICEfaces4 trunk r46307: issue 2) above can still be reproduced.

          Show
          Carmen Cristurean added a comment - ICEfaces4 trunk r46307: issue 2) above can still be reproduced.
          Hide
          Judy Guglielmin added a comment - - edited

          sorry. I had forgot to modify the showcase examples, so checked it in under ICE-10877 rev 46308, please update your showcase to that revision. (you may have tested the showcase without using the new value on the "for" attribute).

          Show
          Judy Guglielmin added a comment - - edited sorry. I had forgot to modify the showcase examples, so checked it in under ICE-10877 rev 46308, please update your showcase to that revision. (you may have tested the showcase without using the new value on the "for" attribute).
          Hide
          Carmen Cristurean added a comment -

          Verified on r46309 showcase > growlMessages, messages, fileEntry, no issues found (FF41, IE11, Chrome46).

          Show
          Carmen Cristurean added a comment - Verified on r46309 showcase > growlMessages, messages, fileEntry, no issues found (FF41, IE11, Chrome46).
          Ken Fyten made changes -
          Link This issue depends on ICE-10877 [ ICE-10877 ]
          Ken Fyten made changes -
          Status Resolved [ 5 ] Closed [ 6 ]

            People

            • Assignee:
              Judy Guglielmin
              Reporter:
              Carmen Cristurean
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: