ICEfaces
  1. ICEfaces
  2. ICE-10736

ace:simpleSelectOneMenu fails validation for noSelectionOption even when required="false"

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 4.0
          • Fix Version/s: 4.1
          • Component/s: ACE-Components
          • Labels:
            None
          • Environment:
            Any, tested with Emporium trunk
          • Assignee Priority:
            P2

            Description

            When using <f:selectItem noSelectionOption="true"> as a child of ace:simpleSelectOneMenu the validation will still fire (saying "Value is not valid") even if required="false" (or is not specified).

            This validation should ONLY fire when required="true", as per h:selectOneMenu.

              Activity

              Ascending order - Click to sort in descending order
              Carlo Guglielmin created issue -
              Carlo Guglielmin made changes -
              Field Original Value New Value
              Assignee Arturo Zambrano [ artzambrano ]
              Ken Fyten made changes -
              Fix Version/s 4.1 [ 11375 ]
              Assignee Priority P2 [ 10011 ]
              Hide
              Permalink
              Arturo Zambrano added a comment -

              This is actually working correctly right now, the same way as h:selectOneMenu. The only difference is that you need to specify a value to the selectItem that has noSelectionOption="true". It can just be the empty String.

              This JIRA will be redirected to cover the case when selectItems using noSelectionOption="true" have no value.

              Show
              Arturo Zambrano added a comment - This is actually working correctly right now, the same way as h:selectOneMenu. The only difference is that you need to specify a value to the selectItem that has noSelectionOption="true". It can just be the empty String. This JIRA will be redirected to cover the case when selectItems using noSelectionOption="true" have no value.
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #45099 Wed Jun 24 14:44:39 MDT 2015 art.zambrano ICE-10736 added logic to cover the case when noSelectionOption="true" and no value is specified in the SelectItem
              Files Changed
              Commit graph ADD /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/util/SelectUtils.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/simpleselectonemenu/SimpleSelectOneMenu.java
              Hide
              Permalink
              Arturo Zambrano added a comment -

              r45099: added logic to cover the case when noSelectionOption="true" and no value is specified in the SelectItem

              Testing Notes: Please test that when selecting a SelectItem that has noSelectionOption="true" a validation error is only fired when the component is required. The validation error shouldn't fire when the component is not required, regardless of whether the SelectItem has a value specified or not.

              Show
              Arturo Zambrano added a comment - r45099: added logic to cover the case when noSelectionOption="true" and no value is specified in the SelectItem Testing Notes: Please test that when selecting a SelectItem that has noSelectionOption="true" a validation error is only fired when the component is required. The validation error shouldn't fire when the component is not required, regardless of whether the SelectItem has a value specified or not.
              Arturo Zambrano made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Hide
              Permalink
              Carmen Cristurean added a comment -

              Verified with the QA test application, /noSelectionOptionTest.jsf with ICEfaces4 trunk revision 45251/ IE11, CHrome43, FF34.

              Show
              Carmen Cristurean added a comment - Verified with the QA test application, /noSelectionOptionTest.jsf with ICEfaces4 trunk revision 45251/ IE11, CHrome43, FF34.
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]

                People

                • Assignee:
                  Arturo Zambrano
                  Reporter:
                  Carlo Guglielmin
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: