ICEfaces
  1. ICEfaces
  2. ICE-10727

dataTable footer does not resize when rowEditor edit function is activated

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 4.0, EE-4.0.0.GA, EE-3.3.0.GA_P03
    • Fix Version/s: 4.1, EE-3.3.0.GA_P04
    • Component/s: ACE-Components
    • Labels:
      None
    • Environment:
      Tomcat 7, all browsers, ICEfaces 4 trunk r45004.
    • Assignee Priority:
      P2

      Description

      Scenario - a dataTable that has column resizing, a footer facet and ace:rowEditor/ace:cellEditor. When the edit function is activated, and the resulting editing view changes the dataTable width to match the rowEditor width, the footer does not resize to match the new dataTable width. Test apps (/views/cellEditFooter.jsf) located at:
      http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces2/Sparkle/Nightly/dataTable
      http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces4/Sparkle/Nightly/dataTable
      1. 1.PNG
        20 kB
      2. 2.PNG
        20 kB
      3. footer.PNG
        6 kB
      4. footer2.PNG
        21 kB
      5. footer-no-rows.PNG
        41 kB

        Activity

        Liana Munroe created issue -
        Liana Munroe made changes -
        Field Original Value New Value
        Attachment 1.PNG [ 19986 ]
        Attachment 2.PNG [ 19987 ]
        Liana Munroe made changes -
        Description Scenario - a dataTable that has column resizing, a footer facet and ace:rowEditor/ace:cellEditor. When the edit function is activated, and the resulting editing view changes the dataTable width to match the rowEditor width, the footer does not resize to match the new dataTable width. Scenario - a dataTable that has column resizing, a footer facet and ace:rowEditor/ace:cellEditor. When the edit function is activated, and the resulting editing view changes the dataTable width to match the rowEditor width, the footer does not resize to match the new dataTable width. Test apps (/views/cellEditFooter.jsf) located at:
        http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces2/Sparkle/Nightly/dataTable
        http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces4/Sparkle/Nightly/dataTable
        Ken Fyten made changes -
        Assignee Arturo Zambrano [ artzambrano ]
        Fix Version/s 4.1 [ 11375 ]
        Fix Version/s EE-3.3.0.GA_P04 [ 12270 ]
        Priority Major [ 3 ] Minor [ 4 ]
        Assignee Priority P2 [ 10011 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #45011 Thu Jun 11 12:23:59 MDT 2015 art.zambrano ICE-10727 added function to adjust the width of the footer to that of the table body when editing rows
        Files Changed
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/datatable/DataTableRenderer.java
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/datatable/datatable.js
        Hide
        Arturo Zambrano added a comment -

        Committed fix to the 4.1 trunk at revision 45011 and to the 3.3 EE maintenance branch at revision 45013. Added function to adjust the width of the footer to that of the table body when editing rows.

        Show
        Arturo Zambrano added a comment - Committed fix to the 4.1 trunk at revision 45011 and to the 3.3 EE maintenance branch at revision 45013. Added function to adjust the width of the footer to that of the table body when editing rows.
        Arturo Zambrano made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Liana Munroe added a comment -

        Tested with ICEfaces 4 trunk r45020 and EE-3.3.0 maintenance branch r 45023.
        When testing with ICEfaces 4 trunk the issue is resolved however after loading the demo the Footer is a slight bit less than the width of the table. See screen shot footer.PNG
        When testing with ICEfaces EE-3.3.0 maintenance branch the footer is the correct width after loading the demo but it still has the issue where it does not resize to table width when the cellEditor is in use. See screen shot footer2.PNG

        Show
        Liana Munroe added a comment - Tested with ICEfaces 4 trunk r45020 and EE-3.3.0 maintenance branch r 45023. When testing with ICEfaces 4 trunk the issue is resolved however after loading the demo the Footer is a slight bit less than the width of the table. See screen shot footer.PNG When testing with ICEfaces EE-3.3.0 maintenance branch the footer is the correct width after loading the demo but it still has the issue where it does not resize to table width when the cellEditor is in use. See screen shot footer2.PNG
        Liana Munroe made changes -
        Attachment footer.PNG [ 19988 ]
        Attachment footer2.PNG [ 19989 ]
        Liana Munroe made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Hide
        Mistah Mikey added a comment -

        This solves the issue I raised, but unfortunately, it causes a new one. After the footer is resized to match the expanded table width, it no longer will resize when you resize the browser window. The header resizes correctly (I raised an issue in the past about that not working, but now it appears to), but the footer stays the same size as when it was expanded.

        Show
        Mistah Mikey added a comment - This solves the issue I raised, but unfortunately, it causes a new one. After the footer is resized to match the expanded table width, it no longer will resize when you resize the browser window. The header resizes correctly (I raised an issue in the past about that not working, but now it appears to), but the footer stays the same size as when it was expanded.
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #45046 Tue Jun 16 15:24:49 MDT 2015 art.zambrano ICE-10727 adjusted width by 1
        Files Changed
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/datatable/datatable.js
        Hide
        Arturo Zambrano added a comment -

        r45045,r45046: fixed the issues reported by QA in the 4.0 trunk and the 3.3 EE maintenance branch.

        The width was adjusted by 1, and the table body selector was corrected in the 3.3 branch.

        Show
        Arturo Zambrano added a comment - r45045,r45046: fixed the issues reported by QA in the 4.0 trunk and the 3.3 EE maintenance branch. The width was adjusted by 1, and the table body selector was corrected in the 3.3 branch.
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #45087 Tue Jun 23 10:37:00 MDT 2015 art.zambrano ICE-10727 added event listener to adjust the dataTable footer width when the window is resized
        Files Changed
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/datatable/datatable.js
        Hide
        Arturo Zambrano added a comment -

        r45087, r45088: added event listener to adjust the dataTable footer width when the window is resized.

        Show
        Arturo Zambrano added a comment - r45087, r45088: added event listener to adjust the dataTable footer width when the window is resized.
        Arturo Zambrano made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Mistah Mikey made changes -
        Comment [ Still not there. FYI, in my footer, I do have a couple of h:panelGroups that contain a few components. Here is what I am experiencing. In my datatable, I have an edit control. Here is what I am seeing:

        1) First display of table - edit Control not enabled
            - footer is sized to about 1 pixel or so less than the current datatable width
            - footer does not resize when browser window is resized

        2) Edit Control is enabled
            - footer resizes to about 1 pixel or so less than the current datatable width
            - footer does not resize when browser window is resized

        3) Edit Control is disabled
            - same behavior as in (2)

        Let me know if I can provide any additional info. Unfortunately, the system on which I do development is not connected to the internet, nor can I remove software from the system, so I am unable to send you my code.
             ]
        Hide
        Mistah Mikey added a comment -

        Things are now working as expected from my end. Thanks very much.

        Show
        Mistah Mikey added a comment - Things are now working as expected from my end. Thanks very much.
        Hide
        Mistah Mikey added a comment -

        Today I discovered a new footer resize problem. When I delete the last row in the table (so now the table is empty), the table header stays the same size it was (all columns displayed), but the footer collapses to the left into a very small rectangle.

        Show
        Mistah Mikey added a comment - Today I discovered a new footer resize problem. When I delete the last row in the table (so now the table is empty), the table header stays the same size it was (all columns displayed), but the footer collapses to the left into a very small rectangle.
        Carmen Cristurean made changes -
        Attachment footer-no-rows.PNG [ 20182 ]
        Ken Fyten made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #45579 Tue Jul 07 14:04:02 MDT 2015 art.zambrano ICE-10727 fix to adjust width when there are no rows in the body
        Files Changed
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/datatable/datatable.js
        Hide
        Arturo Zambrano added a comment -

        r45579,r45580: committed fix to adjust width when there are no rows in the body, to the 4.1 trunk and the 3.3 EE maintenance branch.

        Show
        Arturo Zambrano added a comment - r45579,r45580: committed fix to adjust width when there are no rows in the body, to the 4.1 trunk and the 3.3 EE maintenance branch.
        Arturo Zambrano made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Liana Munroe added a comment -

        Verified ICEfaces 4 trunk, ee-3.3.0 maintenance branch r45580, Tomcat 7, IE 11, 10, 9, 8, 7 FF 34, Chrome 43.

        Show
        Liana Munroe added a comment - Verified ICEfaces 4 trunk, ee-3.3.0 maintenance branch r45580, Tomcat 7, IE 11, 10, 9, 8, 7 FF 34, Chrome 43.
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #51499 Tue May 09 14:26:01 MDT 2017 art.zambrano ICE-11292, ICE-10727 ace:dataTable, modified the adjust footer width function to allow making the footer shorter when resizing the window
        Files Changed
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/datatable/datatable.js

          People

          • Assignee:
            Arturo Zambrano
            Reporter:
            Liana Munroe
          • Votes:
            1 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: