ICEfaces
  1. ICEfaces
  2. ICE-10706

ace:fileEntry - Dynamic inclusion causing page refresh

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: EE-4.0.0.GA, EE-3.3.0.GA_P03
    • Fix Version/s: 4.1, EE-3.3.0.GA_P04
    • Component/s: ACE-Components
    • Labels:
      None
    • Environment:
      All
    • Assignee Priority:
      P1
    • Support Case References:
    • Workaround Exists:
      Yes
    • Workaround Description:
      Hide
       - Add an f:ajax tag to the commandButton.
       - Have the fileEntry component rendered initially.
       - Move the fileEntry include to its own form tag.
      Show
       - Add an f:ajax tag to the commandButton.  - Have the fileEntry component rendered initially.  - Move the fileEntry include to its own form tag.

      Description

      When dynamically including content that has an ace:fileEntry on a page and the user clicks a standard h:commandButton, a full page refresh/update is seen.

      This happens only if the fileEntry component is not on the page on the initial load but dynamically added. It also only happens for a button that doesn't use an f:ajax tag (<h:commandButton action="#{fileEntry.doNothing}" value="Do nothing" />). If the fileEntry component is removed from the page, the refresh behavior remains.

        Activity

        Arran Mccullough created issue -
        Hide
        Arran Mccullough added a comment -

        Attached test case that shows this issue.

        Steps:

        • Load welcomeICEfaces.jsf
        • Click on the first 'Do Nothing' button, no full page refresh is seen.
        • Click on the 'Toggle Included' button to show the fileEntry component.
        • Click on the first 'Do Nothing' button, a full page refresh is seen.
        Show
        Arran Mccullough added a comment - Attached test case that shows this issue. Steps: Load welcomeICEfaces.jsf Click on the first 'Do Nothing' button, no full page refresh is seen. Click on the 'Toggle Included' button to show the fileEntry component. Click on the first 'Do Nothing' button, a full page refresh is seen.
        Arran Mccullough made changes -
        Field Original Value New Value
        Attachment Case13433Example.war [ 19880 ]
        Attachment Case13433Example.zip [ 19881 ]
        Hide
        Arran Mccullough added a comment -

        Reported issue is resolved by adding the following context param:

        <context-param>
        <param-name>org.icefaces.mandatoryResourceConfiguration</param-name>
        <param-value>fileEntry</param-value>
        </context-param>

        Show
        Arran Mccullough added a comment - Reported issue is resolved by adding the following context param: <context-param> <param-name>org.icefaces.mandatoryResourceConfiguration</param-name> <param-value>fileEntry</param-value> </context-param>
        Arran Mccullough made changes -
        Status Open [ 1 ] Closed [ 6 ]
        Resolution Invalid [ 6 ]
        Hide
        Arran Mccullough added a comment -

        Re-opening issue. With fixes from ICE-10710 the issue can still be reproduced.

        Show
        Arran Mccullough added a comment - Re-opening issue. With fixes from ICE-10710 the issue can still be reproduced.
        Arran Mccullough made changes -
        Resolution Invalid [ 6 ]
        Status Closed [ 6 ] Reopened [ 4 ]
        Arran Mccullough made changes -
        Attachment Case13433Example.war [ 19880 ]
        Arran Mccullough made changes -
        Attachment Case13433Example.zip [ 19881 ]
        Hide
        Arran Mccullough added a comment -

        Attached new test case that shows this issue even with the mandatoryResourceConfiguration param set.

        Steps:

        • Load welcomeICEfaces.jsf
        • Click on the 'Toogle included (and render @form)' button. The fileEntry comp is now shown.
        • Click on the first 'Do nothing' Button, no issues seen.
        • Click on the 'Toogle included (and render @form)' button. The fileEntry compo is now hidden.
        • Click on the first 'Do nothing' Button, this time an unload/dispose event is fired and the page is refreshed.
        Show
        Arran Mccullough added a comment - Attached new test case that shows this issue even with the mandatoryResourceConfiguration param set. Steps: Load welcomeICEfaces.jsf Click on the 'Toogle included (and render @form)' button. The fileEntry comp is now shown. Click on the first 'Do nothing' Button, no issues seen. Click on the 'Toogle included (and render @form)' button. The fileEntry compo is now hidden. Click on the first 'Do nothing' Button, this time an unload/dispose event is fired and the page is refreshed.
        Arran Mccullough made changes -
        Attachment Case13433Example.war [ 20380 ]
        Attachment Case13433Example.zip [ 20381 ]
        Ken Fyten made changes -
        Assignee Mircea Toma [ mircea.toma ]
        Fix Version/s 4.1 [ 11375 ]
        Fix Version/s EE-3.3.0.GA_P04 [ 12270 ]
        Assignee Priority P1 [ 10010 ]
        Ken Fyten made changes -
        Assignee Priority P1 [ 10010 ] P2 [ 10011 ]
        Ken Fyten made changes -
        Assignee Priority P2 [ 10011 ] P1 [ 10010 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #45752 Mon Jul 13 18:22:51 MDT 2015 mircea.toma ICE-10706 Register temporarily system event listener that un-marks the form as being AJAX disabled. Next JSF lifecycle the form will be AJAX enabled when the file entry is not enclosed anymore.
        Files Changed
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/fileentry/FileEntryFormSubmit.java
        Hide
        Mircea Toma added a comment -

        Register temporarily a system event listener that un-marks the form as being AJAX disabled. The next JSF lifecycle the form will be AJAX enabled when the file entry is not enclosed anymore.

        Show
        Mircea Toma added a comment - Register temporarily a system event listener that un-marks the form as being AJAX disabled. The next JSF lifecycle the form will be AJAX enabled when the file entry is not enclosed anymore.
        Mircea Toma made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Liana Munroe added a comment -

        Verified ICEfaces 4 trunk, EE-3.3.0 maintenance branch r45745 using attached test case. Tomcat 7, IE 11, FF 34, Chrome 43.

        Show
        Liana Munroe added a comment - Verified ICEfaces 4 trunk, EE-3.3.0 maintenance branch r45745 using attached test case. Tomcat 7, IE 11, FF 34, Chrome 43.
        Judy Guglielmin made changes -
        Link This issue depends on ICE-10760 [ ICE-10760 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #45809 Thu Jul 30 14:38:31 MDT 2015 mircea.toma ICE-10706 Test if form is still present in the view.
        Files Changed
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/fileentry/FileEntryFormSubmit.java
        Hide
        Ken Fyten added a comment -

        Re-opened due to regressions noted in ICE-10760.

        Show
        Ken Fyten added a comment - Re-opened due to regressions noted in ICE-10760.
        Ken Fyten made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Ken Fyten made changes -
        Link This issue blocks ICE-10760 [ ICE-10760 ]
        Ken Fyten made changes -
        Link This issue blocks ICE-10760 [ ICE-10760 ]
        Hide
        Mircea Toma added a comment - - edited

        Checked in a fix a few days ago, commit #45809

        Show
        Mircea Toma added a comment - - edited Checked in a fix a few days ago, commit #45809
        Mircea Toma made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Liana Munroe added a comment -

        Verified ICEfaces 4 trunk, EE-3.3.0 maintenance branch r45816 using attached test case. Tomcat 7, IE 11, 10, 9, 8, 7, FF 34, Chrome 43. ICE-10760 was verified as well.

        Show
        Liana Munroe added a comment - Verified ICEfaces 4 trunk, EE-3.3.0 maintenance branch r45816 using attached test case. Tomcat 7, IE 11, 10, 9, 8, 7, FF 34, Chrome 43. ICE-10760 was verified as well.
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Mircea Toma
            Reporter:
            Arran Mccullough
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: