ICEfaces
  1. ICEfaces
  2. ICE-10699

ice:panelGroup revert feature doesn't position elements correctly when using dragGhost or ghosting

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: EE-1.8.2.GA_P07
    • Fix Version/s: EE-1.8.2.GA_P08
    • Component/s: ICE-Components
    • Labels:
      None
    • Environment:
      ICEfaces 1.8.2

      Description

      When using the 'revert' option in draggable ice:panelGroup's, the element is positioned incorrectly after the reverting occurs. This is clearly seen in newer browsers. The panels are positioned at the right height but slightly off horizontally.

        Activity

        Arturo Zambrano created issue -
        Ken Fyten made changes -
        Field Original Value New Value
        Fix Version/s EE-1.8.2.GA_P08 [ 11178 ]
        Arturo Zambrano made changes -
        Assignee Arturo Zambrano [ artzambrano ]
        Arturo Zambrano made changes -
        Summary Reverting feature doesn't position elements correctly in newer browsers ice:panelGroup revert feature doesn't position elements correctly in newer browsers
        Hide
        Arturo Zambrano added a comment -

        The specific problems are when using dragGhost and revert together, or ghosting and revert together. So, far it's possible to just remove the ghost/clone nodes, but the revert effect cannot be applied, because the underlying code from the Scriptaculous library assumes the element to move is the main element and not the clone. The dragGhost feature is a custom feature implemented by us, but it's not well integrated with the revert logic.

        Show
        Arturo Zambrano added a comment - The specific problems are when using dragGhost and revert together, or ghosting and revert together. So, far it's possible to just remove the ghost/clone nodes, but the revert effect cannot be applied, because the underlying code from the Scriptaculous library assumes the element to move is the main element and not the clone. The dragGhost feature is a custom feature implemented by us, but it's not well integrated with the revert logic.
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #44808 Tue Jun 02 20:38:06 MDT 2015 art.zambrano ICE-10699 fix to immediately remove the ghost node when using revert, in order to avoid an odd revert behaviour
        Files Changed
        Commit graph MODIFY /icefaces/trunk/icefaces/bridge/lib/extras/draggable_ext.js
        Commit graph MODIFY /icefaces/trunk/icefaces/bridge/lib/scriptaculous/dragdrop.js
        Hide
        Arturo Zambrano added a comment -

        r44808: fix to immediately remove the ghost node when using revert, in order to avoid an odd revert behaviour.

        Show
        Arturo Zambrano added a comment - r44808: fix to immediately remove the ghost node when using revert, in order to avoid an odd revert behaviour.
        Arturo Zambrano made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Arturo Zambrano added a comment -

        To test this, you can simply use the component-showcase Drag & Drop demo and modify the page for the draggables to have the options "dragGhost,revert" and "ghosting,revert". This actually was an issue in all browsers.

        Show
        Arturo Zambrano added a comment - To test this, you can simply use the component-showcase Drag & Drop demo and modify the page for the draggables to have the options "dragGhost,revert" and "ghosting,revert". This actually was an issue in all browsers.
        Arturo Zambrano made changes -
        Summary ice:panelGroup revert feature doesn't position elements correctly in newer browsers ice:panelGroup revert feature doesn't position elements correctly when using dragGhost or ghosting
        Carmen Cristurean made changes -
        Attachment IE10_ghosting_revert2.PNG [ 19982 ]
        Attachment IE10_ghosting_revert1.PNG [ 19983 ]
        Ken Fyten made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Hide
        Arturo Zambrano added a comment -

        As for the issue with 'ghosting' on all browsers, that behaviour is correct. It's just as if there were no dragOptions at all, the items simply get dropped where you release the mouse button, and they stay there. In the case of 'ghosting' the ghost element is the one that stays there in the drop area.

        Show
        Arturo Zambrano added a comment - As for the issue with 'ghosting' on all browsers, that behaviour is correct. It's just as if there were no dragOptions at all, the items simply get dropped where you release the mouse button, and they stay there. In the case of 'ghosting' the ghost element is the one that stays there in the drop area.
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #45072 Thu Jun 18 15:26:01 MDT 2015 art.zambrano ICE-10699 fix for ghosting + revert options
        Files Changed
        Commit graph MODIFY /icefaces/trunk/icefaces/bridge/lib/extras/draggable_ext.js
        Hide
        Arturo Zambrano added a comment -

        r45072: committed fix for ghosting + revert options

        Show
        Arturo Zambrano added a comment - r45072: committed fix for ghosting + revert options
        Arturo Zambrano made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Arturo Zambrano
            Reporter:
            Arturo Zambrano
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: