ICEfaces
  1. ICEfaces
  2. ICE-10695

Make label/labelPosition consistent across components

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 4.0
    • Fix Version/s: 4.1
    • Component/s: ACE-Components
    • Labels:
      None
    • Environment:
      Any
    • Assignee Priority:
      P2

      Description

      Current "label" and "labelPosition" are available on some ACE components like ace:textEntry, ace:radioButton, etc. it is missing or inconsistent on others. Ideally the components would be checked to see where label should be added. This will allow users to easily create a formatted, properly aligned form without h:outputLabel or a panelGrid.

      - ace:sliderEntry needs label/labelPosition
      - ace:checkboxButton and ace:themeSelect have "label", but it functions differently than the normal label/labelPosition.
      1. showLabelTrue.PNG
        10 kB
      2. sliderLeft.PNG
        8 kB
      3. sliderTop.PNG
        6 kB

        Activity

        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Hide
        Carmen Cristurean added a comment -

        Showcase demos have been added for slider > Label Position (r46300) and themeSelect > Label Position (r46307).

        Show
        Carmen Cristurean added a comment - Showcase demos have been added for slider > Label Position (r46300) and themeSelect > Label Position (r46307).
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #46307 Tue Dec 01 10:44:50 MST 2015 carmen.cristurean ICE-10695 add showcase themeSelect > Label Position demo, move themeSelect demos to 'Selection' group.
        Files Changed
        Commit graph ADD /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/java/org/icefaces/samples/showcase/example/ace/themeSelect/ThemeSelectLabelBean.java
        Commit graph MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/java/org/icefaces/samples/showcase/view/menu/data/CentralDataList.java
        Commit graph ADD /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/themeSelect/themeSelectLabel.xhtml
        Commit graph MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/resources/org/icefaces/samples/showcase/view/resources/messages.properties
        Commit graph MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/java/org/icefaces/samples/showcase/util/PositionBean.java
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #46300 Fri Nov 27 16:46:14 MST 2015 carmen.cristurean ICE-10695: add showcase sliderEntry > Label Position demo.
        Files Changed
        Commit graph ADD /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/slider/sliderEntryLabel.xhtml
        Commit graph MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/java/org/icefaces/samples/showcase/view/menu/data/CentralDataList.java
        Commit graph MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/resources/org/icefaces/samples/showcase/view/resources/messages.properties
        Commit graph MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/java/org/icefaces/samples/showcase/util/PositionBean.java
        Commit graph ADD /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/java/org/icefaces/samples/showcase/example/ace/slider/SliderEntryLabelBean.java
        Hide
        Liana Munroe added a comment - - edited

        I have discovered that this js popup error appears to be occurring also when other components are tested using IE 8 and is not exclusive to sliderEntry. ICE-10817 was opened for this issue.

        Show
        Liana Munroe added a comment - - edited I have discovered that this js popup error appears to be occurring also when other components are tested using IE 8 and is not exclusive to sliderEntry. ICE-10817 was opened for this issue.
        Hide
        Arturo Zambrano added a comment -

        It seems unlikely that this new issue could've caused by the most recent fix, since it consisted only of adding CSS settings and the error occurs in a bridge resource. Please try testing using one revision before the fix (r46106) to see if it's related to this fix or not.

        Show
        Arturo Zambrano added a comment - It seems unlikely that this new issue could've caused by the most recent fix, since it consisted only of adding CSS settings and the error occurs in a bridge resource. Please try testing using one revision before the fix (r46106) to see if it's related to this fix or not.
        Hide
        Liana Munroe added a comment -

        Tested with ICEfaces 4 trunk r46108.
        Verified sliderEntry label alignment issues in all browsers except IE 8. The sliderEntry demo can not be properly accessed in IE 8 due to the following js popup error. This was not an issue with icefaces libs taken from Jenkins build 1539, r46090

        Message: Object doesn't support this property or method
        Line: 1805
        Char: 1
        Code: 0
        URI: http://10.18.39.134:8080/sliderEntry/javax.faces.resource/bridge-support.js.jsf?ln=ice.core&v=4_1_0_151020

        Show
        Liana Munroe added a comment - Tested with ICEfaces 4 trunk r46108. Verified sliderEntry label alignment issues in all browsers except IE 8. The sliderEntry demo can not be properly accessed in IE 8 due to the following js popup error. This was not an issue with icefaces libs taken from Jenkins build 1539, r46090 Message: Object doesn't support this property or method Line: 1805 Char: 1 Code: 0 URI: http://10.18.39.134:8080/sliderEntry/javax.faces.resource/bridge-support.js.jsf?ln=ice.core&v=4_1_0_151020
        Arturo Zambrano made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Arturo Zambrano added a comment -

        r46107: fix for label-related alignment issues with ace:sliderEntry.

        Show
        Arturo Zambrano added a comment - r46107: fix for label-related alignment issues with ace:sliderEntry.
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #46107 Tue Oct 20 12:07:37 MDT 2015 art.zambrano ICE-10695 fix for label-related alignment issues with ace:sliderEntry
        Files Changed
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/sliderentry/SliderEntryRenderer.java
        Liana Munroe made changes -
        Attachment showLabelTrue.PNG [ 21784 ]
        Liana Munroe made changes -
        Attachment sliderLeft.PNG [ 21782 ]
        Attachment sliderTop.PNG [ 21783 ]
        Liana Munroe made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Hide
        Liana Munroe added a comment - - edited

        Tested with ICEfaces 4 trunk r46094.
        Styling issue when using sliderEntry label attribute and showLabels=false in Firefox browsers. When label is positioned at left or right the sliderEntry gains height and becomes taller than the slider itself. Not an issue when sliderEntry is positioned at top or bottom. Not an issue with Chrome or IE browsers. See attached screen shots sliderLeft.png and sliderTop.png.
        In all browsers when showLabels=true, and the label is positioned at left or right, the label is positioned lower than the slider min/max labels. See screenshot showLabelTrue.png

        QA test app /sliderEntryLabel.jsf added to:
        http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces4/Sparkle/Nightly/sliderEntry

        Show
        Liana Munroe added a comment - - edited Tested with ICEfaces 4 trunk r46094. Styling issue when using sliderEntry label attribute and showLabels=false in Firefox browsers. When label is positioned at left or right the sliderEntry gains height and becomes taller than the slider itself. Not an issue when sliderEntry is positioned at top or bottom. Not an issue with Chrome or IE browsers. See attached screen shots sliderLeft.png and sliderTop.png. In all browsers when showLabels=true, and the label is positioned at left or right, the label is positioned lower than the slider min/max labels. See screenshot showLabelTrue.png QA test app /sliderEntryLabel.jsf added to: http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces4/Sparkle/Nightly/sliderEntry
        Hide
        Arturo Zambrano added a comment - - edited

        The following components have a 'label' attribute, but they work in different ways and/or the components aren't input components: ace:dataExporter, ace:dynamicResource, ace:fileEntry, ace:subMenu, ace:tabPane.

        ace:linkButton and ace:pushButton do not have a 'labelPosition' attribute. It's unclear if these attributes would apply to them.

        Show
        Arturo Zambrano added a comment - - edited The following components have a 'label' attribute, but they work in different ways and/or the components aren't input components: ace:dataExporter, ace:dynamicResource, ace:fileEntry, ace:subMenu, ace:tabPane. ace:linkButton and ace:pushButton do not have a 'labelPosition' attribute. It's unclear if these attributes would apply to them.
        Arturo Zambrano made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Arturo Zambrano added a comment -

        r46092: added label and labelPosition attributes to ace:sliderEntry and to ace:themeSelect.
        r46093: modified ace:themeSelect demo to use new label and labelPosition attributes.

        ace:checkboxButton already has label and labelPosition attributes and they work in the same way as in other components. The only difference is that the default position is inField, and that is for backwards compatibility reasons, since that was the way it worked originally, even before the normalized label attributes were added.

        Show
        Arturo Zambrano added a comment - r46092: added label and labelPosition attributes to ace:sliderEntry and to ace:themeSelect. r46093: modified ace:themeSelect demo to use new label and labelPosition attributes. ace:checkboxButton already has label and labelPosition attributes and they work in the same way as in other components. The only difference is that the default position is inField, and that is for backwards compatibility reasons, since that was the way it worked originally, even before the normalized label attributes were added.
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #46093 Thu Oct 15 13:26:05 MDT 2015 art.zambrano ICE-10695 modified ace:themeSelect demo to use new label and labelPosition attributes
        Files Changed
        Commit graph MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/themeSelect/themeSelect.xhtml
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #46092 Thu Oct 15 13:24:45 MDT 2015 art.zambrano ICE-10695 added label and labelPosition attributes to ace:sliderEntry and to ace:themeSelect
        Files Changed
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/themeselect/ThemeSelectMeta.java
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/sliderentry/SliderEntryMeta.java
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/themeselect/ThemeSelectRenderer.java
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/sliderentry/SliderEntryRenderer.java
        Ken Fyten made changes -
        Assignee Ken Fyten [ ken.fyten ] Arturo Zambrano [ artzambrano ]
        Assignee Priority P2 [ 10011 ]
        Ken Fyten made changes -
        Field Original Value New Value
        Assignee Ken Fyten [ ken.fyten ]
        Fix Version/s 4.1 [ 11375 ]
        Priority Major [ 3 ] Minor [ 4 ]
        Carlo Guglielmin created issue -

          People

          • Assignee:
            Arturo Zambrano
            Reporter:
            Carlo Guglielmin
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: